https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-3132 Lustre <p>b1_8 lfsck test log shows</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>lfsck 1.42.6.wc2 (10-Dec-2012) lfsck: ost_idx 0: pass1: check for duplicate objects lfsck: ost_idx 0: pass1 OK (20 files total) lfsck: ost_idx 0: pass2: check for missing inode objects [0]: failed to recreate /mnt/lustre/d0.lfsck/testfile.7 missing obj 0:12 lfsck: ost_idx 0: pass2 ERROR: 1 dangling inodes found (21 files total) </pre> </div></div> <p>The maloo report is at <a href="https://maloo.whamcloud.com/test_sessions/61ecab6c-a051-11e2-898f-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sessions/61ecab6c-a051-11e2-898f-52540035b04c</a></p> LU-3132

lfsck: failed to recreate /mnt/lustre/d0.lfsck/testfile.7 missing obj 0:12

Bug Minor Closed Fixed Emoly Liu Emoly Liu Tue, 9 Apr 2013 03:08:20 +0000 Tue, 14 May 2013 00:26:11 +0000 Tue, 14 May 2013 00:26:01 +0000 Lustre 1.8.9 Lustre 1.8.9 0 3 <p>I added some debugging info to ll_lov_recreate().</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">@@ -2254,6 +2254,8 @@ <span class="code-keyword">static</span> <span class="code-object">int</span> ll_lov_recreate(struct inode *inode, obd_id id, obd_gr gr, out: up(&amp;lli-&gt;lli_size_sem); OBDO_FREE(oa); + printk(<span class="code-quote">"rc=%d: [%u] recreate missing obj "</span>LPU64<span class="code-quote">":"</span>LPU64<span class="code-quote">"\n"</span>, + rc, (__u32)ost_idx, id, gr); <span class="code-keyword">return</span> rc; } </pre> </div></div> <p>lfsck output showed that there were 5 dangling inodes,</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>lfsck: ost_idx 0: pass2: check for missing inode objects [0]: failed to recreate /mnt/lustre/d0.lfsck/testfile.1 missing obj 0:34 [0]: failed to recreate /mnt/lustre/d0.lfsck/testfile.3 missing obj 0:35 [0]: failed to recreate /mnt/lustre/d0.lfsck/testfile.5 missing obj 0:36 [0]: failed to recreate /mnt/lustre/d0.lfsck/testfile.7 missing obj 0:37 [0]: failed to recreate /mnt/lustre/d0.lfsck/testfile.9 missing obj 0:38 lfsck: ost_idx 0: pass2 ERROR: 5 dangling inodes found (76 files total) </pre> </div></div> <p>but the debugging info showed ost_idx and id in struct ll_recreate_obj passed from lfsck_recreate_obj() by ioctl is wrong.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>rc=-22: [0] recreate missing obj 47571424239216:0 rc=-22: [0] recreate missing obj 47571424239216:0 rc=-22: [0] recreate missing obj 47571424239216:0 rc=-22: [0] recreate missing obj 47571424239216:0 rc=-22: [0] recreate missing obj 47571424239216:0 </pre> </div></div> <p>I will investigate it.</p> <p>After looking into lfsck.c, I found something wrong in lfsck_recreate_obj().</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-comment">/* If an MDS file is missing an object recreate object using an ioctl call */</span> <span class="code-keyword">static</span> <span class="code-object">int</span> lfsck_recreate_obj(<span class="code-object">int</span> cmd, void *creat, struct ost_id *oi, __u32 ost_idx, <span class="code-object">char</span> *path) { ...... rc = ioctl(fd, cmd, &amp;creat); </pre> </div></div> <p>Here, "creat" is already a pointer to struct ll_recreate_obj variable, so we should pass it into ioctl directly.</p> <p>I will push a patch later.</p> <p><a href="http://review.whamcloud.com/#change,6181" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,6181</a></p> <p>patch landed.</p> Related LU-3041 Development Rank 1|hzvnev: Rank (Obsolete) 7605 Severity