https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-3232 Lustre <p>The fsfilt_ldiskfs.ko module is currently part of the lustre-modules rpm. However, it uses ldiskfs functions directly, and therefore should be part of the lustre-osd-ldiskfs rpm instead.</p> <p>This issue could be made moot by <a href="https://jira.whamcloud.com/browse/LU-2158" title="remove lvfs and fsfilt code" class="issue-link" data-issue-key="LU-2158"><del>LU-2158</del></a>, however it is none too clear that it will be completed in time for 2.4.0. If it is not, we should at least fix up the packaging.</p> LU-3232

fsfilt_ldiskfs.ko should be in osd-ldiskfs rpm

Bug Minor Resolved Fixed Bruno Faccini Christopher Morrone Thu, 25 Apr 2013 20:26:33 +0000 Mon, 12 Aug 2013 20:53:47 +0000 Mon, 12 Aug 2013 20:53:47 +0000 Lustre 2.4.1 Lustre 2.5.0 0 6 <p>I'd rather just wait for ldiskfs to be deleted via <a href="https://jira.whamcloud.com/browse/LU-2158" title="remove lvfs and fsfilt code" class="issue-link" data-issue-key="LU-2158"><del>LU-2158</del></a>, and I think this would just be a distraction to that effort.</p> <p>May be I can add some conditional statement in what I did for <a href="https://jira.whamcloud.com/browse/LU-2391" title="warning messages for missing symbols when lustre-modules::osd_zfs.ko installed on a system without zfs-modules installed" class="issue-link" data-issue-key="LU-2391"><del>LU-2391</del></a>, to add fsfilt_ldiskfs.ko in lustre-osd-ldiskfs rpm if it exists ?</p> <p>I'd prefer to avoid a conditional. We'll forget to remove and clean it up when <a href="https://jira.whamcloud.com/browse/LU-2158" title="remove lvfs and fsfilt code" class="issue-link" data-issue-key="LU-2158"><del>LU-2158</del></a> is finished. If <a href="https://jira.whamcloud.com/browse/LU-2158" title="remove lvfs and fsfilt code" class="issue-link" data-issue-key="LU-2158"><del>LU-2158</del></a> is really going to land for 2.4.0, we can hold off adjusting the spec file.</p> <p>If the <a href="https://jira.whamcloud.com/browse/LU-2158" title="remove lvfs and fsfilt code" class="issue-link" data-issue-key="LU-2158"><del>LU-2158</del></a> doesn't land for 2.4.0, we should land the following patch:</p> <p><a href="http://review.whamcloud.com/6260" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6260</a></p> <p>Honestly, I would argue that we should land <a href="http://review.whamcloud.com/6260" class="external-link" target="_blank" rel="nofollow noopener">6260</a> now. Then <a href="https://jira.whamcloud.com/browse/LU-2158" title="remove lvfs and fsfilt code" class="issue-link" data-issue-key="LU-2158"><del>LU-2158</del></a> can simply remove the two added spec files lines as part of that landing in the future.</p> <p>Guys, I really think my patch needs to land for 2.4.0.</p> <p>Without my patch, the lustre-modules rpm requires lustre-osd-ldiskfs, but there is not rpm dependency on said package. So when anyone installs lustre-modules and lustre-osd-zfs, they get this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_free_blocks WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_journal_start_sb WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_journal_stop WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_search_right WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_discard_preallocations WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_calc_credits_for_insert WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_insert_extent WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_journal_get_write_access WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_mb_new_blocks WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_search_left WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_bread WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_walk_space WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_map_inode_page WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_handle_dirty_metadata WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_free_blocks WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_journal_start_sb WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_journal_stop WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_search_right WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_discard_preallocations WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_calc_credits_for_insert WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_insert_extent WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_journal_get_write_access WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_mb_new_blocks WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_search_left WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_bread WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_ext_walk_space WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol ldiskfs_map_inode_page WARNING: /lib/modules/2.6.32-358.6.1.3chaos.ch5.1.x86_64/updates/kernel/fs/lustre/fsfilt_ldiskfs.ko needs unknown symbol __ldiskfs_handle_dirty_metadata </pre> </div></div> <p><a href="https://jira.whamcloud.com/browse/LU-2158" title="remove lvfs and fsfilt code" class="issue-link" data-issue-key="LU-2158"><del>LU-2158</del></a> is delayed until 2.5, so this really is a requirement for 2.4.0.</p> <p>Chris, Sorry to leave it without answer/update but I missed the fact that <a href="https://jira.whamcloud.com/browse/LU-2158" title="remove lvfs and fsfilt code" class="issue-link" data-issue-key="LU-2158"><del>LU-2158</del></a> was delayed ...<br/> Just added me to change's reviewers list and bumped its score.</p> <p>New patch for b2_4:</p> <p> <a href="http://review.whamcloud.com/6471" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6471</a></p> <p>Rebased patch on master:</p> <p> <a href="http://review.whamcloud.com/6260" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6260</a></p> <p>It looks to me that this is landed for 2.4.1 and 2.5</p> Related LU-2158 LU-3407 Development Rank 1|hzvp3j: Rank (Obsolete) 7897 Severity