https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-3273 Lustre <p>During replay mdt_mfd_open() calls mdt_handle2mfd() with out holding the med_open_lock. This seems like an potentially unsafe walk of the med_open_head list. It later takes the lock to unlink mfd, but it does not seem to check that it has won the possible race to unlink this mfd.</p> LU-3273

mdt_mfd_open() may call mdt_handle2mfd() w/o holding med_open_lock

Bug Minor Resolved Fixed John Hammond John Hammond mdt patch Sat, 4 May 2013 17:54:16 +0000 Thu, 19 Dec 2013 14:27:23 +0000 Thu, 19 Dec 2013 14:27:23 +0000 Lustre 2.4.0 Lustre 2.5.0 Lustre 2.4.2 0 5 <p>during replay we do not have any concurrency at the moment. literally all the replays are done within the context of special recovery thread, one by one.</p> <p>Alex, is it true that recovery is still single-threaded today? I thought I saw issues in the past where this assumption was incorrect? In any case, holding locks in the single-threaded case would not cause contention, and makes the code more correct for readers and for static code analysis tools.</p> <p>I have submitted a patch to fix this bug here (<a href="http://review.whamcloud.com/#/c/7272/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7272/</a>)</p> <p>Patch landed to master.</p> Development Rank 1|hzvq5j: Rank (Obsolete) 8110 Severity