https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-329 Lustre <p>While adapting <a href="https://jira.whamcloud.com/browse/LU-234" title="OOM killer causes node hang" class="issue-link" data-issue-key="LU-234"><del>LU-234</del></a> to our branch I've found that ost_lock_put() is not called in some error cases. <a href="https://jira.whamcloud.com/browse/LU-234" title="OOM killer causes node hang" class="issue-link" data-issue-key="LU-234"><del>LU-234</del></a> added even more such cases. Please check patch attached. I have the question there - do we need to report repbody in case of error in ost_punch()? I doubt that but it is always returned there no matter is 'rc' zero or not.</p> LU-329

ost_lock_get() is not put in some cases

Bug Minor Resolved Fixed Lai Siyao Mikhail Pershin Mon, 16 May 2011 08:53:16 +0000 Mon, 5 Dec 2011 22:25:21 +0000 Mon, 5 Dec 2011 22:25:21 +0000 Lustre 2.1.0 Lustre 2.1.0 0 1 <p>I see repbody filled in most ost_xxx() operations, actually it looks to be a waste in case of error, but it's not a problem, and no need to get fixed here IMO.</p> <p>Mike</p> <p>Are you ok to close this ticket in light of Lai's response?</p> <p>thanks</p> <p>Peter</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=ofa/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,ofa #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=sles11,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,sles11,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=ofa/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,ofa #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=ofa/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,ofa #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el6,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el6,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=ofa/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,ofa #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=ofa/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,ofa #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el6,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el6,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el6,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el6,ib_stack=inkernel/167/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el6,inkernel #167</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=inkernel/170/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,inkernel #170</a><br/> <a href="https://jira.whamcloud.com/browse/LU-329" title="ost_lock_get() is not put in some cases" class="issue-link" data-issue-key="LU-329"><del>LU-329</del></a> fix missing ost_lock_put() calls</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=c0468e08ce5864884265a542606f6253cce19bad" class="external-link" target="_blank" rel="nofollow noopener">c0468e08ce5864884265a542606f6253cce19bad</a><br/> Files : </p> <ul> <li>lustre/ost/ost_handler.c</li> </ul> Development Rank 1|hzv8zr: Rank (Obsolete) 4991 Severity