https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-3332 Lustre <p>Currently, sanity-scrub.sh still use SINGLEMDS in the script, which make it unable to run with DNE configuration.</p> LU-3332

sanity-scrub and sanity-lfsck need to support DNE

Bug Blocker Resolved Fixed Li Wei Di Wang MB Tue, 14 May 2013 07:21:22 +0000 Tue, 3 Sep 2013 15:22:36 +0000 Tue, 3 Sep 2013 15:22:36 +0000 Lustre 2.5.0 Lustre 2.5.0 0 6 <p> <a href="http://review.whamcloud.com/6333" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6333</a> Unfortunately, it might need many changes, and I do not have time to finish all of them. I only fix 0 and 1a. Maybe someone else can help to fix all of the script problem. So sanity-scrub can be run with DNE. Thanks.</p> <p>Di Wang is correct a great many changes are needed. Not quite every line will have to be touched touched but pretty close. </p> <p>I am a bit of a ways into a rewrite for sanity-scrub and so far a few spots in test-framework have also be identified. </p> <p>There seems to be some loose timing built into this test in general. Spots where you expect a given transition state, I am not sure if these time checks will work as well with DNE. I am not going to focus on Logic changes to the test at this point just a conversion to DNE safe calls for v1. </p> <p>I think an incremental approach to these changes keep the reviewing of all of this sane, the removal of SINGLEMDS is no small task even just in this one test. I will work on getting some form of a reviewable patch into the system tomorrow that is not a totally a for_test_only sort of patch and setup a proper expect always to allow DNE to run a few tests. </p> <p>My approach is slightly different that Di Wangs so I will open a new patch or two. I like use of helper functions to make the test more readable and radically decrease the amount of code.</p> <p>for instance my test_0 presently looks like: </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>test_0() { local num scrub_prep 0 echo "start $SINGLEMDS without disabling OI scrub" start_all_mds($MOUNT_OPTS_SCRUB) check_status("init") check_flags() mount_client $MOUNT || error "Failed to start client!" check_diff() } run_test 0 "Do not auto trigger OI scrub for non-backup/restore case" </pre> </div></div> <p>Hmm, I thought Li wei worked on this ticket already. <a href="http://review.whamcloud.com/#change,6333" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,6333</a></p> <p>Thanks for the link to that patch. Peter had asked me to look at this LU earlier this week. </p> <p>That is exactly the style of patch I was working on and will give it a good review. </p> <p>I can't imagine how happy I'd be if I knew you were to on this. Too bad neither of us had left any obvious messages here earlier.</p> <p>Patch has landed to Master. Please let me know if more work is needed in this ticket and I will reopen.</p> Duplicate LU-3150 Related LU-3420 LU-2915 Development Rank 1|hzvqtr: Rank (Obsolete) 8232 Severity