[LU-3346] The assignment of obt_sb was removed

Related — Mon, 21 Oct 2013 19:44:46 +0000

Hi,

Coverity has found a strange piece of code in check_and_start_recovery_timer() function:

if (!(lsi->lsi_flags | LDD_F_IR_CAPABLE))
service_time += 2 * (CONNECTION_SWITCH_MAX +
CONNECTION_SWITCH_INC);

According to the tool, 'lsi->lsi_flags | LDD_F_IR_CAPABLE' is useless because it is always true. So it seems the developer meant to use '&' instead of '|'.

But if we change the code accordingly, then we hit a number of issues because of unprotected access to recovery timer, as seen in https://maloo.whamcloud.com/test_sessions/96125f26-bc36-11e2-b013-52540035b04c

Whamcloud Community JIRA

[LU-3346] The assignment of obt_sb was removed