Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-3498] most uses of IS_ERR_VALUE() are incorrect https://jira.whamcloud.com/browse/LU-3498 Lustre <p>We have several places in the code that do something equivalent the following</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>int rc = PTR_ERR(foo); if (IS_ERR_VALUE(rc)) bar(); </pre> </div></div> <p>which is wrong.</p> LU-3498 most uses of IS_ERR_VALUE() are incorrect Bug Critical Resolved Fixed John Hammond John Hammond Mon, 24 Jun 2013 14:39:34 +0000 Fri, 27 Jun 2014 07:16:53 +0000 Tue, 22 Apr 2014 22:40:30 +0000 Lustre 2.5.0 Lustre 2.6.0 Lustre 2.5.2 0 6 <p>Please see <a href="http://review.whamcloud.com/6759" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6759</a>.</p> <p>Patch landed to master for 2.6.0.</p> <p>As John points out in <a href="https://jira.whamcloud.com/browse/LU-4985" title="Return value of kthread_run truncated to 32-bit int in ll_sa thread and elsewhere" class="issue-link" data-issue-key="LU-4985"><del>LU-4985</del></a>, it would be good to port <a href="http://review.whamcloud.com/#/c/6759/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/6759/</a> to b2_5.</p> <p>Here is the port to b2_5: <a href="http://review.whamcloud.com/#/c/10178/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10178/</a></p> <p>John, the patch for b2_5 looks like it's ready to land.</p> <p>Bobi Jam's version of the b2_5 patch has landed:</p> <p><a href="http://review.whamcloud.com/#/c/10363/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10363/</a></p> <p>I will abandon my b2_5 patch here:</p> <p><a href="http://review.whamcloud.com/#/c/10178/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10178/</a></p> Duplicate Related LU-5071 Development Rank 1|hzvtuv: Rank (Obsolete) 8795 Severity