https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-3556 Lustre <p>It seems the osd-ldiskfs module depends on the mdd module because of the use of md_capainfo() in osd_object_auth() and osd_capa_get(). That causes a circular dependency on the modules and should be fixed. Problems are only avoided because the OSD module is loaded manually depending on OSD type.</p> LU-3556

osd-ldiskfs module depends on mdd

Bug Major Resolved Fixed Dmitry Eremin Andreas Dilger Wed, 3 Jul 2013 19:16:51 +0000 Tue, 10 Sep 2013 18:51:25 +0000 Tue, 10 Sep 2013 18:51:25 +0000 Lustre 2.4.1 Lustre 2.5.0 Lustre 2.5.0 0 8 <p>probably <a href="http://review.whamcloud.com/#/c/5572/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5572/</a> could help?</p> <p>it should help, yes. Btw, what is the status of that patch? Is it going to be landed soon or is it low priority?</p> <p>We discussed to remove capa code on OST, but also if it is useful for LFSCK like if parent FID is used as simple capa to deny clients to access to an object if they have the wrong parent. </p> <p>For now, would it be easier to just move the tiny code fragment out of mdd_device.c:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">/* * context key constructor/destructor: * mdd_capainfo_key_init, mdd_capainfo_key_fini */ LU_KEY_INIT_FINI(mdd_capainfo, struct md_capainfo); struct lu_context_key mdd_capainfo_key = { .lct_tags = LCT_SESSION, .lct_init = mdd_capainfo_key_init, .lct_fini = mdd_capainfo_key_fini }; struct md_capainfo *md_capainfo(<span class="code-keyword">const</span> struct lu_env *env) { <span class="code-comment">/* NB, in mdt_init0 */</span> <span class="code-keyword">if</span> (env-&gt;le_ses == NULL) <span class="code-keyword">return</span> NULL; <span class="code-keyword">return</span> lu_context_key_get(env-&gt;le_ses, &amp;mdd_capainfo_key); } EXPORT_SYMBOL(md_capainfo); </pre> </div></div> <p>int md_object.h, or some other public header?</p> <p>I'm fine with that. as for capabilities.. I'm not sure we can easily use current infrastructure to do verification on OST because by design the checks are supposed to be done in OSD, but we need checks in OFD?</p> <p>I've pushed <a href="http://review.whamcloud.com/6945:" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6945:</a></p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>LU-3566 osd-ldiskfs: remove dependency on mdd module Move the lu_capainfo_get() function (formerly named md_capainfo()) into obdclass/capa.c instead of mdd_device.c. Otherwise, the osd-ldiskfs.ko module depends on mdd.ko in order to load, and that doesn't really make sense. Move the lu_capainfo structure (formerly named md_capainfo) into lustre_capa.h, and change the structure field prefix to match the new name. Fix up the users of this structure/function, and do some code style cleanup in those functions at the same time. </pre> </div></div> <p>I don't really know much about this code, but it looks like there is a lot of simple cleanup that could be done:</p> <ul class="alternate" type="square"> <li>rename <tt>BYPASS_CAPA</tt> to <tt>LC_BYPASS_CAPA</tt> to make it less generic for upstream submission</li> <li>rename <tt>mdt_set_capainfo()</tt> to <tt>mdt_capainfo_set()</tt>, same for <tt>mdt_dump_capainfo()</tt></li> </ul> <p>It looks like <tt>md_capainfo</tt> was being accessed in the MDT, MDD, and OSD layers. I don't know if that is good or bad, just a bit unexpected.</p> <p>First part was landed to master. Do we need a code clean up?</p> <p>Dependency on mdd has been removed from osd-ldiskfs module.</p> Related LU-3105 Development Rank 1|hzvumn: Rank (Obsolete) 8956 Severity