[LU-3611] Wrong order of locking and allocating memory in mgs_pool_cmd()

Fri, 13 Sep 2013 03:53:37 +0000

In function mgs_pool_cmd(), fsdb_mutex is locked and then mti is allocated. It is not correct and will cause problem if memory allocating fails and leaves fsdb_mutex locked. Following is the codes.

mutex_lock(&fsdb->fsdb_mutex);

if (canceled_label != NULL)

{ OBD_ALLOC_PTR(mti); if (mti == NULL) GOTO(out_cancel, rc = -ENOMEM); }

Whamcloud Community JIRA

[LU-3611] Wrong order of locking and allocating memory in mgs_pool_cmd()