https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-3856 Lustre <p>reproducer</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>mkfs.lustre --mgs --mdt --fsname=lustre --device-size=100000 --reformat /dev/sdb mount -t lustre -o nosvc,abort_recov -n /dev/sdb /mnt/mgt e2label /dev/sdb mount -t lustre -o nomgs,abort_recov -n /dev/sdb /mnt/mdt e2label /dev/sdb </pre> </div></div> <p>For 2.3 Lustre the result of e2label is</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>lustre:MDT0000 lustre-MDT0000 </pre> </div></div> <p>For 2.4 Lustre </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>lustre:MDT0000 lustre:MDT0000 </pre> </div></div> <p>Later this cause error ... index is already in use.</p> <p>I think that this part of mount_lustre.c is invalid.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> } else if (!mop.mo_nomtab) { rc = update_mtab_entry(mop.mo_usource, mop.mo_target, "lustre", mop.mo_orig_options, 0,0,0); /* change label from &lt;fsname&gt;:&lt;index&gt; to &lt;fsname&gt;-&lt;index&gt; * to indicate the device has been registered. */ if (mop.mo_ldd.ldd_flags &amp; LDD_F_VIRGIN) (void) osd_label_lustre(&amp;mop); } </pre> </div></div> <p>The volume label update should be done in any case with update mtab or not.</p> LU-3856

No volume label updates after registered target

Bug Critical Resolved Fixed Alex Zhuravlev Alexander Boyko Thu, 29 Aug 2013 13:00:25 +0000 Tue, 24 Sep 2013 17:12:10 +0000 Tue, 24 Sep 2013 17:12:10 +0000 Lustre 2.4.0 Lustre 2.5.0 0 12 <p>Alex,<br/> Can you please comment on this ticket to let us know if this is the correct fix needed?<br/> Thank you!</p> <p>It looks like these few lines of code should just be moved up below the actual mount:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">for</span> (i = 0, rc = -EAGAIN; i &lt;= mop.mo_retry &amp;&amp; rc != 0; i++) { rc = mount(mop.mo_source, mop.mo_target, <span class="code-quote">"lustre"</span>, flags, (void *)options); <span class="code-keyword">if</span> (rc == 0) { /* change label from &lt;fsname&gt;:&lt;index&gt; to &lt;fsname&gt;-&lt;index&gt; * to indicate the device has been registered. */ <span class="code-keyword">if</span> (mop.mo_ldd.ldd_flags &amp; LDD_F_VIRGIN) (void)osd_label_lustre(&amp;mop); } <span class="code-keyword">else</span> { <span class="code-keyword">if</span> (verbose) { fprintf(stderr, <span class="code-quote">"%s: mount %s at %s "</span> : : } </pre> </div></div> <p>Yes, this patch fix the problem.</p> <p>iirc, the original reason was that tune2fs can't access a device with MMP enabled. though probably tune2fs -f will do.</p> <p>Alex,</p> <p>we don't understand - what you mean. You mean tunefs don't able to change a label as mount finished and MMP will protect a drive? so question - why it's need to move in userspace if it's introduce a new regression.</p> <p>because of ZFS support: we use different mechanisms to store mountdata on ldiskfs and ZFS as was requested by LLNL at some point. so if we want to update mountdate from within the kernel we'd have to implement this additional ZFS-specific mechanism in the kernel as well...</p> <p>we may use an any ZFS attribute to store "label" as do in other places...</p> <p>we do use ZFS attributes for that (a separate one for every member of mountdata), but this is currently hidden within ZFS specific parts of the utils.<br/> if we start to update mountdata from the kernel again we'll have to bring all these bits (including ldiskfs and zfs specifics) into the kernel.</p> <p>it's was done in kernel already (before adding an regression), i don't see problem with it.</p> <p>there was no ZFS support at that time.</p> <p>Could somebody submit a patch to gerrit for this, pleaae?<br/> We need this for 2.5</p> <p><a href="http://review.whamcloud.com/7712" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/7712</a><br/> Xyratex-bug-id: MRP-1325</p> <p>Landed for 2.5.0</p> Development Rank 1|hzvzn3: Rank (Obsolete) 10007 Severity