https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-3963 Lustre <p>Migrate libcfs to emulate Linux kernel APIs, so that when submitting Linux client to upstream kernel, we don't need the abstraction layer which will be rejected by kernel maintainers. The majority of libcfs are cfs_* or ll_* wrappers, and can be cleaned up with scripts doing like "s/cfs_spin_lock/spin_lock". For other functions that cannot be cleaned up this way, we need to look at them in a case-by-case basis.</p> LU-3963

cleanup libcfs wrappers

Improvement Minor Resolved Fixed Nathaniel Clark Peng Tao emc patch Mon, 16 Sep 2013 20:48:12 +0000 Wed, 6 Jul 2016 06:18:16 +0000 Thu, 4 Dec 2014 18:13:31 +0000 Lustre 2.4.0 Lustre 2.5.0 Lustre 2.7.0 0 7 <p>This ticket is for the follow on work in <a href="https://jira.whamcloud.com/browse/LU-1346" title="cleanup libcfs" class="issue-link" data-issue-key="LU-1346"><del>LU-1346</del></a> that will continue into 2.6 so that <a href="https://jira.whamcloud.com/browse/LU-1346" title="cleanup libcfs" class="issue-link" data-issue-key="LU-1346"><del>LU-1346</del></a> can be closed in 2.5.<br/> Any further patches for this should be submitted under this ticket.</p> <p>It would be great to get the base patch for cfs_list conversion (to rename base cfs_list_* functions and add compat wrappers for other arches) so that new patches that are landing can use the list_* versions and avoid increasing the number of functions that need to be converted. </p> <p><a href="http://review.whamcloud.com/#/c/4780" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/4780</a> has been updated. The patch now only changes the libcfs core. It also defines linux api's for non-linux systems and still support the current cfs_* wrappers. </p> <p>Here is something strange. Maloo test for <a href="http://review.whamcloud.com/#/c/7803" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7803</a> report conf-sanity and sanity as failing but when you examine the logs all the test passed. The link for the maloo test results is <a href="https://maloo.whamcloud.com/test_sessions/fa54b9f0-5daa-11e3-a404-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sessions/fa54b9f0-5daa-11e3-a404-52540035b04c</a></p> <p>Patches for atomic conversion to linux api.</p> <p><a href="http://review.whamcloud.com/#/c/7072" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7072</a><br/> <a href="http://review.whamcloud.com/#/c/7073" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7073</a><br/> <a href="http://review.whamcloud.com/#/c/7074" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7074</a><br/> <a href="http://review.whamcloud.com/#/c/7075" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7075</a><br/> <a href="http://review.whamcloud.com/#/c/7076" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7076</a><br/> <a href="http://review.whamcloud.com/#/c/7077" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7077</a></p> <p>The following Ppatches for atomic conversion are ready for inspection:</p> <p><a href="http://review.whamcloud.com/#/c/7072" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7072</a><br/> <a href="http://review.whamcloud.com/#/c/7074" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7074</a></p> <p>Both patches 7072 and 7074 are merged. The patches left to support linux atomics are:</p> <p><a href="http://review.whamcloud.com/#/c/7073" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7073</a><br/> <a href="http://review.whamcloud.com/#/c/7077" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7077</a></p> <p>Merged to head</p> <p>Patch 7073 is still outstanding. Also we have the cfs_list to convert. Please reopen this ticket.</p> <p>James, Sorry about that. </p> <p>List cleanup patches:</p> <p><a href="http://review.whamcloud.com/#/c/9369" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/9369</a><br/> <a href="http://review.whamcloud.com/#/c/9904" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/9904</a><br/> <a href="http://review.whamcloud.com/#/c/9944" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/9944</a></p> <p><a href="http://review.whamcloud.com/10247" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10247</a></p> <p><a href="http://review.whamcloud.com/#/c/10387" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10387</a><br/> <a href="http://review.whamcloud.com/#/c/10525" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10525</a><br/> <a href="http://review.whamcloud.com/#/c/10526" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10526</a></p> <p>The patches for replacing direct HZ access with Linux kernel APIs will be tracked in <a href="https://jira.whamcloud.com/browse/LU-5443" title="Remove references to defined constant HZ" class="issue-link" data-issue-key="LU-5443"><del>LU-5443</del></a>.</p> <p><a href="http://review.whamcloud.com/#/c/11725" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11725</a> - Empty file removal</p> <p><a href="http://review.whamcloud.com/#/c/11729" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11729</a> - Removal last of cfs wrappers for SMP handling.</p> <p>Last two patches posted have been merged. One last patch for cfs list wrrappers is here:</p> <p><a href="http://review.whamcloud.com/#/c/11797" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11797</a></p> <p>Phase I of this work is complete. No more cfs_list or cfs_atomic etc. Now we are unto phase II which is putting libcfs on a diet. Lots of wrappers still exist that are no longer needed so we will now start that cleanup. First patch for that cleanup is here:</p> <p><a href="http://review.whamcloud.com/#/c/11963" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11963</a></p> <p>All the wrappers have been cleaned up. It is best if the phase II work would be done under a new ticket for 2.8. Peter you can close this ticket.</p> <p>James Simmons (uja.ornl@gmail.com) uploaded a new patch: <a href="http://review.whamcloud.com/13070" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13070</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-3963" title="cleanup libcfs wrappers" class="issue-link" data-issue-key="LU-3963"><del>LU-3963</del></a> libcfs: Use kernel's strncasecmp and remove cfs_get_blocked_sigs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1a5bf3003002e317c5e103ad8bb15bf2ab29e030</p> <p>Sorry but I included one last patch to complete the SFS-DEV-004 contract. See <a href="http://wiki.opensfs.org/index.php?title=Contract_SFS-DEV-004" class="external-link" target="_blank" rel="nofollow noopener">http://wiki.opensfs.org/index.php?title=Contract_SFS-DEV-004</a> for details.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13070/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13070/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-3963" title="cleanup libcfs wrappers" class="issue-link" data-issue-key="LU-3963"><del>LU-3963</del></a> libcfs: Use kernel's strncasecmp and remove cfs_get_blocked_sigs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d97075bb9644dba102491280690e58ad8caf1acf</p> Duplicate LU-1346 Related LU-5018 LU-2245 LU-5411 LU-8354 Development Epic client Rank 1|hzw2s7: Rank (Obsolete) 10533