https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-407 Lustre <p>The lustre-modules rpm is neither upgradeable nor uninstallable without forcing on RHEL6.1 (probably all redhat systems). In the %preun script the the name of the lustre-modules rpm is missing the architecture from the end of the name. The scriptlet does the following:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>rpm -ql %{name}-modules-%{version}-%{release} </pre> </div></div> <p>But rpm will only allow one of the following forms:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>rpm -ql %{name}-modules rpm -ql %{name}-modules-%{version} rpm -ql %{name}-modules-%{version}-%{release}.%{_arch} </pre> </div></div> <p>The %post script has the same problem, but the subsequent commands in the scripts hide the error code and allow the script to exit normally.</p> <p>I am not sure why no one else noticed this, so I made a patch that only fixes this for %{_vendor}==redhat. But it may very well be needed on all architectures.</p> RHEL 6.1 LU-407

RPM scriptlets broken because module name is not valid

Bug Minor Resolved Fixed Brian Murrell Christopher Morrone Fri, 10 Jun 2011 17:14:19 +0000 Thu, 4 Aug 2011 10:46:00 +0000 Thu, 4 Aug 2011 10:46:00 +0000 Lustre 2.1.0 1 2 <p>Example patch here:</p> <p> <a href="http://review.whamcloud.com/934" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/934</a></p> <p>I'm happy to update it to be the default behavior for all distros if that is correct.</p> <p>Brian will look into this one</p> <blockquote> <p>But rpm will only allow one of the following forms:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">rpm -ql %{name}-modules rpm -ql %{name}-modules-%{version} rpm -ql %{name}-modules-%{version}-%{release}.%{_arch} </pre> </div></div></blockquote> <p>This doesn't appear to be the case on RHEL 5:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"># rpm -q lustre-modules-2.0.59-2.6.18_194.17.1.el5_lustre.g0091fc7_g0091fc7.x86_64 lustre-modules-2.0.59-2.6.18_194.17.1.el5_lustre.g0091fc7_g0091fc7 # rpm -q lustre-modules-2.0.59-2.6.18_194.17.1.el5_lustre.g0091fc7_g0091fc7 lustre-modules-2.0.59-2.6.18_194.17.1.el5_lustre.g0091fc7_g0091fc7 # rpm -q lustre-modules-2.0.59 lustre-modules-2.0.59-2.6.18_194.17.1.el5_lustre.g0091fc7_g0091fc7 # rpm -q lustre-modules lustre-modules-2.0.59-2.6.18_194.17.1.el5_lustre.g0091fc7_g0091fc7 </pre> </div></div> <p>So this new behavior seems to be a RHEL 6ism. I will test it further.</p> <p>Hrm. RHEL 6 behaves the same as RHEL 5:</p> <p>For the package:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"># rpm -qi lustre-modules-2.0.62-2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661.x86_64 Name : lustre-modules Relocations: (not relocatable) Version : 2.0.62 Vendor: (none) Release : 2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661 Build Date: Mon 13 Jun 2011 04:10:02 PM EEST Install Date: Mon 13 Jun 2011 10:28:41 PM EEST Build Host: rhel6-64-build.lab.whamcloud.com Group : Development/Kernel Source RPM: lustre-2.0.62-2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661.src.rpm Size : 143107327 License: GPL Signature : (none) URL : http:<span class="code-comment">//wiki.whamcloud.com/ </span>Summary : Kernel Lustre modules <span class="code-keyword">for</span> Linux 2.6.32-131.2.1.el6_lustre.gc25aafb.x86_64 Description : Lustre file system, server and network drivers <span class="code-keyword">for</span> Linux 2.6.32-131.2.1.el6_lustre.gc25aafb.x86_64. </pre> </div></div> <p>I am able to query for the package using any subset of components in the name-version-release.distro path:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"># rpm -q lustre-modules lustre-modules-2.0.62-2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661.x86_64 # rpm -q lustre-modules-2.0.62 lustre-modules-2.0.62-2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661.x86_64 # rpm -q lustre-modules-2.0.62-2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661 lustre-modules-2.0.62-2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661.x86_64 # rpm -q lustre-modules-2.0.62-2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661.x86_64 lustre-modules-2.0.62-2.6.32_131.2.1.el6_lustre.gc25aafb.x86_64_g5f64661.x86_64 </pre> </div></div> <p>Is this problem unique to only RHEL6.1 then? We/I don't have a RHEL6.1 here to test with so if you could complete the set of proofs and provide the output of the same tests as the above two but for RHEL6.1, we could get a better picture of the platforms affected. Thanx.</p> <p>This is also failing on my FC13 installed client, preventing me from being able to uninstall this RPM without passing "--nopreun".</p> <ol> <li>rpm -e --nodeps lustre-modules<br/> error: %preun(lustre-modules-1.8.6-2.6.32.26_175.fc12.x86_64.x86_64) scriptlet failed, exit status 1</li> </ol> <ol> <li>rpm -q lustre-modules<br/> lustre-modules-1.8.6-2.6.32.26_175.fc12.x86_64.x86_64</li> </ol> <p>note strange double-arch suffix ^^^^^^<br/> It doesn't make sense to include the arch in the %</p> {version}, which is what I would assume happened here.<br/> <br/> # rpm -ql lustre-modules-1.8.6-2.6.32.26_175.fc12<br/> package lustre-modules-1.8.6-2.6.32.26_175.fc12 is not installed<br/> # rpm -ql lustre-modules-1.8.6-2.6.32.26_175.fc12.x86_64<br/> package lustre-modules-1.8.6-2.6.32.26_175.fc12.x86_64 is not installed<br/> # rpm -ql lustre-modules-1.8.6-2.6.32.26_175.fc12.x86_64.x86_64 {lists modules}<br/> <br/> It probably makes sense to add "|| true" at the end of this line, so at least in case of failure it doesn't break the RPM uninstall. Alternately, if the RPM version is not well defined between distros, something like:<br/> <br/> %post modules<br/> :<br/> :<br/> # "weak modules" support<br/> rpm -ql $(rpm -q %{name}-modules | grep "%{version} <p>-%</p> {release}") |<br/> grep '\.ko$' &gt; /var/run/%{name}-modules<br/> # Suse<br/> if [ -x /usr/lib/module-init-tools/weak-modules ]; then<br/> cat /var/run/%{name}-modules |<br/> /usr/lib/module-init-tools/weak-modules --add-modules<br/> fi<br/> # RedHat<br/> if [ -x /sbin/weak-modules ]; then<br/> cat /var/run/%{name}-modules |<br/> /sbin/weak-modules --add-modules<br/> fi<br/> rm -f /var/run/%{name}-modules<br/> <br/> %preun modules<br/> rpm <del>ql $(rpm -q %{name}-modules | grep "%{version}</del>%{release} <p>") |<br/> grep '\.ko$' &gt; /var/run/%</p> {name} <p>-modules || true</p> <p>On a minor side note, there is no need to grep '\.ko$' when calling weak-modules, it was already done during "rpm -ql".</p> <p>We also see the double .x86_64 in the name, and I can explain that. A standard RHEL/fedora (at least the latest versions, it might have been different previously) kernel has a version string like so:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>1.8.6-2.6.32.26_175.fc12.x86_64 </pre> </div></div> <p>It actually includes the .x86_64 in the version string compiled into the kernel, not just as part of the rpm name. So when lustre includes the kernel version into its packages name, that first .x84_64 really is part of the kernel version string. Only the second one was added as the rpm package architecture designation.</p> <p>I also kind of suspect that this is the reason why you and I see this problem, but Brian Murrell does not when he uses the his kernel string that does NOT end in ".x86_64". I kind of suspect that rpm is doing something stupid where is munges the user's input on the command line before checking it against the canonical package name in the database. So I suspect sees .x86_64 on the end, and strips it off thinking it it just part of the rpm name, when really it IS part of the package name. It should only strip it off when there are two...but I haven't looking into the rpm source yet to see if that is really the case.</p> <p>If rpm were well behaved (and my assumption is correct), it should really try the lookup on the user string first, and only munge it into another form (strip off the trailing part that looks like the architecture designation), if the first lookup fails and then try again.</p> <p>I updated <a href="http://review.whamcloud.com/934" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/934</a> with Andreas' suggestions.</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=ofa/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,ofa #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el6,ib_stack=inkernel/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el6,inkernel #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=inkernel/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,inkernel #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=inkernel/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,inkernel #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el6,inkernel #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=inkernel/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,inkernel #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=ofa/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,ofa #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el6,ib_stack=inkernel/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el6,inkernel #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=sles11,ib_stack=inkernel/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,sles11,inkernel #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=inkernel/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,inkernel #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=ofa/240/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,ofa #240</a><br/> <a href="https://jira.whamcloud.com/browse/LU-407" title="RPM scriptlets broken because module name is not valid" class="issue-link" data-issue-key="LU-407"><del>LU-407</del></a> Fix lustre-modules rpm name in spec file.</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=7fe3a1558a5c990d21759e07c89c33b9cd30599b" class="external-link" target="_blank" rel="nofollow noopener">7fe3a1558a5c990d21759e07c89c33b9cd30599b</a><br/> Files : </p> <ul> <li>lustre.spec.in</li> </ul> Development Rank 1|hzv8n3: Rank (Obsolete) 4934 Severity