https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4077 Lustre <p>lustre: 2.4.0<br/> kernel: patchless_client<br/> build: 2.4.0-RC2-gd3f91c4-PRISTINE-2.6.32-358.6.2.el6_lustre.g230b174.x86_64</p> <p>As you can see, an invalid target ID is being set:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">328479 08RENME 21:40:54.122228367 2013.10.08 0x0 t=[0:0x0:0x0] p=[0x200000007:0x1:0x0] z1 s=[0x200000bd2:0xbc88:0x0] sp=[0x200000007:0x1:0x0] z 328480 17MTIME 21:41:02.306553532 2013.10.08 0x7 t=[0x200000bd2:0xbc88:0x0] </pre> </div></div> <p>Additionally this target ID seems to be persistent:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">328482 02MKDIR 21:44:38.780748749 2013.10.08 0x0 t=[0x200000bd2:0xbc8a:0x0] p=[0x200000007:0x1:0x0] dir 328483 01CREAT 21:44:43.788336497 2013.10.08 0x0 t=[0x200000bd2:0xbc8b:0x0] p=[0x200000bd2:0xbc8a:0x0] x 328484 11CLOSE 21:44:43.789336461 2013.10.08 0x42 t=[0x200000bd2:0xbc8b:0x0] 328485 08RENME 21:44:45.42233725 2013.10.08 0x0 t=[0:0x0:0x0] p=[0x200000bd2:0xbc8a:0x0] y s=[0x200000bd2:0xbc8b:0x0] sp=[0x200000bd2:0xbc8a:0x0] x </pre> </div></div> LU-4077

lfs changelog command: RENME flag displays wrong target FID

Bug Major Resolved Not a Bug WC Triage Colin Faber [X] Tue, 8 Oct 2013 21:49:45 +0000 Sat, 9 Oct 2021 05:49:19 +0000 Sat, 9 Oct 2021 05:49:19 +0000 Lustre 2.4.0 0 7 <p>Colin,<br/> If the source file/directory is not being renamed on top of another file, then I can imagine that the target FID is empty. For example, I suspect that the above log is for the case:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ touch /mnt/lustre/a $ mv /mnt/lustre/a /mnt/lustre/b </pre> </div></div> <p>I expect that if there is a target filename it will appear in the RENME record:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ touch /mnt/lustre/a /mnt/lustre/b $ mv /mnt/lustre/a /mnt/lustre/b </pre> </div></div> <p>Whether it is better to print an empty target or not print it at all, I can't say for sure. Always printing the target FID (even if empty) at least simplifies the output. The lctl changelog command output isn't really intended for direct consumption, it makes more sense to have a tool reading the ChangeLog directly to avoid overhead. </p> <p>To me, this makes not so much sense, as the target FID 'fid' in all other context is the file being acted upon, not the destination directory or file it's writing into.</p> <p>Having sfid indicate the target works fine, it just seems inconsistent with the rest of the logging output.</p> <p>-cf</p> <p>I suspect it is too late to do anything about this, but I've added JC to the CC list, since I think this code was originally added for HSM.</p> <p>As Andreas said, tfid in RENME records is expected to give the target (removed) entry, if any.<br/> It looks this is not a major bug here, just a cosmetic issue in lfs output.<br/> -Thomas</p> Development Rank 1|hzw53z: Rank (Obsolete) 10942 Severity