https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4092 Lustre <p>When changing file ownership mdt_attr_set() should add MDS_INODELOCK_LAYOUT to the ibits (MDS_INODELOCK_UPDATE or MDS_INODELOCK_UPDATE | MDS_INODELOCK_LOOKUP | MDS_INODELOCK_PERM). Semantically it only needs a PR layout lock but I believe that acquiring two separate locks on an object in the same handler is a bad idea.</p> LU-4092

mdt_attr_set should acquire layout lock in some cases

Bug Minor Open Unresolved WC Triage John Hammond mdt Fri, 11 Oct 2013 16:14:33 +0000 Fri, 11 Oct 2013 16:48:02 +0000 Lustre 2.5.0 0 2 <p>I do not understand why would we want a layout lock taken for setattr, can you please elaborate on this?</p> <p>Ownership changes are declared and performed on all subobjects in LOD:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>static int lod_declare_attr_set(const struct lu_env *env, struct dt_object *dt, const struct lu_attr *attr, struct thandle *handle) struct dt_object *next = dt_object_child(dt); struct lod_object *lo = lod_dt_obj(dt); int rc, i; ENTRY; /* * declare setattr on the local object */ rc = dt_declare_attr_set(env, next, attr, handle); if (rc) RETURN(rc); /* osp_declare_attr_set() ignores all attributes other than * UID, GID, and size, and osp_attr_set() ignores all but UID * and GID. Declaration of size attr setting happens through * lod_declare_init_size(), and not through this function. * Therefore we need not load striping unless ownership is * changing. This should save memory and (we hope) speed up * rename(). */ if (!(attr-&gt;la_valid &amp; (LA_UID | LA_GID))) RETURN(rc); /* * load striping information, notice we don't do this when object * is being initialized as we don't need this information till * few specific cases like destroy, chown */ rc = lod_load_striping(env, lo); if (rc) RETURN(rc); /* * if object is striped declare changes on the stripes */ LASSERT(lo-&gt;ldo_stripe || lo-&gt;ldo_stripenr == 0); for (i = 0; i &lt; lo-&gt;ldo_stripenr; i++) { LASSERT(lo-&gt;ldo_stripe[i]); rc = dt_declare_attr_set(env, lo-&gt;ldo_stripe[i], attr, handle); if (rc) { CERROR("failed declaration: %d\n", rc); break; } } RETURN(rc); } </pre> </div></div> Development Rank 1|hzw5ev: Rank (Obsolete) 10998 Severity