https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4135 Lustre <p>The mdt_save_lock() is broken and doesn't save any lock ever but simply unlock it. That happens because mti_has_trans is always 0 and is not updated upon transaction execution since commit 607905a789357a34166f34e7c992b03f5040eafc.</p> <p>Another issue with mdt_save_lock is 'req' variable which can be NULL in codepath mdt_export_cleanup()<del>&gt;mdt_ctxt_add_dirty_flag</del>&gt;mdt_add_dirty_flag-&gt;mdt_object_unlock()-&gt;mdt_save_lock().</p> LU-4135

mdt_save_lock() is broken

Bug Blocker Resolved Fixed Mikhail Pershin Mikhail Pershin Wed, 23 Oct 2013 11:12:11 +0000 Mon, 31 Jan 2022 03:45:13 +0000 Mon, 18 Nov 2013 13:36:53 +0000 Lustre 2.5.0 Lustre 2.6.0 Lustre 2.5.1 0 3 <p>patch to fix this issue: <a href="http://review.whamcloud.com/8048" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/8048</a></p> <p>So how does this manifests itself? a crash in a specific circumstances or what?<br/> Also how did you find it and when will this hit in real world?</p> <p>I've found that during testing side patches for Unified Target but it is clear that req is taken from mdt_thread_info and it is NULL in case of mdt_export_cleanup() in master as well, so I created this bug. Meanwhile I wonder why we don't see that issue in master tests and find out that things are even worse, currently in master mdt_save_lock() never saves them but just do unlock because mti_has_trans is always 0 after commit 607905a789357a34166f34e7c992b03f5040eafc. In my patches for UT it works and bug happens.</p> <p>This issue is quite critical now because we broke important part of recovery so I'd change summary to something like "restore mdt_lock_save() functionality". Patch is refreshed already to fix both issues.</p> <p>With proper mdt_save_lock() functionality the oops happens in test 52 sanity-hsm.sh due to NULL req variable as I wrote in first comment.</p> <p>patch was merged</p> <p>Patch was also merged to b2_5 and will be in the 2.5.1 release.</p> Duplicate LU-4103 LU-4143 LU-4142 Related LU-4143 Development Rank 1|hzw6n3: Rank (Obsolete) 11218 Severity