https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4362 Lustre <p>cfs_hash_rehash_key()-&gt;cfs_hash_keycpy(hs, new_key, hnode);<br/> but define of cfs_hash_keycpy is:<br/> void cfs_hash_keycpy(cfs_hash_t *hs, struct hlist_node *hnode, void *key)</p> <p>This is very dangerous because it can corrupt memory.<br/> I will post a patch soon</p> LU-4362

cfs_hash_rehash_key() passed wrong parameters to cfs_hash_keycpy

Bug Blocker Resolved Fixed Liang Zhen Liang Zhen Mon, 9 Dec 2013 12:37:04 +0000 Wed, 20 Jan 2016 23:04:06 +0000 Wed, 18 Dec 2013 16:02:45 +0000 Lustre 2.4.1 Lustre 2.5.0 Lustre 2.6.0 Lustre 2.6.0 Lustre 2.4.2 Lustre 2.5.1 1 3 <p>patch for master: <a href="http://review.whamcloud.com/8509" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/8509</a><br/> patch for b2_4: <a href="http://review.whamcloud.com/8510" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/8510</a><br/> patch for b2_1: <a href="http://review.whamcloud.com/8511" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/8511</a><br/> patch for b2_5: <a href="http://review.whamcloud.com/8512" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/8512</a></p> <p>IMHO the interesting question is: Why couldn't the compiler help to prevent this bug as a type error in the first place? Wouldn't it help if the prototype of cfs_hash_keycpy() did not use a void* type for the "key" argument?</p> <p>Karsten, I will add const for key type in upcoming patch, which can prevent this from happening. </p> <p>Landed for 2.4.2 and 2.6. Will land for 2.5.1 shortly</p> Related Development Rank 1|hzwaxb: Rank (Obsolete) 11945 Severity