<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 01:42:03 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-4363] (llite_lib.c:1683:ll_update_inode()) ASSERTION( lu_fid_eq(&amp;lli-&gt;lli_fid, &amp;body-&gt;fid1) ) failed</title>
                <link>https://jira.whamcloud.com/browse/LU-4363</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;Hi,&lt;/p&gt;

&lt;p&gt;At IFERC customer site, 7 compute nodes crashed with the following message in the console:&lt;/p&gt;

&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;2013-11-21 00:57:45 LustreError: 92325:0:(llite_lib.c:1683:ll_update_inode()) ASSERTION( lu_fid_eq(&amp;amp;lli-&amp;gt;lli_fid, &amp;amp;body-&amp;gt;fid1) ) failed: Trying to change FID [0x217294ce4:0x107f0:0x0] to the [0x217294ce4:0x107f1:0x0], inode 150634522759727089/35072332(ffff8807dcbf85f8)
2013-11-21 00:57:45 LustreError: 92325:0:(llite_lib.c:1683:ll_update_inode()) LBUG
2013-11-21 00:57:45 Pid: 92325, comm: writer_v131
2013-11-21 00:57:45
2013-11-21 00:57:45 Call Trace:
2013-11-21 00:57:45  [&amp;lt;ffffffffa046f7f5&amp;gt;] libcfs_debug_dumpstack+0x55/0x80 [libcfs]
2013-11-21 00:57:45  [&amp;lt;ffffffffa046fe07&amp;gt;] lbug_with_loc+0x47/0xb0 [libcfs]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a91ca0&amp;gt;] ll_update_inode+0x4a0/0xf60 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a928ea&amp;gt;] ll_prep_inode+0x18a/0xae0 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a7c8c3&amp;gt;] ll_intent_file_open+0x563/0xb80 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0aa6a90&amp;gt;] ? ll_md_blocking_ast+0x0/0x700 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffff8108163e&amp;gt;] ? down+0x2e/0x50
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a7cf67&amp;gt;] ll_lov_setstripe_ea_info+0x87/0x2b0 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a831a5&amp;gt;] ll_lov_setstripe+0x85/0x5a0 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0aa3e8b&amp;gt;] ? ll_stats_ops_tally+0x6b/0xd0 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a84ac6&amp;gt;] ll_file_ioctl+0x826/0xe00 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffff81179ff2&amp;gt;] vfs_ioctl+0x22/0xa0
2013-11-21 00:57:45  [&amp;lt;ffffffff8117a4ba&amp;gt;] do_vfs_ioctl+0x3aa/0x580
2013-11-21 00:57:45  [&amp;lt;ffffffff8117a711&amp;gt;] sys_ioctl+0x81/0xa0
2013-11-21 00:57:45  [&amp;lt;ffffffff8149970e&amp;gt;] ? do_device_not_available+0xe/0x10
2013-11-21 00:57:45  [&amp;lt;ffffffff810030f2&amp;gt;] system_call_fastpath+0x16/0x1b
2013-11-21 00:57:45
2013-11-21 00:57:45 Kernel panic - not syncing: LBUG
2013-11-21 00:57:45 Pid: 92325, comm: writer_v131 Tainted: G        W  ---------------    2.6.32-279.5.2.bl6.Bull.36.x86_64 #1
2013-11-21 00:57:45 Call Trace:
2013-11-21 00:57:45  [&amp;lt;ffffffff81495fe3&amp;gt;] ? panic+0xa0/0x168
2013-11-21 00:57:45  [&amp;lt;ffffffffa046fe5b&amp;gt;] ? lbug_with_loc+0x9b/0xb0 [libcfs]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a91ca0&amp;gt;] ? ll_update_inode+0x4a0/0xf60 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a928ea&amp;gt;] ? ll_prep_inode+0x18a/0xae0 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a7c8c3&amp;gt;] ? ll_intent_file_open+0x563/0xb80 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0aa6a90&amp;gt;] ? ll_md_blocking_ast+0x0/0x700 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffff8108163e&amp;gt;] ? down+0x2e/0x50
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a7cf67&amp;gt;] ? ll_lov_setstripe_ea_info+0x87/0x2b0 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a831a5&amp;gt;] ? ll_lov_setstripe+0x85/0x5a0 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0aa3e8b&amp;gt;] ? ll_stats_ops_tally+0x6b/0xd0 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffffa0a84ac6&amp;gt;] ? ll_file_ioctl+0x826/0xe00 [lustre]
2013-11-21 00:57:45  [&amp;lt;ffffffff81179ff2&amp;gt;] ? vfs_ioctl+0x22/0xa0
2013-11-21 00:57:45  [&amp;lt;ffffffff8117a4ba&amp;gt;] ? do_vfs_ioctl+0x3aa/0x580
2013-11-21 00:57:45  [&amp;lt;ffffffff8117a711&amp;gt;] ? sys_ioctl+0x81/0xa0
2013-11-21 00:57:45  [&amp;lt;ffffffff8149970e&amp;gt;] ? do_device_not_available+0xe/0x10
2013-11-21 00:57:45  [&amp;lt;ffffffff810030f2&amp;gt;] ? system_call_fastpath+0x16/0x1b
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;This issue looks like &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-2523&quot; title=&quot;ll_update_inode()) ASSERTION( lu_fid_eq(&amp;amp;lli-&amp;gt;lli_fid, &amp;amp;body-&amp;gt;fid1) ) failed: Trying to change FID&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-2523&quot;&gt;&lt;del&gt;LU-2523&lt;/del&gt;&lt;/a&gt; and &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-3311&quot; title=&quot;Interop 2.1.5&amp;lt;-&amp;gt;2.4 failure on test suite sanity test_27B: (llite_lib.c:1792:ll_update_inode()) ASSERTION( lu_fid_eq(&amp;amp;lli-&amp;gt;lli_fid, &amp;amp;body-&amp;gt;fid1) ) failed&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-3311&quot;&gt;&lt;del&gt;LU-3311&lt;/del&gt;&lt;/a&gt;, but the patch for b2_1 has not made any progress since July.&lt;/p&gt;

&lt;p&gt;I havetested with the following reproducer, given in &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-2523&quot; title=&quot;ll_update_inode()) ASSERTION( lu_fid_eq(&amp;amp;lli-&amp;gt;lli_fid, &amp;amp;body-&amp;gt;fid1) ) failed: Trying to change FID&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-2523&quot;&gt;&lt;del&gt;LU-2523&lt;/del&gt;&lt;/a&gt;:&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;llmount.sh
cd /mnt/lustre
touch file1

In a single process do:
  struct lov_user_md_v3 *lum;
  /* Initialize lum */
  fd2 = open(&quot;file2&quot;, O_RDWR|O_CREAT|O_LOV_DELAY_CREATE, 0666);
  rename(&quot;file1&quot;, &quot;file2&quot;);
  ioctl(fd2, LL_IOC_LOV_SETSTRIPE, lum);
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;With a stock 2.1.6 I can easily reproduce the issue. And unfortunately, with patch at &lt;a href=&quot;http://review.whamcloud.com/6775&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/6775&lt;/a&gt; I am still able to hit the bug.&lt;/p&gt;

&lt;p&gt;Thanks,&lt;br/&gt;
Sebastien.&lt;/p&gt;</description>
                <environment></environment>
        <key id="22385">LU-4363</key>
            <summary>(llite_lib.c:1683:ll_update_inode()) ASSERTION( lu_fid_eq(&amp;lli-&gt;lli_fid, &amp;body-&gt;fid1) ) failed</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://jira.whamcloud.com/images/icons/priorities/major.svg">Major</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="5">Cannot Reproduce</resolution>
                                        <assignee username="laisiyao">Lai Siyao</assignee>
                                    <reporter username="sebastien.buisson">Sebastien Buisson</reporter>
                        <labels>
                            <label>mn1</label>
                    </labels>
                <created>Mon, 9 Dec 2013 15:02:05 +0000</created>
                <updated>Wed, 13 Oct 2021 03:18:13 +0000</updated>
                            <resolved>Wed, 13 Oct 2021 03:18:13 +0000</resolved>
                                    <version>Lustre 2.1.6</version>
                                                        <due></due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                            <comments>
                            <comment id="73077" author="laisiyao" created="Mon, 9 Dec 2013 15:10:59 +0000"  >&lt;p&gt;&lt;a href=&quot;http://review.whamcloud.com/#/c/7476/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/#/c/7476/&lt;/a&gt; should be able to fix this, but this patch is for master code, and it has some dependency on patches not on 2.1.&lt;/p&gt;</comment>
                            <comment id="73087" author="pjones" created="Mon, 9 Dec 2013 16:04:47 +0000"  >&lt;p&gt;Lai&lt;/p&gt;

&lt;p&gt;Would this be easier to port to b2_4?&lt;/p&gt;

&lt;p&gt;Sebastien&lt;/p&gt;

&lt;p&gt;If the answer to the above is yes, would you consider deploying a 2.4.x release at IFERC?&lt;/p&gt;

&lt;p&gt;Peter&lt;/p&gt;</comment>
                            <comment id="73088" author="sebastien.buisson" created="Mon, 9 Dec 2013 16:19:30 +0000"  >&lt;p&gt;Peter,&lt;/p&gt;

&lt;p&gt;The problem is upgrade to 2.4 at IFERC is planned for Q4 2014 &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.whamcloud.com/images/icons/emoticons/sad.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                            <comment id="73190" author="pjones" created="Tue, 10 Dec 2013 13:13:48 +0000"  >&lt;p&gt;ok Sebastien. We are looking into options that would work for b2_1&lt;/p&gt;</comment>
                            <comment id="73192" author="laisiyao" created="Tue, 10 Dec 2013 13:53:55 +0000"  >&lt;p&gt;Yes, Sebastien, I&apos;m looking for a simpler way to handle this open-by-fid case only, and I&apos;m still testing, will commit the patch tomorrow.&lt;/p&gt;</comment>
                            <comment id="73199" author="laisiyao" created="Tue, 10 Dec 2013 15:53:01 +0000"  >&lt;p&gt;Hi Sebastien, I just committed a patch &lt;a href=&quot;http://review.whamcloud.com/#/c/8529/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/#/c/8529/&lt;/a&gt;, you can apply it plus &lt;a href=&quot;http://review.whamcloud.com/#/c/7476/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/#/c/7476/&lt;/a&gt; to make the test pass. However as is noted by John in &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-2523&quot; title=&quot;ll_update_inode()) ASSERTION( lu_fid_eq(&amp;amp;lli-&amp;gt;lli_fid, &amp;amp;body-&amp;gt;fid1) ) failed: Trying to change FID&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-2523&quot;&gt;&lt;del&gt;LU-2523&lt;/del&gt;&lt;/a&gt; that setstripe will return -ENOENT in your test, this is because MDS has strict check to forbid open again or create object on OST for unlinked file (even though it&apos;s currently opened). Do you think this is acceptable?&lt;/p&gt;</comment>
                            <comment id="73286" author="sebastien.buisson" created="Wed, 11 Dec 2013 15:48:33 +0000"  >&lt;p&gt;Hi,&lt;/p&gt;

&lt;p&gt;Patch &lt;a href=&quot;http://review.whamcloud.com/8529&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/8529&lt;/a&gt; can be applied on Lustre 2.1.6, but &lt;a href=&quot;http://review.whamcloud.com/7476&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/7476&lt;/a&gt; cannot because it is a master version (more than 20 hunks failed when trying on 2.1).&lt;br/&gt;
That being said, I do not clearly understand the relationship between the assertion we are suffering from, and the open-by-fid feature. I mean, all we need is something to prevent Lustre 2.1 to crash when users do something like the reproducer detailed in the description of this ticket.&lt;/p&gt;

&lt;p&gt;Sebastien.&lt;/p&gt;</comment>
                            <comment id="73333" author="laisiyao" created="Thu, 12 Dec 2013 02:12:48 +0000"  >&lt;p&gt;Sorry Sebastien, I posted the wrong patch, it should be &lt;a href=&quot;http://review.whamcloud.com/6775&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/6775&lt;/a&gt; + &lt;a href=&quot;http://review.whamcloud.com/#/c/8529/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/#/c/8529/&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;You hit that assertion is because MDS_OPEN_BY_FID flag is not in 2.1 code, so open tends to be done by name on MDS, therefore when rename happens, the new file with different fid will be opened, and it causes the assert on fid change on client.&lt;/p&gt;

&lt;p&gt;2.4 has this flag, and patch &lt;a href=&quot;http://review.whamcloud.com/#/c/8529/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/#/c/8529/&lt;/a&gt; backports this flag to 2.1, so the assert will not be hit any more.&lt;/p&gt;</comment>
                            <comment id="73344" author="sebastien.buisson" created="Thu, 12 Dec 2013 07:55:38 +0000"  >&lt;p&gt;Hi,&lt;/p&gt;

&lt;p&gt;Thank you very much for the explanations! Now with &lt;a href=&quot;http://review.whamcloud.com/6775&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/6775&lt;/a&gt; + &lt;a href=&quot;http://review.whamcloud.com/8529&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/8529&lt;/a&gt; I am not able to hit the assertion anymore &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.whamcloud.com/images/icons/emoticons/smile.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;br/&gt;
So we definitively need both fixes in b2_1.&lt;/p&gt;

&lt;p&gt;One more question: could you re-explain the drawback you identified with this solution (it was related to setstripe returning -ENOENT but I dd not get your point) ?&lt;/p&gt;

&lt;p&gt;Thanks,&lt;br/&gt;
Sebastien.&lt;/p&gt;</comment>
                            <comment id="73381" author="laisiyao" created="Thu, 12 Dec 2013 16:07:40 +0000"  >&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;ioctl(fd2, LL_IOC_LOV_SETSTRIPE, lum);
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;As you can see, setstripe is done via ioctl on an opened file handle, but in the code setstripe is implemented as an open (so it&apos;s actually a re-open), this looks should succeed, but current MDS code doesn&apos;t allow re-open or create OST object for unlinked file. However there is no posix standard for setstripe call, this can be regarded as normal, but it should be documented somewhere IMO.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10490" key="com.atlassian.jira.plugin.system.customfieldtypes:datepicker">
                        <customfieldname>End date</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Fri, 20 Dec 2013 15:02:05 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                            <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzwaxj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>11946</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10493" key="com.atlassian.jira.plugin.system.customfieldtypes:datepicker">
                        <customfieldname>Start date</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>Mon, 9 Dec 2013 15:02:05 +0000</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>