https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-45 Lustre <p>In order to complete the build of e2fsprogs, the liblustreapi library needs to be accessible. Currently this is only possible if a built lustre source tree is available on the system building e2fsprogs. It should be available via an installable lustre-devel package.</p> <p>It is also available in the rpm installed in /usr/lib<span class="error">&#91;64&#93;</span> but I'm not convinced that e2fsprogs' configure will actually find that.</p> LU-45

building e2fsprogs should not require lustre to be installed or a built source tree

Improvement Minor Resolved Fixed Bruce Cassidy Brian Murrell Wed, 19 Jan 2011 10:25:30 +0000 Thu, 24 Apr 2014 17:07:06 +0000 Thu, 24 Apr 2014 17:07:06 +0000 Lustre 2.0.0 0 0 <p>The e2fsprogs build <em>should</em> be able to get liblustreapi.h and liblustreapi.a from the installed lustre RPM, but it has been a long time since I checked whether this worked.</p> <p>I have not actually tried a build that way but I'm not convinced. Looking at the patch we can see the link command line is:</p> <p>$(LD) -pthread $(ALL_LDFLAGS) $(LUSTRE_INC) $(LFSCK_OBJS) -o lfsck $(LUSTRE_LIB) -llustreapi $(DEPLIBS)</p> <p>and $LUSTRE_INC and $LUSTRE_LIB are defined as:</p> <p>LUSTRE_INC=-I @LUSTRE@/lustre/include -Wall<br/> LUSTRE_LIB=-L @LUSTRE@/lustre/utils</p> <p>and LUSTRE is defined in configure as:</p> <ol> <li>Check whether --with-lustre was given.<br/> if test "${with_lustre+set}" = set; then :<br/> withval=$with_lustre; { $as_echo "$as_me:${as_lineno-$LINENO}: result: Lustre is in $withval" &gt;&amp;5<br/> $as_echo "Lustre is in $withval" &gt;&amp;6; }<br/> LUSTRE="$withval"<br/> else<br/> LUSTRE="/usr/src/lustre"<br/> fi</li> </ol> <p>So it's possible that a --with-lustre=/usr/include <b>might</b> work where the liblustreapi.a library is just found in the regular search path.</p> <p>it's ugly at best though. That macro to find LUSTRE could certainly do some more exhaustive checking for an installed lustre rpm. But even still, a build machine should not need the lustre RPM installed but should be able to work with a lustre-devel RPM that has the includes and libraries in it. The macro above would still need to be made better, to search for the locations that the lustre-devel RPM will drop the includes and libraries.</p> <p>In change 315 in Gerrit, I've attached a patchset for e2fsprogs-1.42 which, among many other things, can build against the installed Lustre RPM files. In order to do this, run:</p> <p> configure --with-lustre=/usr</p> <p>and it will find the include files under @LUSTRE@/include, and the libraries under @LUSTRE@/lib</p> {64} <p>. It is a bit clunky because it adds both "-L @LUSTRE@/lib64 -L @LUSTRE/lib" to LDFLAGS, but ld should do the right thing. If there was an easier way to know in the configure.in file which one was correct it could be fixed.</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/reviews-e2fsprogs/25/" class="external-link" target="_blank" rel="nofollow noopener">reviews-e2fsprogs #25</a><br/> <a href="https://jira.whamcloud.com/browse/LU-45" title="building e2fsprogs should not require lustre to be installed or a built source tree" class="issue-link" data-issue-key="LU-45"><del>LU-45</del></a> update e2fsprogs for pre-1.42 build</p> <p>Andreas Dilger : <br/> Files : </p> <ul> <li>patches/e2fsprogs-tests-f_extents_ee_len.patch</li> <li>patches/sles/e2fsprogs-SLES10--m-support.patch</li> <li>patches/series</li> <li>patches/e2fsprogs-tests-f_data_in_dirent.patch</li> <li>patches/e2fsprogs-tests-f_uninit_disable.patch</li> <li>patches/e2fsprogs-tests-f_extents_res_blk.patch</li> <li>patches/e2fsprogs-config-before-cmdline.patch</li> <li>patches/e2fsprogs-tests-f_ibadness_bad_extents.patch</li> <li>patches/e2fsprogs-tests-f_jchksum_blast_trans.patch</li> <li>patches/e2fsprogs-extended_ops.patch</li> <li>patches/e2fsprogs-version.patch</li> <li>patches/e2fsprogs-tests-f_large_ea.patch</li> <li>patches/e2fsprogs-extents.patch</li> <li>patches/libcom_err-unidiff.patch</li> <li>patches/e2fsprogs-add-io_channel_readahead.patch</li> <li>patches/e2fsprogs-dblist.patch</li> <li>patches/e2fsprogs-tests-f_jchksum_remount.patch</li> <li>patches/README</li> <li>patches/e2fsprogs-tests-f_extents_unsorted.patch</li> <li>patches/e2fsprogs-large-ea.patch</li> <li>patches/e2fsprogs-rpm_support.patch</li> <li>patches/sles/11/rpm/e2fsprogs-1.41.4.de.po</li> <li>patches/e2fsprogs-add-trusted-fid.patch</li> <li>patches/e2fsprogs-tests-f_extents_ei_block.patch</li> <li>patches/sles/11/system-blkid.patch</li> <li>patches/e2fsprogs-tests-f_ibadness.patch</li> <li>patches/e2fsprogs-tests-f_uninit_blk-uninit-set_inode-uninit-not-set.patch</li> <li>patches/sles/11/rpm/libcom_err-compile_et_permissions.patch</li> <li>patches/e2fsprogs-uninit-fixes.patch</li> <li>patches/e2fsprogs-misc.patch</li> <li>patches/e2fsprogs-tests-f_many_subdirs.patch</li> <li>patches/e2fsprogs-bad-ininode-ea.patch</li> <li>patches/e2fsprogs-tests-f_jchksum_bblk.patch</li> <li>patches/e2fsprogs-lustre_ismounted.patch</li> <li>patches/sles/11/rpm/README.SUSE</li> <li>patches/e2fsprogs-tests-f_extents_shrd_blk.patch</li> <li>patches/e2fsprogs-mmp.patch</li> <li>patches/e2fsprogs-tests-f_extents_eh_entries.patch</li> <li>patches/e2fsprogs-tests-f_uninit_enable.patch</li> <li>patches/e2fsprogs-expand-extra-isize.patch</li> <li>patches/e2fsprogs-attr_cleanup.patch</li> <li>patches/e2fsprogs-tests-f_extents_inrlevel-incons.patch</li> <li>patches/e2fsprogs-blkid-zfs.patch</li> <li>patches/e2fsprogs-tests-f_uninit_incorrect_free_inodes_count.patch</li> <li>patches/e2fsprogs-tests-f_random_corruption.patch</li> <li>patches/e2fsprogs-new-opt-shrdblks.patch</li> <li>patches/e2fsprogs-tests-f_uninit_checksum_invalid.patch</li> <li>patches/e2fsprogs-count_wrong_valid.patch</li> <li>patches/e2fsprogs-i_size-corruption.patch</li> <li>patches/e2fsprogs-osx.patch</li> <li>patches/e2fsprogs-tests-f_extents_ee_start.patch</li> <li>patches/e2fsprogs-tests-f_bad_ea_value.patch</li> <li>patches/e2fsprogs-size_high.patch</li> <li>patches/e2fsprogs-lazy_journal_init.patch</li> <li>patches/e2fsprogs-ibadness-counter.patch</li> <li>patches/ChangeLog</li> <li>patches/e2fsprogs-tests-f_extents_eh_depth.patch</li> <li>patches/e2fsprogs-data_in_dirent.patch</li> <li>patches/e2fsprogs-tests-f_extents_ei_leaf.patch</li> <li>patches/e2fsprogs-tests-f_extents_split.patch</li> <li>patches/e2fsprogs-e2scan.patch</li> <li>patches/sles/libcom_err-no-static-buffer.patch</li> <li>patches/e2fsprogs-skip-extent-tests.patch</li> <li>patches/e2fsprogs-tests-f_mmp.patch</li> <li>patches/e2fsprogs-tunefs-dirty.patch</li> <li>patches/e2fsprogs-tests-f_uninit_restart_fsck.patch</li> <li>patches/e2fsprogs-e2fsck_exclusive.patch</li> <li>patches/e2fsprogs-tests-f_extents_eh_magic.patch</li> <li>patches/e2fsprogs-tests-f_extents_overlap.patch</li> <li>patches/e2fsprogs-tests-f_expisize.patch</li> <li>patches/e2fsprogs-fiemap-lustre.patch</li> <li>patches/e2fsprogs-tests-s_basic_scan.patch</li> <li>patches/sles/libcom_err-no-init_error_table.patch</li> <li>patches/e2fsprogs-tests-f_uninit_blks-used_blk-uninit-not-set.patch</li> <li>patches/e2fsprogs-lfsck.patch</li> <li>patches/e2fsprogs-tests-f_extents_eh_max.patch</li> <li>patches/e2fsprogs-bigjournal.patch</li> <li>patches/e2fsprogs-specdotin.patch</li> <li>patches/e2fsprogs-tests-f_uninit_ino-ref_beyond_bg-itable-unused.patch</li> <li>patches/e2fsprogs-tests-f_extents_imbalanced_tree.patch</li> <li>patches/e2fsprogs-tests-f_extents_bad_blk.patch</li> <li>patches/sles/11/rpm/e2fsprogs-1.41.1-splash_support.patch</li> <li>patches/e2fsprogs-tests-f_expisize_ea_del.patch</li> <li>patches/e2fsprogs-tests-f_extents_ee_block.patch</li> <li>patches/e2fsprogs-tests-f_extents_orphan_blks.patch</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/reviews-e2fsprogs/26/" class="external-link" target="_blank" rel="nofollow noopener">reviews-e2fsprogs #26</a><br/> <a href="https://jira.whamcloud.com/browse/LU-45" title="building e2fsprogs should not require lustre to be installed or a built source tree" class="issue-link" data-issue-key="LU-45"><del>LU-45</del></a> update e2fsprogs for pre-1.42 build</p> <p>Andreas Dilger : <br/> Files : </p> <ul> <li>patches/e2fsprogs-tests-f_ibadness_bad_extents.patch</li> <li>patches/e2fsprogs-tests-f_uninit_checksum_invalid.patch</li> <li>patches/e2fsprogs-bad-ininode-ea.patch</li> <li>patches/sles/libcom_err-no-static-buffer.patch</li> <li>patches/e2fsprogs-tests-f_extents_eh_magic.patch</li> <li>patches/e2fsprogs-tests-f_extents_orphan_blks.patch</li> <li>patches/e2fsprogs-tests-f_extents_res_blk.patch</li> <li>patches/e2fsprogs-osx.patch</li> <li>patches/e2fsprogs-tests-f_extents_unsorted.patch</li> <li>patches/e2fsprogs-tests-f_extents_ee_len.patch</li> <li>patches/e2fsprogs-tests-f_uninit_restart_fsck.patch</li> <li>patches/e2fsprogs-tests-f_extents_eh_entries.patch</li> <li>patches/e2fsprogs-ibadness-counter.patch</li> <li>patches/e2fsprogs-version.patch</li> <li>patches/e2fsprogs-config-before-cmdline.patch</li> <li>patches/e2fsprogs-tests-f_extents_ei_block.patch</li> <li>patches/e2fsprogs-tests-f_extents_split.patch</li> <li>patches/e2fsprogs-fiemap-lustre.patch</li> <li>patches/e2fsprogs-lfsck.patch</li> <li>patches/e2fsprogs-extents.patch</li> <li>patches/e2fsprogs-blkid-zfs.patch</li> <li>patches/series</li> <li>patches/e2fsprogs-expand-extra-isize.patch</li> <li>patches/e2fsprogs-tests-f_jchksum_bblk.patch</li> <li>patches/e2fsprogs-tests-f_extents_ee_start.patch</li> <li>patches/e2fsprogs-tests-f_uninit_ino-ref_beyond_bg-itable-unused.patch</li> <li>patches/e2fsprogs-tests-f_large_ea.patch</li> <li>patches/e2fsprogs-tests-f_extents_inrlevel-incons.patch</li> <li>patches/e2fsprogs-tests-f_expisize_ea_del.patch</li> <li>patches/README</li> <li>patches/e2fsprogs-tests-f_extents_imbalanced_tree.patch</li> <li>patches/sles/11/system-blkid.patch</li> <li>patches/sles/11/rpm/e2fsprogs-1.41.1-splash_support.patch</li> <li>patches/e2fsprogs-e2scan.patch</li> <li>patches/e2fsprogs-count_wrong_valid.patch</li> <li>patches/e2fsprogs-tests-f_jchksum_remount.patch</li> <li>patches/e2fsprogs-large-ea.patch</li> <li>patches/e2fsprogs-bigjournal.patch</li> <li>patches/e2fsprogs-tests-f_extents_eh_max.patch</li> <li>patches/e2fsprogs-uninit-fixes.patch</li> <li>patches/e2fsprogs-tests-f_uninit_blk-uninit-set_inode-uninit-not-set.patch</li> <li>patches/e2fsprogs-size_high.patch</li> <li>patches/e2fsprogs-e2fsck_exclusive.patch</li> <li>patches/e2fsprogs-rpm_support.patch</li> <li>patches/e2fsprogs-tests-f_mmp.patch</li> <li>patches/e2fsprogs-tests-f_extents_overlap.patch</li> <li>patches/sles/11/rpm/e2fsprogs-1.41.4.de.po</li> <li>patches/e2fsprogs-tests-f_ibadness.patch</li> <li>patches/e2fsprogs-tests-f_uninit_incorrect_free_inodes_count.patch</li> <li>patches/e2fsprogs-tests-f_expisize.patch</li> <li>patches/e2fsprogs-tests-f_extents_ee_block.patch</li> <li>patches/e2fsprogs-lazy_journal_init.patch</li> <li>patches/e2fsprogs-extended_ops.patch</li> <li>patches/e2fsprogs-tests-f_uninit_disable.patch</li> <li>patches/e2fsprogs-tests-f_random_corruption.patch</li> <li>patches/e2fsprogs-tests-f_uninit_blks-used_blk-uninit-not-set.patch</li> <li>patches/e2fsprogs-tests-f_extents_bad_blk.patch</li> <li>patches/e2fsprogs-tunefs-dirty.patch</li> <li>patches/e2fsprogs-add-io_channel_readahead.patch</li> <li>patches/e2fsprogs-attr_cleanup.patch</li> <li>patches/e2fsprogs-mmp.patch</li> <li>patches/e2fsprogs-skip-extent-tests.patch</li> <li>patches/e2fsprogs-tests-f_jchksum_blast_trans.patch</li> <li>patches/sles/e2fsprogs-SLES10--m-support.patch</li> <li>patches/e2fsprogs-i_size-corruption.patch</li> <li>patches/e2fsprogs-tests-f_uninit_enable.patch</li> <li>patches/e2fsprogs-new-opt-shrdblks.patch</li> <li>patches/e2fsprogs-tests-f_extents_eh_depth.patch</li> <li>patches/sles/libcom_err-no-init_error_table.patch</li> <li>patches/libcom_err-unidiff.patch</li> <li>patches/e2fsprogs-data_in_dirent.patch</li> <li>patches/e2fsprogs-dblist.patch</li> <li>patches/e2fsprogs-tests-f_extents_shrd_blk.patch</li> <li>patches/ChangeLog</li> <li>patches/e2fsprogs-tests-f_extents_ei_leaf.patch</li> <li>patches/e2fsprogs-specdotin.patch</li> <li>patches/e2fsprogs-tests-f_bad_ea_value.patch</li> <li>patches/sles/11/rpm/README.SUSE</li> <li>patches/e2fsprogs-add-trusted-fid.patch</li> <li>patches/e2fsprogs-misc.patch</li> <li>patches/e2fsprogs-tests-f_data_in_dirent.patch</li> <li>patches/sles/11/rpm/libcom_err-compile_et_permissions.patch</li> <li>patches/e2fsprogs-tests-s_basic_scan.patch</li> <li>patches/e2fsprogs-lustre_ismounted.patch</li> <li>patches/e2fsprogs-tests-f_many_subdirs.patch</li> </ul> <p>This is addressed by the e2fsprogs-1.42/master-lustre patchset that is in Gerrit right now.</p> <p>Bruce should close it when that is committed.</p> <p>Test: Set up a cleanToro machine. yum install:<br/> autoconf<br/> make<br/> db4&#42;<br/> gcc<br/> get lustre-client rpm from lustre build-200 and rpm -i.<br/> get lustre-client-modules from lustre build-200 and rpm -i.<br/> get e2fsprogs-1.41.90.wc1 source code from gerrit.<br/> Insource directory:<br/> autoconf<br/> ./configure --with-lustre=/usr<br/> make<br/> make check</p> <p>Output:<br/> 149 tests succeeded 0 tests failed</p> <p>Test: Set up a cleanToro machine. yum install:<br/> autoconf<br/> make<br/> db4&#42;<br/> gcc<br/> get lustre-client rpm from lustre build-200 and rpm -i.<br/> get lustre-client-modules from lustre build-200 and rpm -i.<br/> get e2fsprogs-1.41.90.wc1 source code from gerrit.<br/> Insource directory:<br/> autoconf<br/> ./configure --with-lustre=/usr<br/> make<br/> make check</p> <p>Output:<br/> 149 tests succeeded 0 tests failed</p> <p>Test: Set up a cleanToro machine. yum install:<br/> autoconf<br/> make<br/> db4&#42;<br/> gcc<br/> get lustre-client rpm from lustre build-200 and rpm -i.<br/> get lustre-client-modules from lustre build-200 and rpm -i.<br/> get e2fsprogs-1.41.90.wc1 source code from gerrit.<br/> Insource directory:<br/> autoconf<br/> ./configure --with-lustre=/usr<br/> make<br/> make check</p> <p>Output:<br/> 149 tests succeeded 0 tests failed</p> <p>Andreas checked in code to fix this issue. That code is included in e2fsprogs-1.41.90.wc1. I tested the code for building in a machine that just had lustre client code installed via rpm. The build succeeded.</p> Development Rank 1|hzw1vr: Rank (Obsolete) 10386 Severity