https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4746 Lustre <p>Lustre 2.5.0 (and before) do not use the kernel's default current_umask() function, instead accessing the current process pointer directly with current-&gt;fs-&gt;umask. On a standard kernel this is equivalent, however on a GRSecurity-enabled kernel there's additional logic in the kernel's current_umask() function that's being skipped.</p> LU-4746

Lustre not using kernel current_umask() function breaks GRSecurity umask handling

Bug Minor Resolved Fixed Bob Glossman Andrew Prout patch Mon, 10 Mar 2014 18:02:16 +0000 Wed, 18 Feb 2015 20:21:38 +0000 Wed, 18 Feb 2015 20:21:38 +0000 Lustre 2.1.5 Lustre 1.8.9 Lustre 2.5.0 Lustre 2.4.2 Lustre 2.7.0 0 6 <p>Patches to fix attached. All affected versions compile normally when calling the Linux kernel's current_umask() function.</p> <p>Andrew,<br/> thanks for the patches. Like the kernel, we need a Signed-off-by: line in the patch in order to accept it. Please see <a href="https://wiki.hpdd.intel.com/display/PUB/Using+Gerrit" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.hpdd.intel.com/display/PUB/Using+Gerrit</a> for details on how best to submit patches for Lustre.</p> <p>Try #2 on the patches...</p> <p>Can you submit the patches to Gerrit for our review process?</p> <p>I will push these into Gerritt</p> <p>Patches pushed, in the autotest process</p> <p><a href="http://review.whamcloud.com/#/c/10320/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10320/</a><br/> <a href="http://review.whamcloud.com/#/c/10321/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10321/</a><br/> <a href="http://review.whamcloud.com/#/c/10322/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10322/</a><br/> <a href="http://review.whamcloud.com/#/c/10323/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10323/</a></p> <p>I take it this issue is also present in current master version (upcoming 2.6)?<br/> Can we get a patch for master branch too? Thanks.<br/> (2.5 and 2.4 versions are not supposed to be landed without a corresponding master version as tehy are technically supposed to be backports).</p> <p>Seems I never got around to cleaning that up in <a href="https://jira.whamcloud.com/browse/LU-3963" title="cleanup libcfs wrappers" class="issue-link" data-issue-key="LU-3963"><del>LU-3963</del></a>. Also we need more fixes in a few other places as well in all the branches. Also is their a wrapper to change the umask value?</p> <p>Created the patch for master at</p> <p><a href="http://review.whamcloud.com/#/c/11642" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11642</a></p> <p>Need to do it anyways for <a href="https://jira.whamcloud.com/browse/LU-3963" title="cleanup libcfs wrappers" class="issue-link" data-issue-key="LU-3963"><del>LU-3963</del></a>. Once landed we can back port to the branches of interest. Even with this patch we should look to cleanup sec_ctx.c. I really don't think we need to keep push_ctx and pop_ctx around anymore.</p> <p>Patch landed for master. Patches for b2_5 and b2_4 still outstanding.</p> <p>Patch landed to Master. Other version patch landings will be tracked external to this ticket.</p> Development Rank 1|hzwh9j: Rank (Obsolete) 13041 Severity