https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4820 Lustre <p>osd_read_prep() in osd-zfs/ calls into dmu_read() which finds the buffers filled osd_bufs_get_read(). this is not needed and cost us extra memcpy() on all the reads.</p> ZFS LU-4820

extra memcpy in read path

Bug Minor Closed Fixed Alex Zhuravlev Alex Zhuravlev llnl Wed, 26 Mar 2014 06:55:11 +0000 Tue, 18 Aug 2015 14:21:20 +0000 Wed, 10 Jun 2015 00:16:08 +0000 Lustre 2.4.1 Lustre 2.5.0 Lustre 2.6.0 Lustre 2.4.2 Lustre 2.5.1 Lustre 2.5.2 Lustre 2.4.3 Lustre 2.8.0 0 7 <p><a href="http://review.whamcloud.com/#/c/9760/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/9760/</a></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/9760/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/9760/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-4820" title="extra memcpy in read path" class="issue-link" data-issue-key="LU-4820"><del>LU-4820</del></a> osd: drop memcpy in zfs osd<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1249edcd71e6a44f92aba1482201b30696e85d0d</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12990" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12990</a><br/> Subject: Revert "<a href="https://jira.whamcloud.com/browse/LU-4820" title="extra memcpy in read path" class="issue-link" data-issue-key="LU-4820"><del>LU-4820</del></a> osd: drop memcpy in zfs osd"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c3ca670b48027b831c5f06d418181b97ca1e90f4</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12990/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12990/</a><br/> Subject: Revert "<a href="https://jira.whamcloud.com/browse/LU-4820" title="extra memcpy in read path" class="issue-link" data-issue-key="LU-4820"><del>LU-4820</del></a> osd: drop memcpy in zfs osd"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 29288dda431cad667b3666c50c37e484fb832f67</p> <p>Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12991" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12991</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-4820" title="extra memcpy in read path" class="issue-link" data-issue-key="LU-4820"><del>LU-4820</del></a> osd: drop memcpy in zfs osd<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b0651a9a3b18c6036f9a1abd92487371331fbe26</p> <p><a href="http://review.whamcloud.com/12991" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12991</a></p> <p>Alex,</p> <p>Can you see how much work it would be to write a patch for this against b2_5? For one of our systems, we want to got with the latest 2.5 release, but I'd like to have this patch included.</p> <p>Thanks,<br/> Rick</p> <p>Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13907" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13907</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-4820" title="extra memcpy in read path" class="issue-link" data-issue-key="LU-4820"><del>LU-4820</del></a> osd: drop memcpy in zfs osd<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a65b20245b874cb20dd0b154e466547d15542730</p> <p>RIck, please have a look: <a href="http://review.whamcloud.com/13907" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13907</a></p> <p>Thanks, Alex. Unfortunately, it looks as though there may be a dependency on other changes. The <a href="https://build.hpdd.intel.com/job/lustre-reviews/30665/arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/console" class="external-link" target="_blank" rel="nofollow noopener">build</a> failed looking for something in the <tt>niobuf_local</tt> structure.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>In function 'osd_read_prep': /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/server/distro/el6/ib_stack/inkernel/BUILD/BUILD/lustre-2.5.3/lustre/osd-zfs/osd_io.c:759: error: 'struct niobuf_local' has no member named 'lnb_rc' </pre> </div></div> <p>Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13929" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13929</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-4820" title="extra memcpy in read path" class="issue-link" data-issue-key="LU-4820"><del>LU-4820</del></a> osd: drop memcpy in zfs osd<br/> Project: fs/lustre-release<br/> Branch: b2_5<br/> Current Patch Set: 1<br/> Commit: 7651c21a917f672e031a6d4611e563f530e4ec96</p> <p>my bad, sorry folks. please check another version.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12991/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12991/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-4820" title="extra memcpy in read path" class="issue-link" data-issue-key="LU-4820"><del>LU-4820</del></a> osd: drop memcpy in zfs osd<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b59942cce0ed3b720ec38c3b5a25063d01b8d218</p> <p>landed to master</p> <p>any objections to close the ticket?</p> Related LU-5278 Development Rank 1|hzwifj: Rank (Obsolete) 13259 Severity