https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4871 Lustre <p>There are 70 odd CERROR/CWARN/CDEBUG... messages with missing newlines. The attached file was generated a few weeks ago.</p> LU-4871

missing newlines at end of error messages

Bug Minor Resolved Fixed James Nunez John Hammond messages Tue, 8 Apr 2014 20:27:40 +0000 Tue, 11 Nov 2014 23:00:26 +0000 Tue, 11 Nov 2014 23:00:26 +0000 Lustre 2.6.0 Lustre 2.6.0 Lustre 2.7.0 0 5 <p>James</p> <p>Could you please take care of this one?</p> <p>Thanks</p> <p>Peter</p> <p>I also noticed two messages with double newlines:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>ll_layout_refresh osc_lock_init -- 00000008:00010000:3.0:1397487994.678070:0:5401:0:(osc_lock.c:1753:osc_lock_init()) ### lock ffff8801e4af0ed0, osc lock ffff8801e457bcc0, flags 41000 -- 00000080:00010000:3.0:1397487994.678467:0:5401:0:(file.c:3975:ll_layout_refresh()) ### lustre: requeue layout lock for file [0x280000400:0x12b:0x0](ffff8802002c4b78) </pre> </div></div> <p>The double newlines are a results of LDLM_DEBUG_NOLOCK being defined as:<br/> #define LDLM_DEBUG_NOLOCK(format, a...) \<br/> CDEBUG(D_DLMTRACE, "### " format "\n" , ##a)</p> <p>So, anyone using LDLM_DEBUG_NOLOCK should not use a newline character at the end of the message. At least two uses of LDLM_DEBUG_NOLOCK used the newline, producing the double newlines printed and there are several examples of calling LDLM_DEBUG_NOLOCK without the newline character. </p> <p>We have other examples of defining new routines based on CDEBUG, CL_LOCK_DEBUG for example, and we don’t add a newline character in the definition of those routines. I think we should be consistent and leave out the "\n" in the definition of LDLM_DEBUG_NOLOCK. </p> <p>Proposed patch at <a href="http://review.whamcloud.com/#/c/10000/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10000/</a></p> <p>John, </p> <p>Patch <a href="http://review.whamcloud.com/#/c/10000/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10000/</a> landed. Should we close this ticket or do you want to generate a new list to see if there are new cases of missing newlines in the latest master?</p> <p>James</p> <p>Patch landed to master</p> <p>With latest master, 2.6.53, I am getting buried in these messages:</p> <p>iwc12 kernel: format at osc_cache.c:1473:osc_enter_cache_try doesn't end in newline</p> <p>Me too.</p> <p>That message should be cleaned up with the <a href="https://jira.whamcloud.com/browse/LU-5551" title="format at ldlm_pool.c:625:ldlm_pool_recalc doesn&#39;t end in newline" class="issue-link" data-issue-key="LU-5551"><del>LU-5551</del></a> patch at <a href="http://review.whamcloud.com/#/c/11996/3" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11996/3</a> </p> <p>Resolving ticket since patch for <a href="https://jira.whamcloud.com/browse/LU-5551" title="format at ldlm_pool.c:625:ldlm_pool_recalc doesn&#39;t end in newline" class="issue-link" data-issue-key="LU-5551"><del>LU-5551</del></a>, <a href="http://review.whamcloud.com/#/c/11996/3" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11996/3</a> , landed to master (pre-2.7)</p> Related LU-5551 Development Rank 1|hzwjkv: Rank (Obsolete) 13464 Severity