https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4961 Lustre <p>Mostly this means reshuffling headers. There are a few uses of ext2_test_bit(). The worst offender is obd.c which passes a lov_stripe_md from userspace to kernelspace. This can be handled by adding a new ioctl (OBD_IOC_CREATE3) which accepts a struct lov_user/mds_md_v3.</p> LU-4961

utils and test should not depend on obd.h or liblustre.h

Bug Minor Closed Fixed WC Triage John Hammond RoDC Fri, 25 Apr 2014 20:31:15 +0000 Mon, 31 Jan 2022 04:28:20 +0000 Fri, 9 May 2014 02:45:58 +0000 Lustre 2.6.0 0 3 <p>It would also be nice make lustre_idl.h usable when building outside the tree or move the ioctl interface to more userspace friendly headers. </p> <p>I already have a patch to remove LASSERT() and LPx64 from lustre_user.h - <a href="http://review.whamcloud.com/6156" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6156</a> but it probably needs a refresh. Something similar should be done for lustre_idl.h also. </p> <p>As for the passing of lov_stripe_md from userspace - could you please point out the particulars to me? This of course seems totally wrong, and it may be that it is obsolete and we can just get rid of it entirely instead of making a new ioctl.</p> <p>&gt; I already have a patch to remove LASSERT() and LPx64 from lustre_user.h - <a href="http://review.whamcloud.com/6156" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6156</a> but it probably needs a refresh. Something similar should be done for lustre_idl.h also.</p> <p>Indeed. And as Robert noted the ioctls should be consolidated into lustre_user.h, lustre_idl.h, or a new shared file.</p> <p>&gt; As for the passing of lov_stripe_md from userspace - could you please point out the particulars to me? This of course seems totally wrong, and it may be that it is obsolete and we can just get rid of it entirely instead of making a new ioctl.</p> <p>See lustre/utils/obd.c:jt_obd_create() which uses OBD_IOC_CREATE and passes a lov_stripe_md() to the echo client module. When I asked about this a while ago I sort of understood that it was still in use but no one knew the details.</p> <p>See <a href="http://review.whamcloud.com/10114" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10114</a> for a preliminary cut.</p> <p><a href="http://review.whamcloud.com/10139" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10139</a> moves ioctls to lustre_ioctl.h and disincludes obd.h from utils and test.</p> <p><a href="http://review.whamcloud.com/#/c/10194/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10194/</a> <a href="https://jira.whamcloud.com/browse/LU-4961" title="utils and test should not depend on obd.h or liblustre.h" class="issue-link" data-issue-key="LU-4961"><del>LU-4961</del></a> lustre: remove liblustre.h and obd.h from userspace</p> <p>Patch landed to master.</p> Related LU-1606 LU-4983 Development Rank 1|hzwl1j: Rank (Obsolete) 13724 Severity