https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4987 Lustre <p>The patch from <a href="https://jira.whamcloud.com/browse/LU-4107" title="luser_user.h is not C++ compatible" class="issue-link" data-issue-key="LU-4107"><del>LU-4107</del></a>, change <a href="http://review.whamcloud.com/8033" class="external-link" target="_blank" rel="nofollow noopener">8033</a>, introduced two bugs:</p> <p>1) Duplicate stdio.h include<br/> 2) Changing user-space api based only on one's compiler.</p> <p>I don't even understand why folks thought LUSTRE_ANONYMOUS_UNION_NAME was the right thing to do. The commenting is entirely inadequate here ("Fix anonymous union."), so I am not even sure what problem they were trying to fix. As far as I can tell, C++ has anonymous unions as well.</p> <p>But regardless of the underlying problem, this does not seem like the solution we want. This makes the user-space API change based only one's choice of compiler. I don't think that is wise.</p> LU-4987

Issues introduced by LU-4107

Bug Critical Resolved Fixed Minh Diep Christopher Morrone Wed, 30 Apr 2014 18:58:32 +0000 Thu, 15 May 2014 13:48:18 +0000 Thu, 15 May 2014 13:48:18 +0000 Lustre 2.6.0 0 5 <p>It looks like the duplicate stdio.h happened when the patch was rebased for patch set 5. <br/> I also don't understand that define, and no one commented on it, either. </p> <p>Minh</p> <p>Could you please comment?</p> <p>Thanks</p> <p>Peter</p> <p>I think I figured it out. Here are patches for both:</p> <p><a href="http://review.whamcloud.com/10175" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10175</a><br/> <a href="http://review.whamcloud.com/10176" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10176</a></p> <p>Maloo reported failures on both patches. I am pretty doubtful that the failures were due to the patches. Please relaunch the tests (or let me know when to do a rebase when the problem is fixed).</p> <p>Someone restarted testing on <a href="http://review.whamcloud.com/10175" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10175</a> and that is now clear. <a href="http://review.whamcloud.com/10176" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10176</a> still needs testing relaunched.</p> <p>Patches have landed to Master. Please reopen ticket if more work is needed.</p> Development Rank 1|hzwlj3: Rank (Obsolete) 13812 Severity