https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4993 Lustre <p>tracker for 3.14 kernel support</p> <p>fc20 recently bumped their kernel version from 3.13.x to 3.14.x<br/> new build failures are now showing up</p> fc20<br/> LU-4993

support for 3.14 linux kernel

Improvement Minor Resolved Fixed Bob Glossman Bob Glossman patch Fri, 2 May 2014 15:39:12 +0000 Mon, 8 Sep 2014 20:37:32 +0000 Mon, 8 Sep 2014 20:37:32 +0000 Lustre 2.7.0 0 5 <p>can't even build client-only for 3.14. first set of build problems looks to be due to refactoring of struct bio</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> CC [M] /home/bogl/lustre-release/lustre/llite/lloop.o /home/bogl/lustre-release/lustre/llite/lloop.c: In function ‘do_bio_lustrebacked’: /home/bogl/lustre-release/lustre/llite/lloop.c:221:45: error: ‘struct bio’ has no member named ‘bi_sector’ offset = (pgoff_t)(bio-&gt;bi_sector &lt;&lt; 9) + lo-&gt;lo_offset; ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:24: error: incompatible types when assigning to type ‘int’ from type ‘struct bvec_iter’ bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:47: error: request for member ‘bi_size’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:138: error: request for member ‘bi_idx’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:188: error: request for member ‘bi_size’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:216: error: request for member ‘bi_size’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:272: error: request for member ‘bi_idx’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:301: error: request for member ‘bi_bvec_done’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:363: error: request for member ‘bi_idx’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:392: error: request for member ‘bi_bvec_done’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:522: error: request for member ‘bi_idx’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:554: error: request for member ‘bi_bvec_done’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:573: error: left-hand operand of comma expression has no effect [-Werror=unused-value] bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:615: error: request for member ‘bv_len’ in something not a structure or union bio_for_each_segment(bvec, bio, i) { ^ /home/bogl/lustre-release/lustre/llite/lloop.c:222:77: error: passing argument 2 of ‘bio_advance_iter’ from incompatible pointer type [-Werror] bio_for_each_segment(bvec, bio, i) { ^ In file included from include/linux/blkdev.h:18:0, from /home/bogl/lustre-release/lustre/llite/lloop.c:91: include/linux/bio.h:225:60: note: expected ‘struct bvec_iter *’ but argument is of type ‘int *’ static inline void bio_advance_iter(struct bio *bio, struct bvec_iter *iter, ^ /home/bogl/lustre-release/lustre/llite/lloop.c: In function ‘loop_get_bio’: /home/bogl/lustre-release/lustre/llite/lloop.c:313:206: error: ‘struct bio’ has no member named ‘bi_sector’ CDEBUG(D_INFO, "bio sector %llu size %u count %u vcnt%u \n", ^ /home/bogl/lustre-release/lustre/llite/lloop.c:313:225: error: ‘struct bio’ has no member named ‘bi_size’ CDEBUG(D_INFO, "bio sector %llu size %u count %u vcnt%u \n", ^ /home/bogl/lustre-release/lustre/llite/lloop.c: In function ‘loop_make_request’: /home/bogl/lustre-release/lustre/llite/lloop.c:348:189: error: ‘struct bio’ has no member named ‘bi_sector’ CDEBUG(D_INFO, "submit bio sector %llu size %u\n", ^ /home/bogl/lustre-release/lustre/llite/lloop.c:348:209: error: ‘struct bio’ has no member named ‘bi_size’ CDEBUG(D_INFO, "submit bio sector %llu size %u\n", ^ cc1: all warnings being treated as errors make[6]: *** [/home/bogl/lustre-release/lustre/llite/lloop.o] Error 1 make[5]: *** [/home/bogl/lustre-release/lustre/llite] Error 2 make[4]: *** [/home/bogl/lustre-release/lustre] Error 2 make[3]: *** [_module_/home/bogl/lustre-release] Error 2 make[3]: Leaving directory `/usr/src/kernels/3.14.2-200.fc20.x86_64' make[2]: *** [modules] Error 2 make[2]: Leaving directory `/home/bogl/lustre-release' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/bogl/lustre-release' make: *** [all] Error 2 </pre> </div></div> <p>Believe it or not I have patches for this already. I ran into this on my home debian system.Well I have to make the patch work with earlier kernels.</p> <p>Oh I believe it <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p><a href="http://review.whamcloud.com/#/c/10332" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10332</a><br/> <a href="http://review.whamcloud.com/#/c/10337" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10337</a></p> <p>Sorry I couldn't make 10337 more pretty but it works.</p> <p>James, Why is <a href="http://review.whamcloud.com/#/c/10332" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10332</a> needed? I seem to be able to build clients that work without it.</p> <p>I have a UMP machine running a 3.15 kernel at home. It gives me the ability to find issues that otherwise would go undetected with SMP devices.</p> <p><a href="http://review.whamcloud.com/#/c/10337" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10337</a> has landed in master, but I think it's only good enough for clients. Strongly suspect there is more server only code that also needs adjustment for the HAVE_BVEC_ITER case. If I try a server build in a 3.14 kernel I see lots of build errors that I think are related:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> CC [M] /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.o /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c: In function ‘dio_complete_routine’: /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:166:304: error: ‘struct bio’ has no member named ‘bi_idx’ CERROR("bi_next: %p, bi_flags: %lx, bi_rw: %lu, bi_vcnt: %d, " ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:166:317: error: ‘struct bio’ has no member named ‘bi_size’ CERROR("bi_next: %p, bi_flags: %lx, bi_rw: %lu, bi_vcnt: %d, " ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:24: error: incompatible types when assigning to type ‘int’ from type ‘struct bvec_iter’ bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:47: error: request for member ‘bi_size’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:137: error: request for member ‘bi_idx’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:187: error: request for member ‘bi_size’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:215: error: request for member ‘bi_size’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:271: error: request for member ‘bi_idx’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:300: error: request for member ‘bi_bvec_done’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:362: error: request for member ‘bi_idx’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:391: error: request for member ‘bi_bvec_done’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:521: error: request for member ‘bi_idx’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:553: error: request for member ‘bi_bvec_done’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:572: error: left-hand operand of comma expression has no effect [-Werror=unused-value] bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:613: error: request for member ‘bv_len’ in something not a structure or union bio_for_each_segment(bvl, bio, i) { ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:177:76: error: passing argument 2 of ‘bio_advance_iter’ from incompatible pointer type [-Werror] bio_for_each_segment(bvl, bio, i) { ^ In file included from include/linux/blkdev.h:18:0, from /home/bogl/lustre-release/lustre/include/linux/obd_support.h:63, from /home/bogl/lustre-release/lustre/include/obd_support.h:44, from /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:56: include/linux/bio.h:225:60: note: expected ‘struct bvec_iter *’ but argument is of type ‘int *’ static inline void bio_advance_iter(struct bio *bio, struct bvec_iter *iter, ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c: In function ‘can_be_merged’: /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:252:19: error: ‘struct bio’ has no member named ‘bi_size’ size = bio-&gt;bi_size &gt;&gt; 9; ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:253:19: error: ‘struct bio’ has no member named ‘bi_sector’ return bio-&gt;bi_sector + size == sector ? 1 : 0; ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c: In function ‘osd_do_bio’: /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:324:222: error: ‘struct bio’ has no member named ‘bi_size’ CDEBUG(D_INODE, "bio++ sz %d vcnt %d(%d) " ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:324:268: error: ‘struct bio’ has no member named ‘bi_size’ CDEBUG(D_INODE, "bio++ sz %d vcnt %d(%d) " ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:333:59: error: ‘struct bio’ has no member named ‘bi_size’ record_start_io(iobuf, bio-&gt;bi_size); ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:350:28: error: ‘struct bio’ has no member named ‘bi_sector’ bio-&gt;bi_sector = sector; ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:362:43: error: ‘struct bio’ has no member named ‘bi_size’ record_start_io(iobuf, bio-&gt;bi_size); ^ /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c: In function ‘can_be_merged’: /home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.c:254:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1: all warnings being treated as errors make[6]: *** [/home/bogl/lustre-release/lustre/osd-ldiskfs/osd_io.o] Error 1 make[5]: *** [/home/bogl/lustre-release/lustre/osd-ldiskfs] Error 2 make[4]: *** [/home/bogl/lustre-release/lustre] Error 2 make[3]: *** [_module_/home/bogl/lustre-release] Error 2 make[3]: Leaving directory `/home/bogl/rb/BUILD/kernel-3.14.6.200.l0613' make[2]: *** [modules] Error 2 make[2]: Leaving directory `/home/bogl/lustre-release' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/bogl/lustre-release' make: *** [all] Error 2 </pre> </div></div> <p><a href="http://review.whamcloud.com/#/c/10332" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10332</a><br/> <a href="http://review.whamcloud.com/#/c/10995" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10995</a></p> <p>with the new patch <a href="http://review.whamcloud.com/#/c/10995" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10995</a> it's once again possible to do full server builds for 3.14, including ldiskfs. It still requires a bunch of patches in flight and at least one for an ldiskfs patch series for 3.14 that hasn't even been pushed to gerrit yet. I have a working prototype for that on hand, but not exposed publicly yet.</p> <p>Perhaps it is time to open a ticket for 3.16 support.</p> <p>ldiskfs for 3.14: <a href="http://review.whamcloud.com/11000" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11000</a></p> <p>Is this the latest fc20 kernel?</p> <p>yes; 3.14.9-200</p> <p>We may very well need a ticket for 3.15 soon. I just saw that fc20 jumped versions overnight from 3.14.x to 3.15.x. Have yet to discover if we need anything extra for 3.15 beyond what we already have in flight for 3.14.</p> <p>vfs_rename changed again and sk_data_ready api changed. I have patches already for those versions. This is when running against a 3.16 kernel.</p> <p>James, is 3.16 present in any distro yet like Fedora Core or are you working against strictly upstream kernel.org trees?</p> <p>I'm working with upstream kernel in this case.</p> <p>James, It appears the sk_data_ready api change you mentioned is already present in 3.15 too. I'll go ahead and open a tracking ticket for 3.16 so we can start collecting mods needed for kernels &gt; 3.14 there.</p> <p>I updated <a href="http://review.whamcloud.com/#/c/10995" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10995</a>. Please inspect.</p> <p>re: <a href="http://review.whamcloud.com/#/c/10995" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10995</a>. don't want to +review it until I can build the HAVE_BVEC_ITER case again. Can't do that right now as the only kernel I can build with is the 3.15 kernel in fc20, and that fails due to <a href="https://jira.whamcloud.com/browse/LU-5322" title="support for 3.16 linux kernel" class="issue-link" data-issue-key="LU-5322"><del>LU-5322</del></a> issues. No patches for those yet.</p> <p>Last patch at <a href="http://review.whamcloud.com/#/c/10995" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10995</a>.</p> <p>Last patch as landed. We can close this ticket.</p> <p>Landed for 2.7</p> <p>don't think thai's correct. <a href="http://review.whamcloud.com/#/c/10995" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10995</a> still hasn't landed.</p> <p>Yeah I thought this patch landed instead of the patch from <a href="https://jira.whamcloud.com/browse/LU-5322" title="support for 3.16 linux kernel" class="issue-link" data-issue-key="LU-5322"><del>LU-5322</del></a>. Funny that all the non ldiskfs patches for <a href="https://jira.whamcloud.com/browse/LU-5322" title="support for 3.16 linux kernel" class="issue-link" data-issue-key="LU-5322"><del>LU-5322</del></a> landed first.</p> <p>This time patch <a href="http://review.whamcloud.com/#/c/10995" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10995</a> really has landed to master. This ticket can be closed.</p> <p>Landed for 2.7</p> Related LU-4416 LU-5014 LU-5276 LU-5322 Development Rank 1|hzwlnj: Rank (Obsolete) 13834