https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-4997 Lustre <p><a href="https://jira.whamcloud.com/browse/LU-2743" title="Errno Translation" class="issue-link" data-issue-key="LU-2743"><del>LU-2743</del></a> introduced a regression into lustre_idl.h. One reason that it no longer compiles in <em>installed</em> user space because of this addition:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>#include &lt;lustre/lustre_errno.h&gt; </pre> </div></div> <p>But lustre_errno. is not packaged.</p> <p>There are two questions that need answering:</p> <ul> <li>Should lustre_idl.h really include lustre_errno.h?</li> <li>Should lustre_errno.h really be a new interface exposed to user space?</li> </ul> <p>If the answers to both are "yes", we can consider packaging lustre_errno.h.</p> <p>Of course, we also need to decide if we will continue packaging luste_idl.h (see parent issue <a href="https://jira.whamcloud.com/browse/LU-1606" title="lustre_idl.h does not compile in user-space" class="issue-link" data-issue-key="LU-1606"><del>LU-1606</del></a>). If we stop packaging it, then this ticket is moot.</p> LU-4997

lustre_idl.h compilation regression from LU-2743

Bug Critical Closed Fixed Li Wei Christopher Morrone Sat, 3 May 2014 00:31:58 +0000 Thu, 3 Jul 2014 22:48:33 +0000 Thu, 3 Jul 2014 16:26:14 +0000 Lustre 2.5.1 Lustre 2.6.0 0 6 <p>Please see <a href="http://review.whamcloud.com/10209" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10209</a>.</p> <p>Assigning to Li Wei as the original author of this code but perhaps this can be closed as a duplicate of the ticket John H is working</p> <p>My thoughts were (and still are):</p> <ul> <li>The contents of lustre_errno.h are part of the wire protocol. If there were not so many error codes, I would have defined them directly in lustre_idl.h.</li> <li>The contents of lustre_errno.h should not be needed by user space code, as the client kernel drivers should have translated the wire error codes back to host error codes.</li> <li>The rule seems to be that only lustre_user.h should be available to user space code.</li> </ul> <p>By "user space code", I don't intend to include any user space implementations of Lustre client, of course.</p> <p>&gt; The rule seems to be that only lustre_user.h should be available to user space code.</p> <p>That rule has not been followed.</p> <p>Nothing in lustre_idl.h uses any definitions from lustre_errno.h. What's the matter with "include waht you use." Why should lustre_idl.h include something it doesn't need?</p> <p>As to the rule, are current violations too hard to fix?</p> <p>Yes, I agree in principle a header should not include another one that it doesn't depend on. However, the case here is a bit different: The error definitions should be defined <em>in</em> lustre_idl.h if there were not so many of them. Also, they are actually conceptually used by pb_status and hpk_errval in lustre_idl.h.</p> <p>Li Wei,<br/> in a related note, are the errno values that Lustre is using on the network checked in wirecheck.c?</p> <p>Andreas, no, I did not add such checks. Could you explain a bit about your thought behind the question?</p> <p>lustre_idl.h is no longer packaged for use outside of the Lustre tree.</p> <p>That's cool! Thanks, John.</p> Blocker LU-5011 Development Rank 1|hzwlq7: Rank (Obsolete) 13846 Severity