https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5018 Lustre <p>Looks e2fsprogs failed to build for a long time:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> CC unix.c In file included from /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/lustre/include/lustre/lustre_user.h:51, from /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/lustre/include/lustre/lustreapi.h:46, from ../lib/ext2fs/lfsck.h:10, from unix.c:60: /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/libcfs/include/libcfs/posix/posix-types.h:60: error: redefinition of typedef <span class="code-quote">'__s8'</span> ../lib/ext2fs/ext2_types.h:26: note: previous declaration of <span class="code-quote">'__s8'</span> was here /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/libcfs/include/libcfs/posix/posix-types.h:63: error: redefinition of typedef <span class="code-quote">'__u8'</span> ../lib/ext2fs/ext2_types.h:20: note: previous declaration of <span class="code-quote">'__u8'</span> was here /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/libcfs/include/libcfs/posix/posix-types.h:67: error: redefinition of typedef <span class="code-quote">'__s16'</span> ../lib/ext2fs/ext2_types.h:46: note: previous declaration of <span class="code-quote">'__s16'</span> was here /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/libcfs/include/libcfs/posix/posix-types.h:70: error: redefinition of typedef <span class="code-quote">'__u16'</span> ../lib/ext2fs/ext2_types.h:32: note: previous declaration of <span class="code-quote">'__u16'</span> was here /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/libcfs/include/libcfs/posix/posix-types.h:74: error: redefinition of typedef <span class="code-quote">'__s32'</span> ../lib/ext2fs/ext2_types.h:79: note: previous declaration of <span class="code-quote">'__s32'</span> was here /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/libcfs/include/libcfs/posix/posix-types.h:77: error: redefinition of typedef <span class="code-quote">'__u32'</span> ../lib/ext2fs/ext2_types.h:61: note: previous declaration of <span class="code-quote">'__u32'</span> was here /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/libcfs/include/libcfs/posix/posix-types.h:93: error: redefinition of typedef <span class="code-quote">'__s64'</span> ../lib/ext2fs/ext2_types.h:113: note: previous declaration of <span class="code-quote">'__s64'</span> was here /<span class="code-keyword">var</span>/lib/jenkins/workspace/e2fsprogs-master/arch/x86_64/distro/el6/../usr/src/lustre-2.5.57/libcfs/include/libcfs/posix/posix-types.h:96: error: redefinition of typedef <span class="code-quote">'__u64'</span> ../lib/ext2fs/ext2_types.h:97: note: previous declaration of <span class="code-quote">'__u64'</span> was here CC e2fsck.c make[3]: *** [unix.o] Error 1 </pre> </div></div> <p>Seems those macros defined in lustre posix-types.h are conflicting with ext2_types.h</p> <p>e2fsprogs include lustre posix-types.h in following path:<br/> unix.c -&gt; lfsck.h -&gt; lustreapi.h -&gt; lustre_user.h -&gt; posix-types.h</p> LU-5018

e2fsprogs build failed

Bug Critical Resolved Fixed Andreas Dilger Niu Yawei Wed, 7 May 2014 02:20:00 +0000 Tue, 4 Nov 2014 04:03:07 +0000 Fri, 23 May 2014 19:03:48 +0000 Lustre 2.6.0 Lustre 2.6.0 Lustre 2.5.4 0 5 <p>Probably we need to check if e2fsprogs header already been included? Something like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">#ifndef __U8_TYPEDEF <span class="code-comment">/* already defined in e2fsprogs header */</span> #ifndef HAVE___S8 typedef __signed__ <span class="code-object">char</span> __s8; #endif #ifndef HAVE___U8 typedef unsigned ... #endif </pre> </div></div> <p>Niu, can you post the exact version of the lustre source being used here? I see that it says 2.5.57 above, but IIRC if I checkout 2.5.58-79-ge345778, make rpms, and install the source then it goes in /usr/src/lustre-2.5.58/.</p> <p>The last successful build of e2fsprogs was on the same day that 001b8dbfacb747f1649a2eb047a5f118ce32fdc7 landed.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># git log -p libcfs/include/libcfs/posix/posix-types.h commit 001b8dbfacb747f1649a2eb047a5f118ce32fdc7 Author: Alexey Lyashkov &lt;alexey_lyashkov@xyratex.com&gt; Date: Mon Sep 30 13:38:10 2013 +0300 LU-3963 cleanup: C89 and build cleanups use C99 initialization for a types, remove some platform depended code and use POSIX compatible instead. don't build a lhsmtool is none utils allowed. Signed-off-by: Alexey Lyashkov &lt;alexey_lyashkov@xyratex.com&gt; Change-Id: I6e2837953902520240e9ceb251c92329d328d715 Reviewed-on: http://review.whamcloud.com/7803 Tested-by: Jenkins Tested-by: Maloo &lt;hpdd-maloo@intel.com&gt; Reviewed-by: Bob Glossman &lt;bob.glossman@intel.com&gt; Reviewed-by: Oleg Drokin &lt;oleg.drokin@intel.com&gt; diff --git a/libcfs/include/libcfs/posix/posix-types.h b/libcfs/include/libcfs/posix/posix-types.h index 446db6e..510b178 100644 --- a/libcfs/include/libcfs/posix/posix-types.h +++ b/libcfs/include/libcfs/posix/posix-types.h @@ -42,7 +42,9 @@ #ifndef _LUSTRE_POSIX_TYPES_H #define _LUSTRE_POSIX_TYPES_H -#include &lt;asm/types.h&gt; +#ifdef HAVE_LINUX_TYPES_H +# include &lt;linux/types.h&gt; +#endif #include &lt;stdbool.h&gt; /* for bool */ #ifndef HAVE_UMODE_T typedef unsigned short umode_t; </pre> </div></div> <p>posix-types.h is an packaged header. Its contents must not depend on config.h.</p> <p>Returning the unconditional <tt>&lt;asm/types.h&gt;</tt> header instead of the conditional <tt>&lt;linux/types.h&gt;</tt> fixes the problem. However, I can't see what in the include chain in <tt>&lt;asm/types.h&gt; -&gt; &lt;asm-generic/types.h&gt; -&gt; &lt;asm-generic/int-ll64.h&gt;</tt> is actually fixing the problem. The <tt>&lt;libcfs/posix/posix-types.h&gt;</tt> header defines the fixed-width types as:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">#ifndef HAVE___S8 typedef __signed__ <span class="code-object">char</span> __s8; #endif #ifndef HAVE___U8 typedef unsigned <span class="code-object">char</span> __u8; #endif </pre> </div></div> <p>while in &lt;asm/types.h&gt; (at least on my system, in both <tt>/usr/include/asm/types.h</tt> and <tt>linux/include/asm/types.h</tt>) it defines the types without any checking:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">#ifndef __ASSEMBLY__ /* * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the * header files exported to user space */ typedef __signed__ <span class="code-object">char</span> __s8; typedef unsigned <span class="code-object">char</span> __u8; </pre> </div></div> <p>There was some attempt to avoid such conflicts in <tt>lib/ext2fs/ext2_types.h</tt> using:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">#<span class="code-keyword">if</span> (!defined(_LINUX_TYPES_H) &amp;&amp; !defined(_BLKID_TYPES_H) &amp;&amp; \ !defined(_EXT2_TYPES_H)) #define __S8_TYPEDEF __signed__ <span class="code-object">char</span> #define __U8_TYPEDEF unsigned <span class="code-object">char</span> #define __S16_TYPEDEF __signed__ <span class="code-object">short</span> #define __U16_TYPEDEF unsigned <span class="code-object">short</span> #define __S32_TYPEDEF __signed__ <span class="code-object">int</span> #define __U32_TYPEDEF unsigned <span class="code-object">int</span> #define __S64_TYPEDEF __signed__ <span class="code-object">long</span> <span class="code-object">long</span> #define __U64_TYPEDEF unsigned <span class="code-object">long</span> <span class="code-object">long</span> #ifdef __U8_TYPEDEF typedef __U8_TYPEDEF __u8; #<span class="code-keyword">else</span> typedef unsigned <span class="code-object">char</span> __u8; #endif #ifdef __S8_TYPEDEF typedef __S8_TYPEDEF __s8; #<span class="code-keyword">else</span> typedef signed <span class="code-object">char</span> __s8; #endif </pre> </div></div> <p>but this fails due to _LINUX_TYPES_H not being #defined. However, I don't see how that is avoided when <tt>&lt;asm/types.h&gt;</tt> is included. Sadly, the types are defined exactly the same way and it would be nice if GCC didn't complain in that case.</p> <p>The patch <a href="http://review.whamcloud.com/10258" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10258</a> should resolve the breakage of the e2fsprogs build induced by <a href="http://review.whamcloud.com/7803" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/7803</a> changing the include of &lt;asm/types.h&gt; to a conditional include of &lt;linux/types.h&gt; that depended on the HAVE_LINUX_TYPES_H configure macro that was not normally defined for userspace headers.</p> <p>This would also be addressed by <a href="http://review.whamcloud.com/10273" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10273</a>.</p> <p><a href="http://review.whamcloud.com/10319" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10319</a> should fix the problem on the e2fsprogs side while the Lustre patch is waiting to land</p> <p>Patches landed to Master. Please reopen ticket if more work is needed.</p> <p>Patch for b2_5: <a href="http://review.whamcloud.com/11840" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11840</a></p> Blocker LU-4504 Related LU-3963 LU-5501 Development Rank 1|hzwlz3: Rank (Obsolete) 13889 Severity