https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5051 Lustre <p>Currently, the 1 MB buffer used by llapi_hsm_copytool_recv is allocated and freed every time through the ct_run loop. </p> <p>This is unnecessary, as long as the copy tool clears the the data before calling llapi_hsm_copytool_recv, which lhsmtool_posix already does.</p> <p>This patch allocates the buffer once in llapi_hsm_copytool_register and frees it in unregister.</p> <p>Patch will be available in Gerrit shortly.</p> LU-5051

HSM recv buffer reallocated unnecessarily

Improvement Minor Resolved Fixed Cliff White Patrick Farrell hsm patch Mon, 12 May 2014 19:54:12 +0000 Wed, 8 Oct 2014 18:27:24 +0000 Fri, 30 May 2014 13:29:16 +0000 Lustre 2.5.0 Lustre 2.6.0 Lustre 2.6.0 Lustre 2.5.4 0 7 <p>Would it make sense fir llapi_hsm_copytool_recv() to reinitialize the buffer memset(0) each time rather than relying on the application to do this?</p> <p>Good point, I can update the patch to do that. Before I do that, would you weigh in on my comment in the patch:<br/> <span class="error">&#91;...&#93;</span> In llapi_hsm_copytool_recv, now that we no longer free the buffer at the end of this function, should we rename "out_free" to "out_err"?</p> <p>I'm probably going to make that change unless anyone disagrees.</p> <p>The existing code is not memset'ing the buffer (using malloc, not calloc), and it belongs to the application, so there's no leak involved. Since it's also a very large buffer, I don't think we should add that.</p> <p>Yes, please change the label, in case you are still wondering about that. </p> <p>As for the memset issue - Patrick mentioned that the copytool is currently clearing the data but I didn't see it doing that. Since this buffer was being managed by the API then it made sense to me to clear it there, but I agree it might not be required, either. </p> <p>I opened <a href="https://jira.whamcloud.com/browse/LU-5059" title="Test failure on test suite sanity" class="issue-link" data-issue-key="LU-5059"><del>LU-5059</del></a> via Maloo for the test failures. (On all of the test runs, all of the sub tests passed, but the overall suite still reported failure...)</p> <p>Patch is here:<br/> <a href="http://review.whamcloud.com/#/c/10299/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10299/</a></p> <p>Needs refresh, doing that shortly...</p> <p>I will monitor this one, thanks for the patch.</p> <p>Landed for 2.6</p> <p>Patch for b2_5 at <a href="http://review.whamcloud.com/#/c/10716" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10716</a> </p> Development Rank 1|hzwmcv: Rank (Obsolete) 13954