<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 01:49:15 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-5184] sanity-lfsck test 18d: file size never checked</title>
                <link>https://jira.whamcloud.com/browse/LU-5184</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;After creating a dangling reference, sanity-lfsck test 18d checks a file&apos;s size to make sure that there is an inconsistency. From test_18d:&lt;/p&gt;

&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;	echo &quot;The file size should be incorrect since dangling referenced&quot;
	local cur_size=$(ls -il $DIR/$tdir/a1/f2 | awk &apos;{ print $6 }&apos;)
	[ &quot;$cur_size&quot; != &quot;$saved_size&quot; ] ||
		error &quot;(1) Expect incorrect file2 size&quot;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;but, when there is a dangling reference, ls does not return the file size. From the output of test_18d:&lt;/p&gt;

&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;The file size should be incorrect since dangling referenced
ls: cannot access /lustre/scratch/d18d.sanity-lfsck/a1/f2: Cannot allocate memory
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Thus, the file size is never checked and this code does not do what is intended. This check needs to be rethought; it should probably be taken out or a different failure other than dangling reference needs to be injected here.&lt;/p&gt;</description>
                <environment></environment>
        <key id="25127">LU-5184</key>
            <summary>sanity-lfsck test 18d: file size never checked</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="4" iconUrl="https://jira.whamcloud.com/images/icons/priorities/minor.svg">Minor</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="6">Not a Bug</resolution>
                                        <assignee username="wc-triage">WC Triage</assignee>
                                    <reporter username="jamesanunez">James Nunez</reporter>
                        <labels>
                            <label>lfsck</label>
                    </labels>
                <created>Thu, 12 Jun 2014 16:16:26 +0000</created>
                <updated>Thu, 9 Jan 2020 07:33:03 +0000</updated>
                            <resolved>Thu, 9 Jan 2020 07:33:03 +0000</resolved>
                                    <version>Lustre 2.6.0</version>
                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                            <comments>
                            <comment id="86440" author="green" created="Thu, 12 Jun 2014 17:39:52 +0000"  >&lt;p&gt;my question is how come a dangling reference results in incorrect file size anyway?&lt;/p&gt;

&lt;p&gt;The cannot allocate memory is a different ticket that we have a patch for that&apos;ll land soon&lt;/p&gt;</comment>
                            <comment id="86454" author="jamesanunez" created="Thu, 12 Jun 2014 18:39:44 +0000"  >&lt;p&gt;I think you are referring to patch &lt;a href=&quot;http://review.whamcloud.com/#/c/9004&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/#/c/9004&lt;/a&gt; . This issue was seen on ldiskfs and zfs, but may be a duplicate of ticket &lt;a href=&quot;https://jira.hpdd.intel.com/browse/LU-4970&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://jira.hpdd.intel.com/browse/LU-4970&lt;/a&gt; . &lt;/p&gt;

&lt;p&gt;Also, the dangling reference does not create an incorrect file size on its own. The test creates two files of different size and then injects a failure so both files reference the same object. From a comment in the test:&lt;/p&gt;

&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;Inject failure to make $DIR/$tdir/a1/f1 and $DIR/$tdir/a1/f2
to reference the same OST-object (which is f1&apos;s OST-obejct).&quot;
Then drop $DIR/$tdir/a1/f1 and its OST-object, so f2 becomes&quot;
dangling reference case, but f2&apos;s old OST-object is there.
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="86505" author="yong.fan" created="Fri, 13 Jun 2014 00:04:54 +0000"  >&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;The file size should be incorrect since dangling referenced
ls: cannot access /lustre/scratch/d18d.sanity-lfsck/a1/f2: Cannot allocate memory
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;It is the expected result. We want to check whether the injecting dangling reference failure works or not. If not, the new size will be equal to the old one.&lt;br/&gt;
To avoid confusing, we can change the test scripts as:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;        echo &lt;span class=&quot;code-quote&quot;&gt;&quot;&lt;span class=&quot;code-quote&quot;&gt;&apos;stat&apos;&lt;/span&gt; should fail because of  dangling referenced&quot;&lt;/span&gt;
        stat $DIR/$tdir/a1/f2 &amp;amp;&amp;amp;  error &lt;span class=&quot;code-quote&quot;&gt;&quot;(1) &lt;span class=&quot;code-quote&quot;&gt;&apos;stat&apos;&lt;/span&gt; file2 should fail&quot;&lt;/span&gt;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Related</name>
                                            <outwardlinks description="is related to ">
                                        <issuelink>
            <issuekey id="24435">LU-4970</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzwob3:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>14385</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>