[LU-5187] Make "precreate FID" console message more intelligible

Mon, 2 Nov 2015 13:24:01 +0000

Brian Behlendorf points out in the comments on patch 10394 that the following console warning message is not particularly intelligible as it stands.

From lustre/ofd/ofd_dev.c:

                /* This can happen if a new OST is formatted and installed
                 * in place of an old one at the same index.  Instead of
                 * precreating potentially millions of deleted old objects
                 * (possibly filling the OST), only precreate the last batch.
                 * LFSCK will eventually clean up any orphans. LU-14 */
                if (diff > 5 * OST_MAX_PRECREATE) {
                        diff = OST_MAX_PRECREATE / 2;
                        LCONSOLE_WARN("%s: precreate FID "DOSTID" is over %u "
                                      "larger than the LAST_ID "DOSTID", only "
                                      "precreating the last %u objects.\n",
                                      ofd_name(ofd), POSTID(&oa->o_oi),
                                      5 * OST_MAX_PRECREATE,
                                      POSTID(&oseq->os_oi), diff);
                        ofd_seq_last_oid_set(oseq, ostid_id(&oa->o_oi) - diff);
                }

Brian said:

I still don't think the console message itself is at all useful. Either Lustre should silently handle this case (if it can) and we can silence the message. Or the console message should be updated to include clear explanation of what's wrong and what an administrator needs to do. As it stands, I feel it's just noise when is only useful to a developer.

I agree that this message needs improvment.

Whamcloud Community JIRA

[LU-5187] Make "precreate FID" console message more intelligible