https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5262 Lustre <p>The mdd_acl_set() sets size unexpectedly on the master object and cause the master object's directory content is truncated.</p> <p>This corruption can be easily reproduced by the sanity test_125, unfortunately, there is no way to read the master object directory content directly until we work on the patch for <a href="https://jira.whamcloud.com/browse/LU-5223" title="generate DNE stripe directory LMV EA dynamically via readdir" class="issue-link" data-issue-key="LU-5223"><del>LU-5223</del></a>.</p> LU-5262

setfacl on striped directory will cause the striped directory crash

Bug Critical Resolved Fixed nasf nasf HB Fri, 27 Jun 2014 10:21:11 +0000 Wed, 2 Jul 2014 00:01:03 +0000 Wed, 2 Jul 2014 00:01:03 +0000 Lustre 2.6.0 0 5 <p>Isn't the fix here to clear LA_SIZE (and most others except LA_MODE) from attr-&gt;la_valid bits in mdd_xattr_set() before mdo_attr_set() is called so that these values are not all changed? Otherwise, there is a chance that this will set stale values into the inode if it is changed concurrently (e.g. pdirops). It isn't clear why <a href="https://jira.whamcloud.com/browse/LU-5223" title="generate DNE stripe directory LMV EA dynamically via readdir" class="issue-link" data-issue-key="LU-5223"><del>LU-5223</del></a> is needed to fix this?</p> <p>Here is the patch:<br/> <a href="http://review.whamcloud.com/10870" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10870</a></p> <p>It is an important patch, should be landed to Lustre-2.6</p> <p>The basic idea of the patch is that: "NOT set size on directory".</p> <p>The <a href="https://jira.whamcloud.com/browse/LU-5223" title="generate DNE stripe directory LMV EA dynamically via readdir" class="issue-link" data-issue-key="LU-5223"><del>LU-5223</del></a> depends on this patch, because if without the patch, the master object may be truncated unexpectedly when setfacl, then the iteration the master object to build LMV EA will get failure because the master directory (for shards FID and name) will be regarded empty although it is not empty.</p> <p>Sanity test_125 test such case, that is why <a href="https://jira.whamcloud.com/browse/LU-5223" title="generate DNE stripe directory LMV EA dynamically via readdir" class="issue-link" data-issue-key="LU-5223"><del>LU-5223</del></a> failed at sanity.</p> <p>probably it makes sense to check in OSD for LA_SIZE in case of non-regular file.</p> <p>Then all OSDs need to check LA_SIZE. Why not control that in MDD/LOD, then no need to worry about new OSD in future.</p> <p>MDD/LOD/OFD should not try to do this of course. I'm saying about something more like LASSERT() in OSD.</p> <p>Ah it seems the problem is that in lod_attr_get, it tries to merge the size from all sub-stripes, then in lod_attr_set it set the merged size to master object. <br/> probably we can just simply drop the merging in lod_attr_get, which is actually unnecessary, see <a href="http://review.whamcloud.com/#/c/10841/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10841/</a> And this will also fix <a href="https://jira.whamcloud.com/browse/LU-5130" title="Test failure sanity test_17n: destroy remote dir error 0" class="issue-link" data-issue-key="LU-5130"><del>LU-5130</del></a></p> <p>The patch has been landed to master</p> Development Rank 1|hzwq2n: Rank (Obsolete) 14688 Severity