[LU-5268] HSM: importing with copytool can lead to data corruption

Related — Mon, 31 Jan 2022 04:14:16 +0000

This is a hypothetical bug.

When importing a file with the posix copytool, a hardlink is done at the end to link from the archvie of the file being restored to the new archive file (hash of the new fid). When restoring a complete filesystem, it is very possible that the new fid being allocated already existed on the old filesystem (and thus in the HSM archive). In which case the new archive filename will already exist. At that point the hard link operation in import_one() will fail, which leaves the imported file pointing to the archive of another file, and restoring that file will lead to data corruption.

Solution: link the new archive to a new directory; ie have --hsm-root and --hsm-root-import options. Then, optionally, let the user merge back both directories once the import is done.

Whamcloud Community JIRA

[LU-5268] HSM: importing with copytool can lead to data corruption