https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5275 Lustre <p>This is to address the last comment made in <a href="https://jira.whamcloud.com/browse/LU-3319" title="Adapt to 3.10 upstream kernel proc_dir_entry change" class="issue-link" data-issue-key="LU-3319"><del>LU-3319</del></a> to cleanup the technical debt.</p> LU-5275

clean up technical debt for proc_dir_entry changes

Bug Minor Resolved Fixed John Hammond Jodi Levi patch Tue, 1 Jul 2014 01:07:54 +0000 Thu, 19 Feb 2015 19:06:56 +0000 Thu, 19 Feb 2015 19:06:56 +0000 Lustre 2.7.0 Lustre 2.7.0 0 6 <p>Can you link this to <a href="https://jira.whamcloud.com/browse/LU-4416" title="support for 3.12 linux kernel" class="issue-link" data-issue-key="LU-4416"><del>LU-4416</del></a>.</p> <p>First of the patches</p> <p><a href="http://review.whamcloud.com/#/c/11451" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11451</a><br/> <a href="http://review.whamcloud.com/#/c/11640" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11640</a></p> <p>Patches landed to Master. Please reopen ticket if more is expected for this ticket.</p> <p>Sorry about the confusion but more patches are coming. Please reopen this ticket.</p> <p>Do you have a rough idea how many James?</p> <p>I say two, maybe three more patches.</p> <p>New cleanup patch at</p> <p><a href="http://review.whamcloud.com/#/c/12298" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/12298</a></p> <p>One patch left after this to cleanup lock handling that needs to be worked on. </p> <p>James,<br/> Are you planning to submit the patch for cleaning up lock handling for the 2.7 release?</p> <p>Yes I plan to update the second patch. The problem is the first patch is ready to land but it is based a earlier master revision. That current master has changed enough that I have to rebase the second patch I have after the first patch lands to master.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12298/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12298/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: remove last of non seq data structs and functions.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0ad4f8a4227ed7dd93fec99d33c6bb25056473fc</p> <p>Update patch <a href="http://review.whamcloud.com/#/c/12235" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/12235</a>. This should be the last patch in the series.</p> <p>Johann Lombardi (johann.lombardi@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12953" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12953</a><br/> Subject: Revert "<a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: remove last of non seq data structs and functions."<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 80e25c90a3d45ee0ec55b0a83282168b0583303a</p> <p>Johann Lombardi (johann.lombardi@intel.com) merged in patch <a href="http://review.whamcloud.com/12953/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12953/</a><br/> Subject: Revert "<a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: remove last of non seq data structs and functions."<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b1e595c09e1b07a6840142b3ae015b8a5a8affeb</p> <p>For the record, i have reverted <a href="http://review.whamcloud.com/#/c/12298" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/12298</a> since it broken the el6.6 build.</p> <p>Patch landed to master.</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13225" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13225</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: reduce scope of params_tree.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d4921339526c9076bf7a72660c86dac883b9eed4</p> <p>I have done exhaustive testing and looked very closely at the what states lustre procfs handling is in for the case of client and server being on the same node. I loaded lod then lov and vice versa as well as unload the modules in the two possible orders. I detected no leaks in either case. In order to fill out out proc trees we have to preform mounting/unmounting of the MDT and the client. I tried both orders of mounting and<br/> umount and saw no issues with remove_proc_subtree. Tired various combos of mounting/unmounting and module loading/unloading. No memory leaks/disappearing directories or handling symlinks occurred. Please note this is all done on a 3.12 kernel. Also looking at detail of the procfs initialization and removal don't show a issue with remove_proc_subtree. </p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13299" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13299</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: replace LPROCFS with CONFIG_PROC_FS<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1cd9b42ae4bfa063ddeb1d9c153b86afb1373264</p> <p>James Simmons (uja.ornl@gmail.com) uploaded a new patch: <a href="http://review.whamcloud.com/13330" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13330</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: sync names to upstream kernel lustre client<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a0ab151983e0655f95f7c5b53b09054b5159578a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13225/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13225/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: reduce scope of params_tree.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f9920b4924edce1bd341622eee4281fdcd41845a</p> <p>James Simmons (uja.ornl@gmail.com) uploaded a new patch: <a href="http://review.whamcloud.com/13341" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13341</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> libcfs: merge params_tree.h into lprocfs_status.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b22696a65873fdb69caf2a652f3bfe266bfcb489</p> <p>Finally finished off the patch set thanks to John Hammond. The patches to finish this are:</p> <p><a href="http://review.whamcloud.com/#/c/13299" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/13299</a><br/> <a href="http://review.whamcloud.com/#/c/13341" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/13341</a><br/> <a href="http://review.whamcloud.com/#/c/12235" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/12235</a><br/> <a href="http://review.whamcloud.com/#/c/13330" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/13330</a></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13299/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13299/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: replace LPROCFS with CONFIG_PROC_FS<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7817e4c785d075aae76b635dcf799064590833b0</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13341/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13341/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> libcfs: merge params_tree.h into lprocfs_status.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 17d614c7017c41d3484b163c8d86d324335c93e0</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12235/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12235/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: remove all non-seq file functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b66962c0f92b29353ac255400783e9b0faa9c2e3</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13330/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13330/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: sync names to upstream kernel lustre client<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: a172863af11bcef474191ca40eaa479179457c08</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13463" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13463</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> build: add LPROCFS to the deprecated symbol list<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f0b41cec79d7b8f86387afb94820e8e507c2b21b</p> <p>James Simmons (uja.ornl@gmail.com) uploaded a new patch: <a href="http://review.whamcloud.com/13527" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13527</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> gnilnd: Add definition for PDE_DATA<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d39d74651f6d0ee0a0f849ac558e243f03c52715</p> <p>Only two patches left <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13463/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13463/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> build: add LPROCFS to the deprecated symbol list<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5639b66882d6e53e97ad2f799f8aba1efecce9e9</p> <p>Only one small one line patch to merge to finish this off. Ready for merger.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13527/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13527/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> gnilnd: Add definition for PDE_DATA<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1ede0cfcbaf021da493fcd4352f9d092e176a292</p> <p>Patches landed to Master</p> Related LU-5983 LU-4416 LU-3319 Development Rank 1|hzwqa7: Rank (Obsolete) 14723 Severity