https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5297 Lustre <p>osp_sync_process_queues() now assumes all records to be processed are not corrupted, it's lack of error handling code for invalid records.</p> <p>One solution could be regarding the invalid record as committed and skipping processing on it.</p> LU-5297

osp_sync_thread can't handle invalid record gracefully

Bug Critical Resolved Fixed Emoly Liu Niu Yawei Fri, 4 Jul 2014 08:05:50 +0000 Tue, 22 Sep 2015 17:13:44 +0000 Sat, 19 Sep 2015 05:42:17 +0000 Lustre 2.6.0 Lustre 2.8.0 0 6 <p>Is this related to <a href="https://jira.whamcloud.com/browse/LU-5188" title="nbp6-OST002f-osc-MDT0000: invalid setattr record, lsr_valid:0" class="issue-link" data-issue-key="LU-5188"><del>LU-5188 "osp: return 1 if osp_sync_xxx_job issue RPC"</del></a>? What is the severity of this problem (i.e. what impact does it have on normal operation)? Will it cause OST objects to be leaked if they are unlinked when the OST is offline, and still offline when the MDS processes the llog records?</p> <blockquote> <p>Is this related to <a href="https://jira.whamcloud.com/browse/LU-5188" title="nbp6-OST002f-osc-MDT0000: invalid setattr record, lsr_valid:0" class="issue-link" data-issue-key="LU-5188"><del>LU-5188</del></a> "osp: return 1 if osp_sync_xxx_job issue RPC"? What is the severity of this problem (i.e. what impact does it have on normal operation)? Will it cause OST objects to be leaked if they are unlinked when the OST is offline, and still offline when the MDS processes the llog records?</p></blockquote> <p>That patch was trying to handle error for osp thread, but looks it's not complete. I think the severity isn't high, because there isn't any corrupted record in normal usage.</p> <p>Niu, could you explain in what part the patch is not complete? what specific cases it doesn't handle?</p> <blockquote> <p>Niu, could you explain in what part the patch is not complete? what specific cases it doesn't handle?</p></blockquote> <p>That patch decreases opd_syn_rpc_in_flight &amp; opd_syn_rpc_in_progress when skipping a invalid record, that's not enough, because opd_syn_changes isn't decreased and the sync thread will break unexpectedly, and invalid record isn't deleted at the end, I'm afraid it can cause further trouble.</p> <p>Niu, were you planning to make a patch for this, or should this bug be moved to 2.7.0?</p> <p>I don't have plan to make patch yet, probably we'd move it to 2.7.</p> <p>Emoly Liu (emoly.liu@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/14925" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14925</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5297" title="osp_sync_thread can&#39;t handle invalid record gracefully" class="issue-link" data-issue-key="LU-5297"><del>LU-5297</del></a> osp: decrease opd_syn_changes for an invalid record<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 25ceff8e1de80f98e701f1ed5630a9b9308c2ddf</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/14925/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14925/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5297" title="osp_sync_thread can&#39;t handle invalid record gracefully" class="issue-link" data-issue-key="LU-5297"><del>LU-5297</del></a> osp: process unsuccessful osp sync records properly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 591f8771df00e1c3279019281e5f7d2e7c7e4877</p> <p>Landed for 2.8</p> Related LU-6269 LU-6687 Development Rank 1|hzwqmv: Rank (Obsolete) 14781 Severity