https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5320 Lustre <p>When coccinelle (a static analyser) is run on the Lustre code, with the current Linux kernel scripts, it finds, amongst other things, the following errors:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> lustre/include/obd_support.h:792:19-22: ERROR: reference preceded by free on line 791 lustre/ptlrpc/nrs_tbf.c:312:2-8: preceding lock on line 307 lustre/fid/fid_handler.c:73:43-51: ERROR: cli is NULL but dereferenced. lustre/lfsck/lfsck_lib.c:1564:1-10: second lock on line 1571 </pre> </div></div> LU-5320

Use after free, double lock found by coccinelle

Bug Critical Resolved Fixed Jodi Levi Frank Zago patch Thu, 10 Jul 2014 15:33:43 +0000 Wed, 19 Aug 2015 01:46:59 +0000 Fri, 11 Jul 2014 11:19:23 +0000 Lustre 2.6.0 0 4 <p><a href="http://review.whamcloud.com/11047" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11047</a></p> <p>lustre/include/obd_support.h:792:19-22 is a false positive.</p> <p>Hi Frank,</p> <p>I'm curious. Which version of coccinelle are you using? I used it some it a while ago but had too many issues with it. How well do you find it to work? Perhaps I should try it again.</p> <p>I'm running it from Ubuntu. I installed the PPA then coccinelle (<a href="http://coccinelle.lip6.fr/download.php" class="external-link" target="_blank" rel="nofollow noopener">http://coccinelle.lip6.fr/download.php</a>). It's the latest version (1.0.0-rc21).</p> <p>I then run it from a linux kernel tree:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>make coccicheck -j7 M=&lt;path to lustre&gt;/lustre-release </pre> </div></div> <p>Landed for 2.6</p> Related LU-2753 Development Rank 1|hzwr3j: Rank (Obsolete) 14857 Severity