<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 01:50:33 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-5329] Remove obsollete nidtbl swabbing code</title>
                <link>https://jira.whamcloud.com/browse/LU-5329</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;lustre/ldlm/ldlm_lib.c has this warning that needs to be fixed:&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;#if LUSTRE_VERSION_CODE &amp;lt; OBD_OCD_VERSION(2, 6, 51, 0)
        /* 2.2.0 clients always swab nidtbl entries due to a bug, so server
         * will do the swabbing for if the client is using the same endianness.
         *
         * This fixup is version-limited, because we don&apos;t want to carry the
         * OBD_CONNECT_MNE_SWAB flag around forever, just so long as we need
         * interop with unpatched 2.2 clients.  For newer clients, servers
         * will never do MNE swabbing, let the client handle that.  LU-1644 */
        export-&amp;gt;exp_need_mne_swab = !ptlrpc_req_need_swab(req) &amp;amp;&amp;amp;
                        !(data-&amp;gt;ocd_connect_flags &amp;amp; OBD_CONNECT_MNE_SWAB);
#else
#warning &quot;LU-1644: Remove old OBD_CONNECT_MNE_SWAB fixup and exp_need_mne_swab&quot;
#endif
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="25536">LU-5329</key>
            <summary>Remove obsollete nidtbl swabbing code</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.whamcloud.com/images/icons/priorities/critical.svg">Critical</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="emoly.liu">Emoly Liu</assignee>
                                    <reporter username="green">Oleg Drokin</reporter>
                        <labels>
                            <label>MB</label>
                            <label>bb</label>
                    </labels>
                <created>Fri, 11 Jul 2014 03:41:02 +0000</created>
                <updated>Tue, 11 Nov 2014 20:26:59 +0000</updated>
                            <resolved>Tue, 11 Nov 2014 20:26:59 +0000</resolved>
                                    <version>Lustre 2.7.0</version>
                                    <fixVersion>Lustre 2.7.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>7</watches>
                                                                            <comments>
                            <comment id="91848" author="pjones" created="Mon, 18 Aug 2014 14:56:52 +0000"  >&lt;p&gt;Emoly&lt;/p&gt;

&lt;p&gt;Could you please look into this one?&lt;/p&gt;

&lt;p&gt;Thanks&lt;/p&gt;

&lt;p&gt;Peter&lt;/p&gt;</comment>
                            <comment id="91926" author="emoly.liu" created="Tue, 19 Aug 2014 08:16:49 +0000"  >&lt;p&gt;I saw this code from &lt;a href=&quot;http://review.whamcloud.com/#/c/3897/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/#/c/3897/&lt;/a&gt;. So we haven&apos;t worked with 2.2 clients any more since 2.6.50, right? Then, do I need to remove other parts of code introduced by the fixes of &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-1644&quot; title=&quot;lustre b2_2&amp;lt;-&amp;gt;master failure on lustre-initialization-1: ASSERTION( entry-&amp;gt;mne_length &amp;lt;= ((1UL) &amp;lt;&amp;lt; 12) )&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-1644&quot;&gt;&lt;del&gt;LU-1644&lt;/del&gt;&lt;/a&gt; as well? &lt;/p&gt;</comment>
                            <comment id="91962" author="jay" created="Tue, 19 Aug 2014 18:14:16 +0000"  >&lt;p&gt;Andreas can comment this.&lt;/p&gt;</comment>
                            <comment id="92351" author="adilger" created="Mon, 25 Aug 2014 20:43:36 +0000"  >&lt;p&gt;I disable this code as part of &lt;a href=&quot;http://review.whamcloud.com/8630&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/8630&lt;/a&gt; after 2.6.53, among other cleanups.&lt;/p&gt;

&lt;p&gt;It would be great if you could move that patch along to landing.  The code could then be deleted in a separate patch as part of this bug.&lt;/p&gt;</comment>
                            <comment id="92483" author="jlevi" created="Tue, 26 Aug 2014 18:06:26 +0000"  >&lt;p&gt;Emoly,&lt;br/&gt;
Could you please rebase Change, 8630?&lt;/p&gt;</comment>
                            <comment id="93334" author="jlevi" created="Fri, 5 Sep 2014 16:28:52 +0000"  >&lt;p&gt;Patch landed to Master.&lt;/p&gt;</comment>
                            <comment id="94109" author="jamesanunez" created="Mon, 15 Sep 2014 23:16:19 +0000"  >&lt;p&gt;I&apos;m reopening this ticket so that we can post the patch that actually removes the nidtbl swab code here. &lt;/p&gt;

&lt;p&gt;There are four sections of code that should be deleted as part of this patch: &lt;/p&gt;

&lt;p&gt;In file lustre/ldlm/ldlm_lib.c, routine target_handle_connect(), &lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;#if LUSTRE_VERSION_CODE &amp;lt; OBD_OCD_VERSION(2, 6, 53, 0)
                /* 2.2.0 clients always swab nidtbl entries due to a bug, so server
                * will do the swabbing for if the client is using the same endianness.
                *
                * This fixup is version-limited, because we don&apos;t want to carry the
                * OBD_CONNECT_MNE_SWAB flag around forever, just so long as we need
                * interop with unpatched 2.2 clients.  For newer clients, servers
                * will never do MNE swabbing, let the client handle that.  LU-1644 */
                export-&amp;gt;exp_need_mne_swab = !ptlrpc_req_need_swab(req) &amp;amp;&amp;amp;
                                                !(data-&amp;gt;ocd_connect_flags &amp;amp; OBD_CONNECT_MNE_SWAB);
#endif
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;and in file lustre/mgs/mgs_nids., routine mgs_nidtbl_read(), &lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;#if LUSTRE_VERSION_CODE &amp;lt; OBD_OCD_VERSION(2, 6, 53, 0)
                                                                /* May need to swab back to update the length.*/
                                                                if (exp-&amp;gt;exp_need_mne_swab)
                                                                                lustre_swab_mgs_nidtbl_entry(last_in_unit);
#endif
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;In mgs_nidtbl_read(), &lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;#if LUSTRE_VERSION_CODE &amp;lt; OBD_OCD_VERSION(2, 6, 53, 0)
                                                                if (exp-&amp;gt;exp_need_mne_swab)
                                                                                lustre_swab_mgs_nidtbl_entry(last_in_unit);
#endif
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;In mgs_nidtbl_read(),&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;#if LUSTRE_VERSION_CODE &amp;lt; OBD_OCD_VERSION(2, 6, 53, 0)
                                /* For LU-1644, swab entry for 2.2 clients. */
                                if (exp-&amp;gt;exp_need_mne_swab)
                                                lustre_swab_mgs_nidtbl_entry(entry);
#endif

&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;I&apos;m happy to upload a patch for this code removal when 2.6.53 is tagged. &lt;/p&gt;</comment>
                            <comment id="94668" author="jamesanunez" created="Mon, 22 Sep 2014 23:14:24 +0000"  >&lt;p&gt;Proposed patch to remove obsolete code is at &lt;a href=&quot;http://review.whamcloud.com/12010&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/12010&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="98923" author="jamesanunez" created="Tue, 11 Nov 2014 20:26:59 +0000"  >&lt;p&gt;Patch removing obsolete code landed to master (pre-2.7)&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Related</name>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="15256">LU-1644</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzwr6n:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>14871</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>