[LU-5352] bad if condition in dt_index_read()

Related — Thu, 14 Jun 2018 21:41:35 +0000

In dt_index_read() we test to if the unsigned int rdpg->rp_count is <= 0 and a multiple of LU_PAGE_SIZE:

        /* rp_count shouldn't be null and should be a multiple of the container           
         * size */
        if (rdpg->rp_count <= 0 && (rdpg->rp_count & (LU_PAGE_SIZE - 1)) != 0)
                RETURN(-EFAULT);

The '&&' should be '||'.

This was found using the clang analyzer.

Whamcloud Community JIRA

[LU-5352] bad if condition in dt_index_read()