https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5383 Lustre <p>Found 1 new static analysis issues in 2.5.59-27-g75752e9:</p> <ol> <li><b>Buffer Overflow &#45; Array Index Out of Bounds</b> <ul> <li><tt>lustre/utils/mount_lustre.c</tt>: in <em>parse_ldd</em>, Array 'ldd&#95;svname' of size 64 may use index value(s) &#45;8..&#45;1. Also there are 3 similar errors on line(s) 424, 426, 427.</li> </ul> </li> </ol> <p>Details:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">mount_lustre.c:422: rc = strlen(ldd-&gt;ldd_svname) mount_lustre.c:422: Possible value(s) of <span class="code-quote">'strlen(ldd-&gt;ldd_svname)'</span> is <span class="code-quote">'[0,63]'</span> mount_lustre.c:423: rc-8 mount_lustre.c:423: Inferred value <span class="code-quote">'rc'</span> is <span class="code-quote">'[0,63]'</span> mount_lustre.c:423: Result of expression <span class="code-quote">'rc - 8'</span> is <span class="code-quote">'[-8,55]'</span> mount_lustre.c:423: Array <span class="code-quote">'ldd_svname'</span> size is 64. mount_lustre.c:423: Possible attempt to access element -8..-1 of array <span class="code-quote">'ldd_svname'</span>. </pre> </div></div> <p>The list of commits since the previous build 2.5.59-0-g28f2ff9:</p> <div class='table-wrap'> <table class='confluenceTable'><tbody> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=75752e918b942000e24c979edcb3eed415dc5197" class="external-link" target="_blank" rel="nofollow noopener">75752e9</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-3319" title="Adapt to 3.10 upstream kernel proc_dir_entry change" class="issue-link" data-issue-key="LU-3319"><del>LU-3319</del></a> procfs: Move NRS TBF proc handling to seq_files</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=ea766f3be969997ce9e92cf9b359fc818583851a" class="external-link" target="_blank" rel="nofollow noopener">ea766f3</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-3319" title="Adapt to 3.10 upstream kernel proc_dir_entry change" class="issue-link" data-issue-key="LU-3319"><del>LU-3319</del></a> procfs: move osp proc handling to seq_files</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=cae32fb38f0754ab2f8eae89ffe9151c6c194ef8" class="external-link" target="_blank" rel="nofollow noopener">cae32fb</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4913" title="mgc import reconnect race" class="issue-link" data-issue-key="LU-4913"><del>LU-4913</del></a> mgc: mgc import reconnect race</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=7936ec229c7f62cfbf5a0e4ff5933149967e7c8f" class="external-link" target="_blank" rel="nofollow noopener">7936ec2</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4843" title="2.6: DNE stripe directory - 2.5.0 clients" class="issue-link" data-issue-key="LU-4843"><del>LU-4843</del></a> mdt: disallow old clients access striped dir</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a7319633ddc7400435a9492774c229dabd3d784d" class="external-link" target="_blank" rel="nofollow noopener">a731963</a></td> <td class='confluenceTd'>Revert "<a href="https://jira.whamcloud.com/browse/LU-4933" title="Automatically tune the max_dirty_mb" class="issue-link" data-issue-key="LU-4933"><del>LU-4933</del></a> osc: Automatically tune the max_dirty_mb"</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=29bd1e0228c0dee31bf876548c7621b51d8a09af" class="external-link" target="_blank" rel="nofollow noopener">29bd1e0</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4925" title="bad negative dentry caching in striped directory" class="issue-link" data-issue-key="LU-4925"><del>LU-4925</del></a> lmv: validate lock with correct stripe FID</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=0d8c5ccc4ecfe7c0d10a0a4f92fd291320a97190" class="external-link" target="_blank" rel="nofollow noopener">0d8c5cc</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4603" title="NFS reexport leads to problems of &quot;ls&quot;" class="issue-link" data-issue-key="LU-4603"><del>LU-4603</del></a> lmv: a few fixes about readdir of striped dir.</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=b48b921a5f36771bacdb0094d7ec4fe94cdf0c48" class="external-link" target="_blank" rel="nofollow noopener">b48b921</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4991" title="Test failure on test suite sanity, subtest test_56s" class="issue-link" data-issue-key="LU-4991"><del>LU-4991</del></a> test: check files in sanity 56s</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=3e8c354c09725a97b90e477a77411cc6fb306f09" class="external-link" target="_blank" rel="nofollow noopener">3e8c354</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4606" title="Lustre hard codes libzfs.so.1 in lustre/utils/mount_utils_zfs.c" class="issue-link" data-issue-key="LU-4606"><del>LU-4606</del></a> utils: Mount uses so for backing fstype</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=cbade14c3f853c4f61f7878c34af6c2cf0baafc8" class="external-link" target="_blank" rel="nofollow noopener">cbade14</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-5065" title="lfs should dogfood llapi" class="issue-link" data-issue-key="LU-5065"><del>LU-5065</del></a> utils: uninclude lustre_idl.h from lfs</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=d6f26343824941793010785fd35a74924ad84225" class="external-link" target="_blank" rel="nofollow noopener">d6f2634</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4993" title="support for 3.14 linux kernel" class="issue-link" data-issue-key="LU-4993"><del>LU-4993</del></a> llite: Support 3.14 kernel changes to bio api</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=482b5e7f76b3fdb48c987de2f221bdcae8b4f5e2" class="external-link" target="_blank" rel="nofollow noopener">482b5e7</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-5034" title="Change readdir BRW size from bytes to pages" class="issue-link" data-issue-key="LU-5034"><del>LU-5034</del></a> llite: Change readdir BRW metrics</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c2c28f2aa5d65d889bf5d1a707fec82e8f852c86" class="external-link" target="_blank" rel="nofollow noopener">c2c28f2</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-3963" title="cleanup libcfs wrappers" class="issue-link" data-issue-key="LU-3963"><del>LU-3963</del></a> libcfs: move mgs, osd-ldiskfs, osp, quota to linux list api</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=64b1cfcacd15b05acd157c24ec626c361fc5e5d9" class="external-link" target="_blank" rel="nofollow noopener">64b1cfc</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4974" title="Doxygen comments - lod module" class="issue-link" data-issue-key="LU-4974"><del>LU-4974</del></a> lod: add prefix to struct lod_pool_iterator</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=6a2a17345af332af31d31c6c7b9ec369b17729e4" class="external-link" target="_blank" rel="nofollow noopener">6a2a173</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4961" title="utils and test should not depend on obd.h or liblustre.h" class="issue-link" data-issue-key="LU-4961"><del>LU-4961</del></a> build: remove libsysio and liblustre autoconf tests</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=8dfee22dd5a896144fb913f5f9f0e8f5c0e4ed86" class="external-link" target="_blank" rel="nofollow noopener">8dfee22</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4569" title="Posix copytool import a file using only its FID" class="issue-link" data-issue-key="LU-4569"><del>LU-4569</del></a> hsm: Prevent copytool from importing existing file.</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c0a8fa3749834fa1e6f148ffec8b58ea578c1af4" class="external-link" target="_blank" rel="nofollow noopener">c0a8fa3</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> fid: remove liblustre includes</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=8fd6a0829e326935f2b20b150844d8ab07d20e05" class="external-link" target="_blank" rel="nofollow noopener">8fd6a08</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-3953" title="lustre build system improvments" class="issue-link" data-issue-key="LU-3953"><del>LU-3953</del></a> build: look for kconfig.h in $LINUX</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=5303c139e3cef8ed09b85cf828afbbe24ea0d7db" class="external-link" target="_blank" rel="nofollow noopener">5303c13</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4933" title="Automatically tune the max_dirty_mb" class="issue-link" data-issue-key="LU-4933"><del>LU-4933</del></a> osc: Automatically tune the max_dirty_mb</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=85b037f5da6a022919783ef9a87ed6d2a4d102d2" class="external-link" target="_blank" rel="nofollow noopener">85b037f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4904" title="parallel-scale test write_append_truncate failed with divide error " class="issue-link" data-issue-key="LU-4904"><del>LU-4904</del></a> test: write_append_truncate failed with divide error</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=90636ff53d8d2d714a7591c4bb9a75a7c69f997f" class="external-link" target="_blank" rel="nofollow noopener">90636ff</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-3319" title="Adapt to 3.10 upstream kernel proc_dir_entry change" class="issue-link" data-issue-key="LU-3319"><del>LU-3319</del></a> procfs: move mdt/mds proc handling to seq_files</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=8d3c7316fc94297e1d92f4ec31cf941a389f6f82" class="external-link" target="_blank" rel="nofollow noopener">8d3c731</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-3319" title="Adapt to 3.10 upstream kernel proc_dir_entry change" class="issue-link" data-issue-key="LU-3319"><del>LU-3319</del></a> procfs: move lod proc handling to seq_files</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=1b6d4ae18692ab4e8cb7330d8af4f905ab8213fb" class="external-link" target="_blank" rel="nofollow noopener">1b6d4ae</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-1330" title="split/cleanup for obdclass/fid/fld modules" class="issue-link" data-issue-key="LU-1330"><del>LU-1330</del></a> obdclass: splits server-side procfs handling</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=864fc9daac267819f5e3bdebef6cdac4c6325626" class="external-link" target="_blank" rel="nofollow noopener">864fc9d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-2059" title="mgc to backup configuration on osd-based llogs" class="issue-link" data-issue-key="LU-2059"><del>LU-2059</del></a> mgs: don't fail on missing params log</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c6a034b746bffc5a11f0c9ec4848d54dea90ca23" class="external-link" target="_blank" rel="nofollow noopener">c6a034b</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4883" title="mdc_set_lock_data()) ASSERTION( old_inode-&gt;i _state &amp; I_FREEING ) failed: ..." class="issue-link" data-issue-key="LU-4883"><del>LU-4883</del></a> lmv: disable sub-stripe access from .lustre/fid</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=be1374ee9bc1dac6706e8dadb5389167cf8c4b1d" class="external-link" target="_blank" rel="nofollow noopener">be1374e</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4981" title="need to remount after sanity 133g " class="issue-link" data-issue-key="LU-4981"><del>LU-4981</del></a> test: Fix IO redirect in sanity 133g</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=241cdb8ba008d47fd96f0b6529797ce922e2b635" class="external-link" target="_blank" rel="nofollow noopener">241cdb8</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-5018" title="e2fsprogs build failed" class="issue-link" data-issue-key="LU-5018"><del>LU-5018</del></a> libcfs: don't depend on configure for lustre_user.h</td> </tr> </tbody></table> </div> LU-5383

New static analysis issues in mount_lustre

Bug Minor Resolved Fixed Dmitry Eremin Dmitry Eremin kw Fri, 23 May 2014 12:15:32 +0000 Wed, 30 Aug 2023 21:37:20 +0000 Wed, 5 Nov 2014 10:28:23 +0000 Lustre 2.7.0 0 2 <p>Patch is <a href="http://review.whamcloud.com/12524/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12524/</a></p> <p>Patch landed to master.</p> <p>The patch <a href="http://review.whamcloud.com/#/c/12524/2" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/12524/2</a> breaks mounts of MGS/MGT volumes with short names (which is valid for an MGS/MDT, since they do not have to include an index or the file system name).</p> <p><span class="error">&#91;root@centss02 ~&#93;</span># mount -t lustre -o abort_recov /dev/sdb /tmp/lustre/centss02/mgt<br/> mount.lustre: invalid name 'MGS'</p> <p>Since the entire purpose of that code is to fix up OST &amp; MDT names to indicate their status, presumably the solution is to simply not call this check on the MGS/MGT volume.</p> <p>I'll open a new LU for this.</p> Related LU-4629 Development Rank 1|hzwmzz: Rank (Obsolete) 14067 Severity