https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5396 Lustre <p>sparse (git://git.kernel.org/pub/scm/devel/sparse/sparse.git) is a static analyzer used in kernel dev. After installing it, it can easily be used with Lustre:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>make C=1 </pre> </div></div> <p>Currently there is about 3900 warnings. Most of it is noise, and a few annotations will silence them. However in that noise, some bugs might be lurking.</p> <p>Besides finding bugs, it currently tags 1000 functions that can be made static. Once marked static, that will enable the compiler to optimize them more aggressively, which may lead to some minor performance improvements.</p> <p>So far I've cleared about 1000 of them and found only one bug (strcmp with userspace provided buffer in fld_proc_hash_seq_write) and several unused functions.</p> LU-5396

annotations for sparse static analyzer

Bug Trivial Resolved Fixed Dmitry Eremin Frank Zago patch Wed, 23 Jul 2014 18:53:27 +0000 Thu, 26 Feb 2015 22:29:54 +0000 Thu, 26 Feb 2015 22:29:54 +0000 Lustre 2.6.0 Lustre 2.7.0 0 8 <p>This should be linked with the <a href="https://jira.whamcloud.com/browse/LU-2753" title="Tracking bug for static code analysis fixes." class="issue-link" data-issue-key="LU-2753"><del>LU-2753</del></a> work.</p> <p>Frank,<br/> John has started some work using sparse and annotating functions/parameters with __user and such to find incorrect usage. I would welcome further patches for annotations of the Lustre code to clean up the false positives (and of course fix any resulting bugs) so that sparse can provide more useful output.</p> <p>I'd recommend not to put too many changes into a single patch, so that they are easier to inspect and land independently and avoid conflicts with other patches.</p> <p>Not a problem Andreas. This is a grinding work that is best done a bit at a time <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>use gfp_t: <a href="http://review.whamcloud.com/11200" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11200</a> (upstream)</p> <p>Add __user annotations. This apparently may conflict with John's patches, but I've had these for a while already.<br/> <a href="http://review.whamcloud.com/11480" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11480</a> (upstream)<br/> <a href="http://review.whamcloud.com/11202" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11202</a> (upstream)<br/> <a href="http://review.whamcloud.com/11203" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11203</a> (abandoned)<br/> <a href="http://review.whamcloud.com/11204" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11204</a> (abandoned)<br/> <a href="http://review.whamcloud.com/11205" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11205</a> (abandoned)<br/> <a href="http://review.whamcloud.com/11206" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11206</a> (abandoned)</p> <p>Locking annotations:<br/> <a href="http://review.whamcloud.com/11481" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11481</a> (upstream)<br/> <a href="http://review.whamcloud.com/11294" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11294</a> (upstream)<br/> <a href="http://review.whamcloud.com/11295" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11295</a></p> <p>Made some functions static:<br/> <a href="http://review.whamcloud.com/11305" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11305</a> (upstream)<br/> <a href="http://review.whamcloud.com/11306" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11306</a></p> <p> <a href="http://review.whamcloud.com/11255" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11255</a> (upstream)<br/> <a href="http://review.whamcloud.com/11256" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11256</a> (upstream)</p> <p>Add __user annotations.</p> <p> <a href="http://review.whamcloud.com/11802" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11802</a> (abandoned, see below)<br/> <a href="http://review.whamcloud.com/11803" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11803</a> (abandoned, see below)<br/> <a href="http://review.whamcloud.com/11804" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11804</a> (abandoned, see below)<br/> <a href="http://review.whamcloud.com/11805" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11805</a> (abandoned, see below)<br/> <a href="http://review.whamcloud.com/11806" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11806</a> (abandoned, see below)<br/> <a href="http://review.whamcloud.com/11807" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11807</a> (abandoned, see below)<br/> <a href="http://review.whamcloud.com/11808" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11808</a> (abandoned, see below)<br/> <a href="http://review.whamcloud.com/11809" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11809</a> (abandoned, see below)<br/> <a href="http://review.whamcloud.com/11810" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11810</a> (abandoned, see below)</p> <p>Thank you for doing this. A lot of the upstream kernel Lustre client patches are these types of patches. This will help us move closer to the upstream client for style issues much faster.</p> <p>Add __user annotations (same as above, but 1 patch per branch)<br/> <a href="http://review.whamcloud.com/11817" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11817</a> (upstream)<br/> <a href="http://review.whamcloud.com/11818" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11818</a> (upstream)<br/> <a href="http://review.whamcloud.com/11819" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11819</a> (upstream)<br/> <a href="http://review.whamcloud.com/11820" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11820</a> (upstream)<br/> <a href="http://review.whamcloud.com/11821" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11821</a> (upstream)<br/> <a href="http://review.whamcloud.com/11822" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11822</a> (upstream)<br/> <a href="http://review.whamcloud.com/11823" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11823</a> (upstream)<br/> <a href="http://review.whamcloud.com/11824" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11824</a> (upstream)</p> <p>Frank</p> <p>I see that all the present patches tracked under this ticket have landed. Are there more to come or can we now close this ticket?</p> <p>Peter</p> <p>Hi Peter, there's quite a few more patches to come.</p> <p>Number of warnings is down to less to 1000 now.</p> <p>A 1000?! The final straight then <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Make some static symbols:<br/> <a href="http://review.whamcloud.com/12206" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12206</a><br/> <a href="http://review.whamcloud.com/12207" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12207</a><br/> <a href="http://review.whamcloud.com/12211" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12211</a><br/> <a href="http://review.whamcloud.com/12219" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12219</a><br/> <a href="http://review.whamcloud.com/12220" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12220</a><br/> <a href="http://review.whamcloud.com/12221" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12221</a> <br/> <a href="http://review.whamcloud.com/12222" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12222</a><br/> <a href="http://review.whamcloud.com/12223" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12223</a></p> <p>Done for this series. There will a new one once this one is integrated.</p> <p>0 -&gt; NULL: <br/> <a href="http://review.whamcloud.com/12567" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12567</a></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12207/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12207/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> libcfs: make some functions static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 336f628d5ea17cb0afe26cd966e333e40755b38b</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12211/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12211/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> llite: make some functions static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 26bcb8fcd034f2edc993fa27a9158479836523b8</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12219/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12219/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> ptlrpc: make some functions static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d00c924149b5dd042e6fee09ef724013df1b4e14</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12221/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12221/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> lov: (and ldlm) make some functions static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9c6d90191a7d7685d98aee7fb49ff6c23e3956ff</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12222/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12222/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> mdc: (and lmv, mgc, osc) make some functions static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 35fe4c696dd0faadc9405c19c68f0dd56aa5bb01</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12220/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12220/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> obdclass: make some functions static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e0ece89e1ac014a8443fe95860c4a43b88f16f63</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12206/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12206/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> lnet: make some functions static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 33984c012883a7c714429d2c612cf6dcda191974</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12223/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12223/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> lod: (and mdt, mgs) make some symbols static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ad1810a2dbea1eed5e8b5feb55bdf915a545feb3</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12567/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12567/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5396" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-5396"><del>LU-5396</del></a> all: use NULL instead of 0<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e49995acfd026f3ca85d05dc1b91d97a8743fe72</p> <p>Looks like all the patches for this ticket were landed.</p> <p>There's more patches to come. There's about 300 warnings left.</p> <p>Create a new ticket <a href="https://jira.whamcloud.com/browse/LU-6302" title="annotations for sparse static analyzer" class="issue-link" data-issue-key="LU-6302"><del>LU-6302</del></a> for future sparse patches, close this one for the fixes landed to 2.7.0.</p> Related LU-2753 LU-6215 LU-6302 Development Rank 1|hzws1z: Rank (Obsolete) 15020 Severity