https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-54 Lustre <p>As described in bug 22729, the use of LPSZ should be removed for portability purposes, as well as to match the master branch. </p> <p>As Andreas says:<br/> """<br/> To be honest, I'd rather just get rid of LPSZ and cast the values<br/> to (int) or (long) and use %u or %lu as needed. For the 10 or 15<br/> places that we use LPSZ in b1_8 I think we should just get rid of it.</p> <p>See my earlier comment that LPSZ has been removed entirely from<br/> master, so I'd rather modify the b1_8 code to be more like master<br/> instead of moving away from it.<br/> """</p> LU-54

LPSZ should be removed from 1.8 to match master

Bug Minor Resolved Fixed Niu Yawei Kit Westneat Mon, 24 Jan 2011 19:17:47 +0000 Tue, 28 Jun 2011 15:01:39 +0000 Wed, 30 Mar 2011 11:07:34 +0000 Lustre 1.8.6 Lustre 1.8.6 0 0 <p>Niu will be looking into this one</p> <p>patch is ready for review.<a href="http://review.whamcloud.com/219" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/219</a></p> <p>Niu</p> <p>I suggest that you get Johann's approval for this change. He starts with us next week.</p> <p>Regards</p> <p>Peter</p> <p>Yes, I've posted the patch in b22729 and added Johann for review. Whenever he joined us, I'll add him in Jira to review this patch.</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/reviews-centos5/565/" class="external-link" target="_blank" rel="nofollow noopener">reviews-centos5 #565</a><br/> <a href="https://jira.whamcloud.com/browse/LU-54" title="LPSZ should be removed from 1.8 to match master" class="issue-link" data-issue-key="LU-54"><del>LU-54</del></a> Remove LPSZ &amp; LPSSZ</p> <p>Niu Yawei : <a href="http://git.whamcloud.com/gitweb/?p=fs/lustre-release.git&amp;a=commit&amp;h=a95f4e3938e9db452afeb97b104c6139a9c9da28" class="external-link" target="_blank" rel="nofollow noopener">a95f4e3938e9db452afeb97b104c6139a9c9da28</a><br/> Files : </p> <ul> <li>lustre/llite/lproc_llite.c</li> <li>lnet/include/libcfs/linux/kp30.h</li> <li>lnet/include/libcfs/darwin/kp30.h</li> <li>lustre/obdclass/obd_mount.c</li> <li>lnet/klnds/gmlnd/gmlnd_comm.c</li> <li>lnet/include/libcfs/winnt/kp30.h</li> <li>lustre/obdclass/class_obd.c</li> <li>lustre/include/darwin/lustre_user.h</li> <li>lnet/autoconf/lustre-lnet.m4</li> <li>lustre/llite/rw26.c</li> <li>lustre/lvfs/fsfilt_ext3.c</li> <li>lustre/llite/file.c</li> <li>lustre/mds/mds_join.c</li> </ul> <p>Niu</p> <p>Does the version of the patch passed upstream to Oracle for landing need updating? I expect to see it landed soon...</p> <p>Peter</p> <p>No, there isn't change, I just re-push it for passing the build. (originally, the build will fail on ubuntu for some other bug which Brian was working on) </p> <p>Good - thanks for confirming!</p> <p>Niu,</p> <p>Landing permission has been granted by Oracle for this change. Can you please send the patch to lustre-gate-18@sun.com </p> <p>Thanks</p> <p>Peter</p> <p>Oracle have landed this change upstream for 1.8.6 and it is already landed for master so mark as resolve</p> Bugzilla ID 22729.0 Development Rank 1|hzw15z: Rank (Obsolete) 10270 Severity