https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5418 Lustre <p>Newer versions of readline have removed (or hidden) CPPFunction, leading to the following compilation issue:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> util/parser.c: In function 'init_input': util/parser.c:308:45: error: 'CPPFunction' undeclared (first use in this function) rl_attempted_completion_function = (CPPFunction *)command_completion; </pre> </div></div> <p>The affects Ubuntu 14.04.</p> LU-5418

compile fix for code using readline

Bug Minor Resolved Fixed Cliff White Frank Zago patch Fri, 25 Jul 2014 18:30:32 +0000 Tue, 30 Dec 2014 23:41:57 +0000 Tue, 26 Aug 2014 13:05:48 +0000 Lustre 2.6.0 Lustre 2.7.0 0 6 <p><a href="http://review.whamcloud.com/11231" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11231</a></p> <p>Landed for 2.7</p> <p>The fix recently landed to master, <a href="http://review.whamcloud.com/#/c/11231" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/11231</a>, breaks the build in some newer kernels. In particular there are now some new functions declared unconditionally:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>static void noop_int_fn(int unused) { } static void noop_void_fn(void) { } </pre> </div></div> <p>These functions are only used in code that is #ifdef HAVE_LIBREADLINE. When building where HAVE_LIBREADLINE is #undef'ed, for example on fc20, this causes build errors and build failure even in client only builds.</p> <p>Sorry about that I'll send a fix shortly.</p> <p>The build failure due to lack of libreadline.so may be caused by rpm changes. In earlier el6 and el7 there wasn't any readline-devel rpm, the required lib was in the readline rpm. If the additional readline-devel rpm is installed on fc20 then libreadline.so is present, HAVE_LIBREADLINE is #define'd, and the build is OK. That said the new libcfs code does fail to build when HAVE_LIBREADLINE is #undef'ed.</p> <p><a href="http://review.whamcloud.com/11252" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/11252</a></p> <p>Putting the actual error messages from the build in here so others can find this more easily (as I failed to):</p> <p>cc1: warnings being treated as errors<br/> util/parser.c:286: error: 'noop_int_fn' defined but not used<br/> util/parser.c:287: error: 'noop_void_fn' defined but not used<br/> make<span class="error">&#91;5&#93;</span>: *** <span class="error">&#91;libcfsutil_a-parser.o&#93;</span> Error 1<br/> make<span class="error">&#91;5&#93;</span>: *** Waiting for unfinished jobs....<br/> make<span class="error">&#91;4&#93;</span>: *** <span class="error">&#91;all-recursive&#93;</span> Error 1<br/> make<span class="error">&#91;3&#93;</span>: *** <span class="error">&#91;all-recursive&#93;</span> Error 1<br/> make<span class="error">&#91;2&#93;</span>: *** <span class="error">&#91;all-recursive&#93;</span> Error 1<br/> make<span class="error">&#91;1&#93;</span>: *** <span class="error">&#91;all&#93;</span> Error 2<br/> error: Bad exit status from /var/tmp/rpm-tmp.nePJql (%build)</p> <p>to correct my earlier comment the readline-devel rpm does exist in el6 &amp; el7 too. just never saw a problem there as all our builder nodes have both readline and readline-devel rpms installed. until the mod lands a simple workaround is to just install the readline-devel rpm. as far as I know that works everywhere.</p> <p>It looks like the follow on patch has landed to master now</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12447/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12447/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5418" title="compile fix for code using readline" class="issue-link" data-issue-key="LU-5418"><del>LU-5418</del></a> echo: replace lov_stripe_md with lov_oinfo<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: eecdcf3004952f5d3a7126e0d6790c0be82f0a56</p> <p>Could this be merged into b2_6 as well? Ran into this issue building on an Ubuntu 14.04 system with libreadline-dev-6.3-4.</p> Duplicate LU-5445 LU-5448 Related Development Rank 1|hzwscv: Rank (Obsolete) 15069 Severity