https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-555 Lustre <p>Suggested by Andreas:<br/> in ll_md_blocking_ast(), Instead of doing multiple searches for these lock bits, it makes more sense to change ll_have_md_lock() to take "&amp;bits" as the parameter (instead of a specific single bit), and then it can do a search on the first bit in the mask. If any lock is found, it can zero out all of the set lock bits in the lock from "&amp;bits".</p> <p>In the common case where there are multiple bits set in the lock this will avoid calling ll_have_md_lock-&gt;md_lock_match() multiple times for each file.</p> LU-555

ll_have_md_lock() code optimization

Improvement Minor Resolved Fixed Peter Jones CEA Fri, 29 Jul 2011 11:05:14 +0000 Wed, 5 Aug 2020 13:32:57 +0000 Wed, 26 Oct 2011 13:27:04 +0000 Lustre 2.1.0 Lustre 2.2.0 0 0 <p>Please assign me this bug (I did not find how to take it)</p> <p>JC</p> <p>It seems that only Whamcloud engineers can be assigned tickets so I will assign it to myself even though you are really the owner.</p> <p>Peter</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=ofa/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,ofa #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/namei.c</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el6,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el6,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/file.c</li> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/dcache.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el6,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/file.c</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/dcache.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=sles11,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,sles11,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/llite_internal.h</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=ofa/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,ofa #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/dcache.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el6,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el6,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/namei.c</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=ofa/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,ofa #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/file.c</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/dcache.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/namei.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=ofa/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,ofa #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/namei.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/llite_capa.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el6,ib_stack=inkernel/311/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el6,inkernel #311</a><br/> <a href="https://jira.whamcloud.com/browse/LU-555" title="ll_have_md_lock() code optimization" class="issue-link" data-issue-key="LU-555"><del>LU-555</del></a> ll_have_md_lock() optimization to accelerate multiple bits locks</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=cc2836737d5401ad48e2aaf64db035d11e795ae5" class="external-link" target="_blank" rel="nofollow noopener">cc2836737d5401ad48e2aaf64db035d11e795ae5</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> <li>lustre/llite/namei.c</li> <li>lustre/llite/llite_capa.c</li> <li>lustre/llite/dcache.c</li> <li>lustre/llite/file.c</li> </ul> Development Rank 1|hzv89z: Rank (Obsolete) 4875