[LU-5589] NULL pointer dereferenced without check in lsi_prepare()

Wed, 5 Nov 2014 10:27:36 +0000

Pointer 'lsi->lsi_lmd->lmd_osd_type' checked for NULL at line 1390 will be dereferenced at line 1402.

	/* Determine osd type */
	if (lsi->lsi_lmd->lmd_osd_type != NULL) {
		if (strlen(lsi->lsi_lmd->lmd_osd_type) >=
		    sizeof(lsi->lsi_osd_type))
			RETURN(-ENAMETOOLONG);

		strcpy(lsi->lsi_osd_type, lsi->lsi_lmd->lmd_osd_type);
	} else {
		strcpy(lsi->lsi_osd_type, LUSTRE_OSD_LDISKFS_NAME);
	}

	/* XXX: a temp. solution for components using ldiskfs
	 *      to be removed in one of the subsequent patches */
	if (!strcmp(lsi->lsi_lmd->lmd_osd_type, "osd-ldiskfs"))
		strcpy(lsi->lsi_fstype, "ldiskfs");
	else
		strcpy(lsi->lsi_fstype, lsi->lsi_lmd->lmd_osd_type);

Whamcloud Community JIRA

[LU-5589] NULL pointer dereferenced without check in lsi_prepare()