[LU-5774] lu_object_find_at() should NOT test conditional that doesn't change inside a loop

Related — Wed, 23 Dec 2015 19:00:16 +0000

In lu_object_find_at():

       while (1) {
               if (conf != NULL && conf->loc_flags & LOC_F_NOWAIT) {
                       obj = lu_object_find_try(env, dev, f, conf, NULL);

                       return obj;
        ......
        }

If I haven't missed something, it doesn't make sense to have the 'if' conditional inside the while loop - conf is a const struct lu_object_conf *, i.e. it doesn't change, so the conditional would always evaluate the same.

When I first read the code, I was misled to believe that the conditional may change so it had to be tested at each iteration.

Whamcloud Community JIRA

[LU-5774] lu_object_find_at() should NOT test conditional that doesn't change inside a loop