Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-5829] too many EXPORT_SYMBOL in code https://jira.whamcloud.com/browse/LU-5829 Lustre <p>Lustre currently exports 1809 symbols, compared to 25395 symbols for the whole linux kernel.</p> <p>A lot of these symbols don't need to be exported at all because they are only used in the module they belong to.</p> LU-5829 too many EXPORT_SYMBOL in code Bug Minor Resolved Fixed Cliff White Frank Zago Thu, 30 Oct 2014 22:37:32 +0000 Tue, 2 Aug 2016 19:30:37 +0000 Sun, 19 Jul 2015 15:02:14 +0000 Lustre 2.8.0 0 6 <p>Removing 565 unnecessary exports: <a href="http://review.whamcloud.com/12510" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12510</a></p> <p>frank zago (fzago@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/13319" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13319</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> libcfs: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3c7c8828b71b306f5c70290ef02623ac3f2dc27b</p> <p>frank zago (fzago@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/13320" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13320</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> lnet: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 520e866feb00c83a79851dc94f5c44141bbba1c0</p> <p>frank zago (fzago@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/13321" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13321</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> misc: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: cd43357fbc0946db233369ed4d38055cecddb9df</p> <p>frank zago (fzago@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/13323" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13323</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> obdclass: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 44dcebf9d1a48b9acea3b09462da0f64080d9b24</p> <p>frank zago (fzago@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/13324" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13324</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> ldlm: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 5f75d00444ab1785e598f962091ca8d849169279</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13321/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13321/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> misc: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 34bdd30ec6a2010dfd98c5110487df210d03815d</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13323/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13323/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> obdclass: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: adc9384fd11b7fb3b71b363c310c9fa7b37e469f</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12510/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12510/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> ptlrpc: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3ee0e0908f12de97346cd5fe2996ad147adb9481</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13320/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13320/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> lnet: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: db841c2218bd184f0b113e99c316b9039194859c</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13324/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13324/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> ldlm: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e536e511c9e634d8cb7faf763ecab4cab5f40267</p> <p>One patch left that once landed we can close this ticket.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13319/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13319/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> libcfs: remove unnecessary EXPORT_SYMBOL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 502c141440b4e6a75a1162d25ba98315abe7ca4e</p> <p>Landed for 2.8</p> <p>frank zago (fzago@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/16482" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16482</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5829" title="too many EXPORT_SYMBOL in code" class="issue-link" data-issue-key="LU-5829"><del>LU-5829</del></a> quota: fixed invalid memset<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 4d46ee296e4698f1d699a264d0e209d2fb1ce11d</p> <p>Incorrect LU in commit. Please ignore that.</p> <blockquote><p>frank zago (fzago@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/13323" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13323</a></p></blockquote> <p>This patch is not correct. It removes e.g. lu_ref_add() export, but it is used from other modules (you can check with grep).<br/> Builds with --enable-lu_ref are broken because of this change.</p> <p>Fix for that issue is in <a href="https://jira.whamcloud.com/browse/LU-8471" title="missing EXPORT_SYMBOL for several lu_ref_* functions" class="issue-link" data-issue-key="LU-8471"><del>LU-8471</del></a>.</p> Related LU-6215 Development Rank 1|hzwzvb: Rank (Obsolete) 16350 Severity