https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5837 Lustre <p>Reviewers have made several suggestions on <a href="https://jira.whamcloud.com/browse/LU-3613" title="Get parent_fid + name for an entry" class="issue-link" data-issue-key="LU-3613"><del>LU-3613</del></a> which, though not critical, should be addressed for the sake of code quality &amp; efficiency.</p> LU-5837

ll_getparent improvements

Bug Minor Resolved Fixed John Hammond Henri Doreau patch Fri, 31 Oct 2014 23:01:59 +0000 Mon, 12 Jan 2015 19:13:33 +0000 Mon, 12 Jan 2015 19:13:33 +0000 Lustre 2.7.0 0 7 <p>Initial comments were made on: <a href="http://review.whamcloud.com/7069" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/7069</a></p> <p>Patch addressing the issues: <a href="http://review.whamcloud.com/12527" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12527</a></p> <p>John</p> <p>Could you please review Henri's latest changes?</p> <p>Thanks</p> <p>Peter</p> <p>0001-<a href="https://jira.whamcloud.com/browse/LU-5837" title="ll_getparent improvements" class="issue-link" data-issue-key="LU-5837"><del>LU-5837</del></a>-llite-create-linkea_seek_entry-and-use-it-in.patch</p> <p>So, I've tried to integrate your patch (see patchset #3). I think it adds some complexity (a third function to maintain, with duplicated logic) without bringing much since it's still required to iterate over the variable records to get the N-th entry. I tend to prefer patchset #2.</p> <p>Henri Doreau (henri.doreau@cea.fr) uploaded a new patch: <a href="http://review.whamcloud.com/12527" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12527</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5837" title="ll_getparent improvements" class="issue-link" data-issue-key="LU-5837"><del>LU-5837</del></a> llite: ll_getparent cleanup<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 5<br/> Commit: 749fec00ae1ca47135b7b5cedaf911b9420c2056</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12527/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12527/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5837" title="ll_getparent improvements" class="issue-link" data-issue-key="LU-5837"><del>LU-5837</del></a> llite: ll_getparent cleanup<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 188325f9211b6f2b87a04ec1155b005b8af54c2b</p> <p>Landed for 2.7</p> Related LU-5870 LU-3613 Development Rank 1|hzwzy7: Rank (Obsolete) 16364 Severity