https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5916 Lustre <p>A child directory should inherit from the OST pool of its parent.</p> <p>In Lustre 2.4 to master (2.7), this is no longer the case: the child directory has no LOV EA stored on the MDS, so the pool inheritance is lost when the MDS restarts.</p> <p>lfs getstripe indicates the child directory doesn't inherit from its parent pool.</p> <p><tt>mkdir /mnt/lustre/dir</tt><br/> <tt>lfs setstripe -p lustre.pool1 /mnt/lustre/dir</tt><br/> <tt>lfs getstripe -p /mnt/lustre/dir</tt><br/> returns "lustre.pool1" (correct)<br/> <tt>mkdir /mnt/lustre/dir/subdir</tt><br/> <tt>lfs getstripe -p /mnt/lustre/dir/subdir</tt><br/> <b>-&gt; empty (should return lustre.pool1)</b><br/> <tt>getfattr -n trusted.lov -d /mnt/lustre/dir/subdir</tt><br/> <b>/mnt/lustre/dir/subdir: trusted.lov: No such attribute</b><br/> <tt>touch /mnt/lustre/dir/subdir/file</tt><br/> <tt>lfs getstripe -p /mnt/lustre/dir/subdir/file</tt><br/> returns "lustre.pool1" (correct). Its seams the MDS inherited the pool somehow.</p> <p>Then, after restarting the MDS:<br/> <tt>touch /mnt/lustre/dir/subdir/file2</tt><br/> <tt>lfs getstripe -p /mnt/lustre/dir/subdir/file2</tt><br/> <b>-&gt; empty (should be lustre.pool1)</b></p> el6<br/> Lustre 2.4 to Lustre 2.7 (master). LU-5916

OST pool inheritence is no longer persistent (no LOV EA for child directory)

Bug Critical Resolved Fixed Niu Yawei Thomas LEIBOVICI - CEA HB Thu, 13 Nov 2014 10:58:56 +0000 Fri, 24 Feb 2017 07:01:32 +0000 Mon, 29 Dec 2014 14:49:50 +0000 Lustre 2.6.0 Lustre 2.7.0 Lustre 2.5.2 Lustre 2.4.3 Lustre 2.7.0 Lustre 2.5.4 0 11 <p>Niu</p> <p>Could you please advise?</p> <p>Thanks</p> <p>Peter</p> <p>I checked the code, looks we lost this when integrating LOD into the stack (that's from 2.3.51), because the default trusted.lov can still being inherited from parent and cached in memory, so creating file before restarting MDS should be fine.</p> <p>See the comment from mdd_object_create():</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> /* During creation, there are only a few cases we need <span class="code-keyword">do</span> xattr_set to * create stripes. * 1. regular file: see comments above. * 2. create striped directory with provided stripeEA. * 3. create striped directory because inherit <span class="code-keyword">default</span> layout from the * parent. */ </pre> </div></div> <p>Obviously we missed the 4th case that creating dir which inherits default striping (XATTR_NAME_LOV) from parent.</p> <p>And seems there are some other problems in this code path:</p> <p>In declare stage, see mdd_declare_object_create():</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-comment">/* replay <span class="code-keyword">case</span>, create LOV EA from client data */</span> <span class="code-keyword">if</span> (spec-&gt;no_create || (spec-&gt;sp_cr_flags &amp; MDS_OPEN_HAS_EA &amp;&amp; S_ISREG(attr-&gt;la_mode))) { <span class="code-keyword">const</span> struct lu_buf *buf; buf = mdd_buf_get_const(env, spec-&gt;u.sp_ea.eadata, spec-&gt;u.sp_ea.eadatalen); rc = mdo_declare_xattr_set(env, c, buf, XATTR_NAME_LOV, 0, handle); <span class="code-keyword">if</span> (rc) GOTO(out, rc); } </pre> </div></div> <p>It just missed declare for the case of inheriting parent's XATTR_NAME_LMV or XATTR_NAME_LOV.</p> <p>In create stage, see mdd_object_create():</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (spec-&gt;no_create || (S_ISREG(attr-&gt;la_mode) &amp;&amp; spec-&gt;sp_cr_flags &amp; MDS_OPEN_HAS_EA) || S_ISDIR(attr-&gt;la_mode)) { <span class="code-keyword">const</span> struct lu_buf *buf; buf = mdd_buf_get_const(env, spec-&gt;u.sp_ea.eadata, spec-&gt;u.sp_ea.eadatalen); rc = mdo_xattr_set(env, son, buf, S_ISDIR(attr-&gt;la_mode) ? XATTR_NAME_LMV : XATTR_NAME_LOV, 0, handle, BYPASS_CAPA); <span class="code-keyword">if</span> (rc != 0) GOTO(err_destroy, rc); } </pre> </div></div> <p>It seems to me that when inheriting parent's XATTR_NAME_LMV, the passed spec-&gt;u.sp_ea.eadata should be NULL, I'm not sure how it worked. Di, could take a look to see if I missed anytying here?</p> <p>Niu Yawei (yawei.niu@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12746" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12746</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5916" title="OST pool inheritence is no longer persistent (no LOV EA for child directory)" class="issue-link" data-issue-key="LU-5916"><del>LU-5916</del></a> lod: inherit default pool setting properly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2b237b11932af2b8dcf4a0401fc8e6c7cee37fbf</p> <p>I looked into the code closer and realized that the NAME_LOV for default stripping/pool is declared in lod_declare_object_create() and the NAME_LOV is set in mdd_object_create() -&gt; lod_xattr_set() -&gt; lod_dir_striping_create(), but for the case of parent has only pool setting (no default stripping), inheriting NAME_LOV is skipped mistakenly, see lod_dir_striping_create_internal():</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-comment">/* Transfer <span class="code-keyword">default</span> LOV striping from the parent */</span> <span class="code-keyword">if</span> (lo-&gt;ldo_striping_cached &amp;&amp; !LOVEA_DELETE_VALUES(lo-&gt;ldo_def_stripe_size, lo-&gt;ldo_def_stripenr, lo-&gt;ldo_def_stripe_offset)){ </pre> </div></div> <p>This patch fix the problem: <a href="http://review.whamcloud.com/#/c/12746" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/12746</a></p> <p>Niu Yawei (yawei.niu@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12746" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12746</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5916" title="OST pool inheritence is no longer persistent (no LOV EA for child directory)" class="issue-link" data-issue-key="LU-5916"><del>LU-5916</del></a> lod: inherit default pool setting properly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 2<br/> Commit: 4c11c85c283bb200cadc492be42b298aefea1177</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12746/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12746/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5916" title="OST pool inheritence is no longer persistent (no LOV EA for child directory)" class="issue-link" data-issue-key="LU-5916"><del>LU-5916</del></a> lod: inherit default pool setting properly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e8214d6bd4ccc3ff386c77904664c60f1848ef11</p> <p>Patch landed to Master.</p> <p>Could a backport to b2_5 be considered? The patch fixes a critical regression.</p> <p>Sure, I'm going to port it to b2_5.</p> <p>Niu Yawei (yawei.niu@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13411" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13411</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5916" title="OST pool inheritence is no longer persistent (no LOV EA for child directory)" class="issue-link" data-issue-key="LU-5916"><del>LU-5916</del></a> lod: inherit default pool setting properly<br/> Project: fs/lustre-release<br/> Branch: b2_5<br/> Current Patch Set: 1<br/> Commit: 840c3fa79c535578b17037ae9f3f6a4838255531</p> <p>port to b2_5: <a href="http://review.whamcloud.com/#/c/13411/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/13411/</a></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13411/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13411/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5916" title="OST pool inheritence is no longer persistent (no LOV EA for child directory)" class="issue-link" data-issue-key="LU-5916"><del>LU-5916</del></a> lod: inherit default pool setting properly<br/> Project: fs/lustre-release<br/> Branch: b2_5<br/> Current Patch Set: <br/> Commit: 56211bf18fbca9930d77cea1ee0e3f2d83d59ec4</p> Related Development Rank 1|hzx0uv: Rank (Obsolete) 16515 Severity