https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5963 Lustre <p>Sometimes recovery-small tests 50-52 failed on 8 CPU box. with leak a export reference. After some investigation i see nodemap don't able to found own entry for an export, but export still linked to node map. (i don't know why intel land something without any debug options in code?). per additional investigation i see someone </p> <p>commit 83f04354ff68a14d7492e35a9576c91492a1206c<br/> Author: Joshua Walgenbach &lt;jjw@iu.edu&gt;<br/> Date: Mon Mar 3 09:10:20 2014 +0100</p> <p> <a href="https://jira.whamcloud.com/browse/LU-4647" title="Add idmapping functions for nodemap" class="issue-link" data-issue-key="LU-4647"><del>LU-4647</del></a> nodemap: add mapping functional<br/> Signed-off-by: Joshua Walgenbach &lt;jjw@iu.edu&gt;<br/> Signed-off-by: Kit Westneat &lt;kit.westneat@gmail.com&gt;<br/> Reviewed-on: <a href="http://review.whamcloud.com/9299" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/9299</a><br/> Tested-by: Jenkins<br/> Reviewed-by: Andreas Dilger &lt;andreas.dilger@intel.com&gt;<br/> Reviewed-by: Nathaniel Clark &lt;nathaniel.l.clark@intel.com&gt;</p> <p>have a bad inspection and allow to "hash" an export pointer as string.<br/> so if any byte will be changed in export after add - we don't able to find something in hash.</p> master from now. LU-5963

wrong hashing in LU-4647

Bug Blocker Resolved Fixed Nathaniel Clark Alexey Lyashkov HB nodemap patch Fri, 28 Nov 2014 19:58:57 +0000 Wed, 3 Dec 2014 13:47:04 +0000 Wed, 3 Dec 2014 13:47:04 +0000 Lustre 2.7.0 Lustre 2.7.0 0 5 <p>this patch fixes problem</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">@@ -50,7 +52,12 @@ void nm_member_putref(struct obd_export *exp) <span class="code-keyword">static</span> __u32 nm_member_hashfn(cfs_hash_t *hash_body, <span class="code-keyword">const</span> void *key, unsigned mask) { - <span class="code-keyword">return</span> cfs_hash_djb2_hash(key, strlen(key), mask); + unsigned <span class="code-object">long</span> hash; +<span class="code-comment">// <span class="code-keyword">return</span> cfs_hash_djb2_hash(key, strlen(key), mask); </span>+ hash = hash_long((unsigned <span class="code-object">long</span>)key, hash_body-&gt;hs_bkt_bits) &amp; mask; + + CDEBUG(D_INFO, <span class="code-quote">"hashing %p -&gt; %lu\n"</span>, key, hash); + <span class="code-keyword">return</span> hash; } </pre> </div></div> <p>Alexey Lyashkov (alexey.lyashkov@seagate.com) uploaded a new patch: <a href="http://review.whamcloud.com/12881" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12881</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5963" title="wrong hashing in LU-4647" class="issue-link" data-issue-key="LU-5963"><del>LU-5963</del></a> nodemap: use proper hashing<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b42e666cab01a40d867f88c0691846b03fc3fa25</p> <p><a href="http://review.whamcloud.com/12881" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12881</a></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12881/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12881/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5963" title="wrong hashing in LU-4647" class="issue-link" data-issue-key="LU-5963"><del>LU-5963</del></a> nodemap: use proper hashing<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b0236f7b024b5f76d8915334480dd6387f71451f</p> <p>Merged to master</p> Related LU-4647 LU-5928 Development Rank 1|hzx1nj: Rank (Obsolete) 16655 Severity