https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-5983 Lustre <p>The recent commit 0ad4f8a4227ed7dd93fec99d33c6bb25056473fc for "<a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> lprocfs: remove last of non seq data structs and functions." breaks some lustre builds. In particular the problem comes from the renaming of the lustre internal routine lprocfs_try_remove_proc_entry() to remove_proc_subtree(). Newer linux kernels have their own exported remove_proc_subtree() API that conflicts. This is true in both the latest el6.6 kernel and the el7 kernel.</p> <p>My first inclination was to add autoconf support for leaving out lustre's own remove_proc_subtree() if there is one in linux, but on careful examination it appears the linux instances aren't quite identical to the lustre implementation. I think the best course is to change the lustre routine back to its original name, so it won't conflict. I will push a patch to do so.</p> <p>The only reason this hasn't shown up in current review builds is that it is only a problem in the newest el6.6 (not yet landed) and in server builds. We aren't doing el7 server builds yet.</p> LU-5983

builds broken by LU-5275 fix

Bug Blocker Resolved Fixed Bob Glossman Bob Glossman Thu, 4 Dec 2014 16:36:58 +0000 Tue, 9 Dec 2014 20:13:22 +0000 Tue, 9 Dec 2014 20:13:21 +0000 Lustre 2.7.0 0 5 <p>I have one last patch for <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> coming which should address these problems.</p> <p>James, which patch you are talking about? In <a href="http://review.whamcloud.com/12235" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12235</a> you have the same issue. I cannot find other pathes for <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a>.</p> <p>The issue is you define following function:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">#ifndef HAVE_ONLY_PROCFS_SEQ extern void remove_proc_subtree(<span class="code-keyword">const</span> <span class="code-object">char</span> *name, struct proc_dir_entry *parent); #endif </pre> </div></div> <p>but in Linux headers we have following:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">extern <span class="code-object">int</span> remove_proc_subtree(<span class="code-keyword">const</span> <span class="code-object">char</span> *name, struct proc_dir_entry *parent); </pre> </div></div> <p>Bob Glossman (bob.glossman@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12931" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12931</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-5983" title="builds broken by LU-5275 fix" class="issue-link" data-issue-key="LU-5983"><del>LU-5983</del></a> build: fix build failures from recent landing<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 85fcc6f4df4718c9ec44d596ee0f5fed226303a4</p> <p>Dmitry in the new patch I fixed that. Bob does RHEL6.6 define proc_remove()? </p> <p>James, I see EXPORT_SYMBOL(remove_proc_subtree). I don't see any export proc_remove</p> <p>just a simple rename didn't work. see build failure of <a href="http://review.whamcloud.com/12931" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12931</a></p> <p>The latest patch from <a href="https://jira.whamcloud.com/browse/LU-5275" title="clean up technical debt for proc_dir_entry changes" class="issue-link" data-issue-key="LU-5275"><del>LU-5275</del></a> might of fixed it. Will see the fall out in Maloo soon.</p> <p>Patch <a href="http://review.whamcloud.com/#/c/12235" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/12235</a> should resolve this.</p> <p>Patch has been reverted. We can close this ticket.</p> <p>Closing ticket per last comment. Patch was reverted.</p> Related LU-5275 Development Rank 1|hzx1w7: Rank (Obsolete) 16698 Severity