https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6073 Lustre <p>In lustre/tests/</p> {multiop,orphan_linkea_check} <p>.c we should include sys/xattr.h (provided by glibc-headers) rather than attr/xattr.h (provided by libattr-devel) since the former is more likely to be installed and has all of the needed declarations.</p> LU-6073

lustre/tests/*.c should use sys/xattr.h rather than attr/xattr.h

Bug Minor Resolved Fixed John Hammond John Hammond Mon, 29 Dec 2014 15:44:02 +0000 Wed, 16 Mar 2016 04:49:25 +0000 Fri, 20 Feb 2015 16:13:54 +0000 Lustre 2.7.0 Lustre 2.7.0 Lustre 2.8.0 0 7 <p>Just ran into this issue.</p> <p>Just as a data point I had builds fail on several of my long time builder VMs due to this issue. I had not installed the libattr-devel rpms everywhere which contains the /usr/include/attr files. They were never needed before the mod using &lt;attr/xattr.h&gt; landed in master. While the problem went away as soon as I did install the additional rpm I agree that it would be preferable to use the more commonly available &lt;sys/xattr.h&gt; instead.</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13197" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13197</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6073" title="lustre/tests/*.c should use sys/xattr.h rather than attr/xattr.h" class="issue-link" data-issue-key="LU-6073"><del>LU-6073</del></a> tests: use sys/xattr.h in tests/*.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2c3b572d3e2d2499189fdf17bb9c51d519193b28</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13197/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13197/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6073" title="lustre/tests/*.c should use sys/xattr.h rather than attr/xattr.h" class="issue-link" data-issue-key="LU-6073"><del>LU-6073</del></a> tests: use sys/xattr.h in tests/*.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9c2e4c1075a66e8576d2fa9bed2c771a1c206fde</p> <p>Patch landed to master.</p> <p>Reopening to add fix version</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15391" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15391</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6073" title="lustre/tests/*.c should use sys/xattr.h rather than attr/xattr.h" class="issue-link" data-issue-key="LU-6073"><del>LU-6073</del></a> tests: use sys/xattr.h in tests/mpi/*.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: dd687d03f0ded47fc1e715d047a48898ea0a90c6</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15392" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15392</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6073" title="lustre/tests/*.c should use sys/xattr.h rather than attr/xattr.h" class="issue-link" data-issue-key="LU-6073"><del>LU-6073</del></a> build: add -Wall to CFLAGS for test/ and utils/<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e6c9e5d829ede1a8a114da73f945cf3bdf10b7b1</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15391/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15391/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6073" title="lustre/tests/*.c should use sys/xattr.h rather than attr/xattr.h" class="issue-link" data-issue-key="LU-6073"><del>LU-6073</del></a> tests: use sys/xattr.h in tests/mpi/*.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1178a9f7dc53b8ecfc5b76c494c8156bc039f4be</p> <p>The patch at <a href="http://review.whamcloud.com/15392" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15392</a> resolves the issue reported in <a href="https://jira.whamcloud.com/browse/LU-6835" title="lfs.c:481: error: implicit declaration of function &#39;futimes&#39;" class="issue-link" data-issue-key="LU-6835"><del>LU-6835</del></a>, as well as another issue which I did not have time to create a ticket for. Repeating some information here so it can be found via search. Some implicit declarations were introduced by <a href="http://review.whamcloud.com/15217" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15217</a> (a801262) in libiam.c and lfs.c</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[ 280s] cc1: warnings being treated as errors [ 280s] lfs.c: In function 'migrate_copy_timestamps': [ 280s] lfs.c:481: error: implicit declaration of function 'futimes' </pre> </div></div> <p>and</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[ 175s] cc1: warnings being treated as errors [ 175s] libiam.c: In function 'lfix_root': [ 175s] libiam.c:155: error: implicit declaration of function 'cpu_to_le64' [ 175s] libiam.c:156: error: implicit declaration of function 'cpu_to_le16' [ 175s] libiam.c:187: error: implicit declaration of function 'cpu_to_le32' </pre> </div></div> <p>As an aside, it seems like bad practice to re-use a ticket like this, as well as piggy back the "#include" changes on <a href="http://review.whamcloud.com/15392" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15392</a></p> Related LU-6027 Development Rank 1|hzx32v: Rank (Obsolete) 16899 Severity