Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-6079] missing NR_CPUS definition in socklnd https://jira.whamcloud.com/browse/LU-6079 Lustre <p>the problem was introduced with commit Id10683e95277791f9c99492907369a608b28a1fb: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lnet: remove lnet/include/lnet/linux/</p> LU-6079

missing NR_CPUS definition in socklnd

Bug Trivial Resolved Fixed Alex Zhuravlev Alex Zhuravlev Sat, 3 Jan 2015 11:09:58 +0000 Mon, 12 Jan 2015 19:05:18 +0000 Mon, 12 Jan 2015 19:05:18 +0000 Lustre 2.7.0 Lustre 2.7.0 0 7 <p>Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13229" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13229</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6079" title="missing NR_CPUS definition in socklnd" class="issue-link" data-issue-key="LU-6079"><del>LU-6079</del></a> lnet: add missing include to define NR_CPUS<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3bcf43ec63538d158ca33dcde139910866249554</p> <p>What is the specific need for this patch? It isn't causing problems on any of the kernels that we are currently building. </p> <p> CC <span class="error">[M]</span> /work/lustre/head3/lnet/klnds/socklnd/socklnd.o<br/> In file included from /work/lustre/linux-2.6.32-431.el6/arch/x86/include/asm/irq.h:11:0,<br/> from /work/lustre/head3/lnet/klnds/socklnd/socklnd.h:34,<br/> from /work/lustre/head3/lnet/klnds/socklnd/socklnd.c:44:<br/> /work/lustre/linux-2.6.32-431.el6/arch/x86/include/asm/irq_vectors.h:171:7: error: "NR_CPUS" is not defined <span class="error">[-Werror=undef]</span><br/> In file included from /work/lustre/head3/lnet/klnds/socklnd/socklnd.h:34:0,<br/> from /work/lustre/head3/lnet/klnds/socklnd/socklnd.c:44:<br/> /work/lustre/linux-2.6.32-431.el6/arch/x86/include/asm/irq.h:38:1: error: unknown type name 'bool'<br/> /work/lustre/linux-2.6.32-431.el6/arch/x86/include/asm/irq.h:38:45: error: 'struct pt_regs' declared inside parameter list <span class="error">[-Werror]</span><br/> /work/lustre/linux-2.6.32-431.el6/arch/x86/include/asm/irq.h:38:45: error: its scope is only this definition or declaration, which is probably not what you want <span class="error">[-Werror]</span><br/> /work/lustre/linux-2.6.32-431.el6/arch/x86/include/asm/irq.h:40:35: error: 'struct pt_regs' declared inside parameter list <span class="error">[-Werror]</span><br/> /work/lustre/linux-2.6.32-431.el6/arch/x86/include/asm/irq.h:43:37: error: expected ')' before numeric constant<br/> cc1: all warnings being treated as errors</p> <p>gcc version 4.7.2 (GCC)</p> <p>It seems the core probkem is that we are including <asm/irq.h> instead of the proper <linux/*.h> header. </p> <p>right, it actually builds fine with no <asm/irq.h>. the updated patch has been pushed to gerrit.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13229/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13229/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6079" title="missing NR_CPUS definition in socklnd" class="issue-link" data-issue-key="LU-6079"><del>LU-6079</del></a> lnet: remove asm/irq.h include<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e19162ca0dbfb261c69c2f63bb3ecb67a337eb27</p> <p>Landed for 2.7</p> Development Rank 1|hzx35r: Rank (Obsolete) 16912 Severity